Hi, normally I don't criticise other peoples code but I just saw the kexec code in YaST. Just a call "kexec -e"! The current program and kernel is gone: No umount, no sync, no SCR flush, no start-script cleanup, no halt according to AutoYaST, no nothing. Use the method that has been there for years: Tell linuxrc what to do. Look at yast_inf_finish.ycp. I already pointed there last week on IRC. ciao Arvin -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
On Monday 07 April 2008 16:01:06 you wrote:
Hi,
normally I don't criticise other peoples code but I just saw the kexec code in YaST. Just a call "kexec -e"! The current program and kernel is gone: No umount, no sync, no SCR flush, no start-script cleanup, no halt according to AutoYaST, no nothing.
disks are unmount in this phase. It is really end of installation. If I call sync nothing will be written into disk ;-) But if you want I can add: sync, SCR flush, etc...
Use the method that has been there for years: Tell linuxrc what to do. Look at yast_inf_finish.ycp. I already pointed there last week on IRC.
ciao Arvin
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
* Jozef Uhliarik [2008-04-07 16:33]:
On Monday 07 April 2008 16:01:06 you wrote:
normally I don't criticise other peoples code but I just saw the kexec code in YaST. Just a call "kexec -e"! The current program and kernel is gone: No umount, no sync, no SCR flush, no start-script cleanup, no halt according to AutoYaST, no nothing.
disks are unmount in this phase. It is really end of installation. If I call sync nothing will be written into disk ;-) But if you want I can add: sync, SCR flush, etc...
kexec does sync itself. No need to do that in YaST. Bernhard -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
On Mon, Apr 07, 2008 at 04:33:41PM +0200, Jozef Uhliarik wrote:
On Monday 07 April 2008 16:01:06 you wrote:
Hi,
normally I don't criticise other peoples code but I just saw the kexec code in YaST. Just a call "kexec -e"! The current program and kernel is gone: No umount, no sync, no SCR flush, no start-script cleanup, no halt according to AutoYaST, no nothing.
disks are unmount in this phase. It is really end of installation. If I call sync nothing will be written into disk ;-) But if you want I can add: sync, SCR flush, etc...
As maintainer of the startup scripts I definitely want the steps done there to be executed. But you could also just make it the right way. ciao Arvin -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
As maintainer of the startup scripts I definitely want the steps done there to be executed.
But you could also just make it the right way.
ciao Arvin
I agree. I will prepare better solution. ;-) Jozef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
On Monday 07 April 2008 16:33, Jozef Uhliarik wrote:
disks are unmount in this phase. It is really end of installation. If I call sync nothing will be written into disk ;-) But if you want I can add: sync, SCR flush, etc...
I fear that's too simplistic for many scenarios. IMHO it's _much_ safer to do
it in the tried and tested way: Let the "first phase shut-down" scripts do
whatever they need to do and return a value to linuxrc that tells it to
call "kexec".
If we begin to add all that shut-down code to that "kexec" branch in the YCP
code, we will end up duplicating a lot of code very quickly. Worse, we might
introduce new bugs in the not-so-common installation scenarios (e.g., VNC
installation, ssh installation) and of course in AutoYaST.
CU
--
Stefan Hundhammer
participants (4)
-
Arvin Schnell -
Bernhard Walle -
Jozef Uhliarik -
Stefan Hundhammer