[yast-devel] Webyast - patch module backend
Hi, I look at this module and it looks like quite chaotic and not much readable. I think that I can improve it. What do you think about separate package kit handling to separate library, set model as usual at other modules (and use pkgkit library) and controller should contain only error handling? Josef -- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
* Josef Reidinger <jreidinger@suse.cz> [Aug 03. 2009 18:13]:
Hi, I look at this module and it looks like quite chaotic and not much readable.
Yeah, it was one of the first modules. I guess, if we look back to our current modules after we gain more experience, we'll feel an urgent need to refactor too ;-)
I think that I can improve it. What do you think about separate package kit handling to separate library, set model as usual at other modules (and use pkgkit library) and controller should contain only error handling?
Looks like a reasonable approach. However, patch module is not of highest importance right now. So I'd suggest to postpone its refactoring and work on other modules first. Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
On 08/04/2009 08:26 AM, Klaus Kaempf wrote:
* Josef Reidinger <jreidinger@suse.cz> [Aug 03. 2009 18:13]:
Hi, I look at this module and it looks like quite chaotic and not much readable.
Yeah, it was one of the first modules. I guess, if we look back to our current modules after we gain more experience, we'll feel an urgent need to refactor too ;-)
Yeah, I know it :)
I think that I can improve it. What do you think about separate package kit handling to separate library, set model as usual at other modules (and use pkgkit library) and controller should contain only error handling?
Looks like a reasonable approach. However, patch module is not of highest importance right now. So I'd suggest to postpone its refactoring and work on other modules first.
OK.
Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-- Josef Reidinger YaST team maintainer of perl-Bootloader, YaST2-Repair, webyast modules language and time -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
participants (2)
-
Josef Reidinger -
Klaus Kaempf