[yast-devel] Re: [yast-commit] <web-client> master : Remove all empty 'alt=' tags
Klaus KXXmpf napsal(a):
ref: refs/heads/master commit a8b23a8cb484a9735881979a22df51be165720cf Author: Klaus Kämpf <kkaempf@suse.de> Date: Wed Jul 15 10:37:35 2009 +0200
Remove all empty 'alt=' tags --- webclient/app/views/controlpanel/index.rhtml | 8 ++++---- webclient/app/views/controlpanel/show_all.rhtml | 2 +- webclient/app/views/hosts/edit.html.erb | 4 ++-- webclient/app/views/hosts/index.html.erb | 2 +- webclient/app/views/hosts/new.html.erb | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)
<snip> diff --git a/webclient/app/views/hosts/index.html.erb b/webclient/app/views/hosts/index.html.erb index bc7ab27..feb6e34 100644 --- a/webclient/app/views/hosts/index.html.erb +++ b/webclient/app/views/hosts/index.html.erb @@ -36,7 +36,7 @@ </tbody>
</table> - <input class="button jqModal" type="submit" value="Add" id="add-host" /> + <%= link_to _('Add'), new_host_path, :class => "button" %> <!-- FIXME may be add remove and edit buttons and get rid of the icons above <input class="button disabled" disabled="true" type="submit" value="Remove" id="remove-printer"/>
Hi, I don't understand this change. If it is part of form, that direct link doesn't work, does? And if it is separated button that do action (think this is that case) why not use button_to? Is there some magic in rails that I don't see? -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
* josef reidinger <jreidinger@suse.cz> [Jul 15. 2009 11:07]:
</table> - <input class="button jqModal" type="submit" value="Add" id="add-host" /> + <%= link_to _('Add'), new_host_path, :class => "button" %> <!-- FIXME may be add remove and edit buttons and get rid of the icons above <input class="button disabled" disabled="true" type="submit" value="Remove" id="remove-printer"/>
Hi, I don't understand this change. If it is part of form, that direct link doesn't work, does? And if it is separated button that do action (think this is that case) why not use button_to? Is there some magic in rails that I don't see?
The <input...> didn't work at all, so to get to the 'add host' page, I simply replaced it with a link. But 'button_to' is an even better solution, now it looks right. Thanks, I didn't know about 'button_to' before ! Klaus --- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
participants (2)
-
josef reidinger
-
Klaus Kaempf