[yast-devel] Builtins.time
Hello, ich have removed all calls -Builtins.time- from the YaST code. This call is marked as deprecated. So the question has been raised if we should remove this call from builtins.rb completely in order not providing it anymore. What is your opinion ? Greetings Stefan -- ******************************************************************************* Stefan Schubert e-mail: schubi@suse.de ------------------------------------------------------------------------------- SUSE LINUX GmbH GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Tue, 5 Apr 2016 13:38:22 +0200 Stefan Schubert <schubi@suse.de> wrote:
Hello, ich have removed all calls -Builtins.time- from the YaST code. ^^^
nice :)
This call is marked as deprecated. So the question has been raised if we should remove this call from builtins.rb completely in order not providing it anymore.
What is your opinion ?
Well, my opinion as there is still some team that plan to port their yast modules to SLE12 and maybe start with SP2 like OES, then we should not complicate too much their job by removing API. So my suggestion is to remove all deprecated calls for SLE13.
Greetings Stefan
Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 04/05/2016 02:54 PM, Josef Reidinger wrote:
On Tue, 5 Apr 2016 13:38:22 +0200 Stefan Schubert <schubi@suse.de> wrote:
Hello, ich have removed all calls -Builtins.time- from the YaST code. ^^^
nice :)
This call is marked as deprecated. So the question has been raised if we should remove this call from builtins.rb completely in order not providing it anymore.
What is your opinion ?
Well, my opinion as there is still some team that plan to port their yast modules to SLE12 and maybe start with SP2 like OES, then we should not complicate too much their job by removing API. So my suggestion is to remove all deprecated calls for SLE13.
Which bring us back to https://lists.opensuse.org/yast-devel/2016-02/msg00028.html There is not point in choosing one date or another if we don't maintain a list of deprecated stuff we plan to remove, so the removal is known in advance. The simplest solution would be to have a list of functions and modules somewhere (a wiki, a file in yast.github.io). Announcing in this mailing list every time we add an item to the list. In addition, we should mark the code as deprecated (a comment would be enough, a deprecation message in the logs would be also appreciated). Cheers. -- Ancor González Sosa YaST Team at SUSE Linux GmbH -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Wed, 6 Apr 2016 09:53:46 +0200 Ancor Gonzalez Sosa <ancor@suse.de> wrote:
On 04/05/2016 02:54 PM, Josef Reidinger wrote:
On Tue, 5 Apr 2016 13:38:22 +0200 Stefan Schubert <schubi@suse.de> wrote:
Hello, ich have removed all calls -Builtins.time- from the YaST code. ^^^
nice :)
This call is marked as deprecated. So the question has been raised if we should remove this call from builtins.rb completely in order not providing it anymore.
What is your opinion ?
Well, my opinion as there is still some team that plan to port their yast modules to SLE12 and maybe start with SP2 like OES, then we should not complicate too much their job by removing API. So my suggestion is to remove all deprecated calls for SLE13.
Which bring us back to https://lists.opensuse.org/yast-devel/2016-02/msg00028.html
There is not point in choosing one date or another if we don't maintain a list of deprecated stuff we plan to remove, so the removal is known in advance.
The simplest solution would be to have a list of functions and modules somewhere (a wiki, a file in yast.github.io). Announcing in this mailing list every time we add an item to the list. In addition, we should mark the code as deprecated (a comment would be enough, a deprecation message in the logs would be also appreciated).
I agree that it would be useful. E.g. when I was in USA and work with OES team, then this page[1] is very very useful when we found problem and if not found, then I have to dig into changelog or git history to find what is removed and by what it is replaced. Just note that please never use deprecation message as old testsuite is so cool tuned, that any new log message can break it in general stuff like whole yast2 (I try it in past and it break horrible a lot of packages and its testsuite). If it is leap package and nothing depends on it, then we do not need to keep API :) Josef
Cheers.
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Wed, 2016-04-06 at 10:02 +0200, Josef Reidinger wrote: Hi all,
I agree that it would be useful. E.g. when I was in USA and work with OES team, then this page[1] is very very useful when we found problem and if not found, then I have to dig into changelog or git history to find what is removed and by what it is replaced.
I think you forgot the link [1] :)
Just note that please never use deprecation message as old testsuite is so cool tuned, that any new log message can break it in general stuff like whole yast2 (I try it in past and it break horrible a lot of packages and its testsuite). If it is leap package and nothing depends on it, then we do not need to keep API :)
Even in the logs? Regards, Imo -- Imobach González Sosa YaST Team at SUSE LINUX GmbH
On Wed, 06 Apr 2016 09:19:16 +0100 Imobach González Sosa <igonzalezsosa@suse.de> wrote:
On Wed, 2016-04-06 at 10:02 +0200, Josef Reidinger wrote:
Hi all,
I agree that it would be useful. E.g. when I was in USA and work with OES team, then this page[1] is very very useful when we found problem and if not found, then I have to dig into changelog or git history to find what is removed and by what it is replaced.
I think you forgot the link [1] :)
right, my fault, it is this one https://en.opensuse.org/openSUSE:YaST:_Porting_from_SLE11_to_SLE12
Just note that please never use deprecation message as old testsuite is so cool tuned, that any new log message can break it in general stuff like whole yast2 (I try it in past and it break horrible a lot of packages and its testsuite). If it is leap package and nothing depends on it, then we do not need to keep API :)
Even in the logs?
Yes, as old testsuite compare content of logs to ensure it works as expected ( yes, I also cannot believe it when I see it first time ). Josef
Regards, Imo
participants (4)
-
Ancor Gonzalez Sosa -
Imobach González Sosa -
Josef Reidinger -
Stefan Schubert