Improve given information in crash popups
Hi folks! Related to [1], I'd like to update error messages where YaST suggest the user filling a bug report because some of them[2][3] does not include the hint about collection logs with save_y2logs command. What do you think? Is there any reason for keeping them as they are? Do you have any other proposal? Do you think is there any other place where save_y2logs deserves to be mention? Thank you! [1] https://bugzilla.suse.com/show_bug.cgi?id=1194342#c4 [2] https://github.com/yast/yast-yast2/blob/8c6f0fe1d8b82da1c76d227defa2cd447818... [3] https://github.com/yast/yast-yast2/blob/8c6f0fe1d8b82da1c76d227defa2cd447818... -- David Díaz YaST Team at SUSE LINUX GmbH IRC: dgdavid
Dne 2022-01-05 22:31, David Díaz napsal:
https://github.com/yast/yast-yast2/blob/8c6f0fe1d8b82da1c76d227defa2cd447818... https://github.com/yast/yast-yast2/blob/8c6f0fe1d8b82da1c76d227defa2cd447818...
Thanks for the code pointers David, let me add the handlers for the beloved Internal Error popup (which mentions save_y2logs) and some other popups. Note that these are NOT translated. https://github.com/yast/yast-ruby-bindings/blob/ecb36408ca9b1812fc2486bd2ef1... On the one hand, cleaning this up would help the users file better bugs, on the other hand, exception handling code is harder to test than usual, so refactoring it is risky. Martin
Dne 05. 01. 22 v 22:31 David Díaz napsal(a):
Hi folks!
Related to [1], I'd like to update error messages where YaST suggest the user filling a bug report because some of them[2][3] does not include the hint about collection logs with save_y2logs command.
Maybe we could even go further and add a [Save logs] button directly to the popup. We could run `save_y2logs` after pressing it and then display "Logs saved to /tmp/y2log-foo.tar.xz" message. (Where? Below the buttons?). Ladislav -- Ladislav Slezák YaST Developer SUSE LINUX, s.r.o. Corso IIa Křižíkova 148/34 18600 Praha 8
On Thu, 6 Jan 2022 10:14:18 +0100 Ladislav Slezák <lslezak@suse.com> wrote:
Dne 05. 01. 22 v 22:31 David Díaz napsal(a):
Hi folks!
Related to [1], I'd like to update error messages where YaST suggest the user filling a bug report because some of them[2][3] does not include the hint about collection logs with save_y2logs command.
Maybe we could even go further and add a [Save logs] button directly to the popup. We could run `save_y2logs` after pressing it and then display "Logs saved to /tmp/y2log-foo.tar.xz" message. (Where? Below the buttons?).
I agree with mvidner, that code in exception handler should be really trivial and as simple as possible. So I would not make it harder than it is and simple save_y2logs pointer should be easy. Josef
Ladislav
On 2022-01-06 10:14, Ladislav Slezák wrote:
Maybe we could even go further and add a [Save logs] button directly to the popup. We could run `save_y2logs` after pressing it and then display "Logs saved to /tmp/y2log-foo.tar.xz" message. (Where? Below the buttons?).
Yes, that sounds good. But remember that a while ago save_y2logs became a separate package, and it may or may not be installed; so I'd offer that button only if save_y2logs is there. Kind regards -- Stefan Hundhammer <shundhammer@suse.de> YaST Developer SUSE Software Solutions Germany GmbH GF: Ivo Totev; HRB 36809, AG Nürnberg
participants (5)
-
David Díaz -
josef Reidinger -
Ladislav Slezák -
Martin Vidner -
Stefan Hundhammer