[yast-devel] Re: [yast-commit] r64609 - in /trunk/add-on: VERSION package/yast2-add-on.changes src/add-on-workflow.ycp

On Tue, Jun 28, 2011 at 09:35:08AM -0000, lslezak@svn2.opensuse.org wrote:
URL: http://svn.opensuse.org/viewcvs/yast?rev=64609&view=rev
Modified: trunk/add-on/src/add-on-workflow.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/add-on/src/add-on-workflow.ycp?re... ============================================================================== --- trunk/add-on/src/add-on-workflow.ycp (original) +++ trunk/add-on/src/add-on-workflow.ycp Tue Jun 28 11:35:07 2011 @@ -180,6 +180,8 @@ y2milestone ("Starting repository sequence"); symbol ret = Sequencer::Run (aliases, sequence);
+ if (ret != `abort) + { list <integer> sources_after = Pkg::SourceGetCurrent (false); y2milestone ("Sources with new one added: %1", sources_after);
@@ -219,6 +221,7 @@ y2milestone ("Saving all sources"); Pkg::SourceSaveAll(); } + }
Ha! Bad indentation! Please indent the code that is being put in a condition. If you think that would be too much indentation, maybe it's a good opportunity to factor it out.
AddOnProduct::last_ret = ret; y2milestone ("MediaSelect Dialog ret: %1", ret);
-- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

On Fri, Jul 01, 2011 at 07:14:50PM +0200, Martin Vidner wrote:
Ha! Bad indentation!
... which was fixed up in an immediately following commit. My bad, I shouldn't use tunnel vision while reviewing. -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu
participants (1)
-
Martin Vidner