[yast-devel] quick fix of build failures
With the latest core in autobuild, many testsuites fail, because they cannot get a real UI. But the testsuite explicitly asks for the dummy UI, that does nothing. "y2base foo.ycp UI" means "if foo calls UI:: it just gets nil" Apparently that has been changed into "if foo calls UI: load either qt or ncurses" I think we should revert to the previous behavior, but first let HuHa explain the reasons for the change. In any case, I attach a quick fix that makes the yast2.rpm testsuite pass for me, while still letting the real UI work (on core/libyui/doc/examples/PackageSelector-empty.ycp) -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu
On Wednesday 20 February 2008 16:26, Martin Vidner wrote:
void YUI::ensureUICreated() { + return; // quick fix[TM]
This will effectively destroy the very purpose of separating the UI from the Y2 / YCP infrastructure: To be able to use the UI from a plain C++ program. For that, the UI needs to be able to bootstrap itself when a client application begins making UI calls. I just added some code that should prevent really creating a UI in the case of the "dummy UI", i.e., for test cases. Please test. CU -- Stefan Hundhammer <sh@suse.de> Penguin by conviction. YaST2 Development SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Nürnberg, Germany -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
On Wednesday 20 February 2008 16:26, Martin Vidner wrote:
With the latest core in autobuild, many testsuites fail, because they cannot get a real UI. But the testsuite explicitly asks for the dummy UI, that does nothing. "y2base foo.ycp UI" means "if foo calls UI:: it just gets nil" Apparently that has been changed into "if foo calls UI: load either qt or ncurses"
Fixed in SVN trunk. Coolo submits a package. CU -- Stefan Hundhammer <sh@suse.de> Penguin by conviction. YaST2 Development SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Nürnberg, Germany -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
participants (2)
-
Martin Vidner -
Stefan Hundhammer