[yast-devel] yast2-auth-server fails to build with GCC 5 (fwd)
Just to make sure this doesn't get lost (SRs against package are not accepted). Richard. ---------- Forwarded message ---------- Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5 See patch below (default args are not valid in a typedef context). Thanks, Richard. --- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09 10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1 typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function ); class OlcConfigEntry { -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules. Just to know, SR against package is useless, you have to modify it on github. Otherwise next automatic submission from git remove it. Josef On Fri, 10 Apr 2015 13:26:32 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
Just to make sure this doesn't get lost (SRs against package are not accepted).
Richard.
---------- Forwarded message ---------- Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5
See patch below (default args are not valid in a typedef context).
Thanks, Richard.
--- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09
10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1
typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function );
class OlcConfigEntry {
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 10.4.2015 v 14:25 Josef Reidinger napsal(a):
Just to know, SR against package is useless, you have to modify it on github. Otherwise next automatic submission from git remove it.
Yes, the packages are automatically submitted from Git repos, if you want to contribute to Yast see [1]. Thanks in advance! I just have updated the OBS project description to describe how to contribute to YaST. See [2]. [1] http://yastgithubio.readthedocs.org/en/latest/contributing/ [2] https://build.opensuse.org/project/show/YaST:Head -- Best Regards Ladislav Slezák Yast Developer ------------------------------------------------------------------------ SUSE LINUX, s.r.o. e-mail: lslezak@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Fri, 10 Apr 2015, Josef Reidinger wrote:
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules.
The issue is still not fixed in Factory and blocks GCC 5 adoption. The YaST development model doesn't seem sustainable if such fixes can't be applied within two weeks. And no, I don't want to get "involved" in YaST development other than sending you a trivial fix. Richard.
Just to know, SR against package is useless, you have to modify it on github. Otherwise next automatic submission from git remove it.
Josef
On Fri, 10 Apr 2015 13:26:32 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
Just to make sure this doesn't get lost (SRs against package are not accepted).
Richard.
---------- Forwarded message ---------- Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5
See patch below (default args are not valid in a typedef context).
Thanks, Richard.
--- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09
10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1
typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function );
class OlcConfigEntry {
-- Richard Biener <rguenther@suse.de> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton HRB 21284 (AG Nuernberg) -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Mon, 27 Apr 2015 10:45:21 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Fri, 10 Apr 2015, Josef Reidinger wrote:
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules.
The issue is still not fixed in Factory and blocks GCC 5 adoption. The YaST development model doesn't seem sustainable if such fixes can't be applied within two weeks.
It has nothing do to with yast developement model, just with specific part of yast that is not maintained by Yast Team. I just found that ckornacker no longer work for SUSE. So I add to CC also Mili and if you really need to do something I recommend to escalate it to him or visit him personally. So Peter looks only one who maintain these new modules now. In urgent case I can also merge your fix, but I do not want to act behind maintainers back. Josef
And no, I don't want to get "involved" in YaST development other than sending you a trivial fix.
Richard.
Just to know, SR against package is useless, you have to modify it on github. Otherwise next automatic submission from git remove it.
Josef
On Fri, 10 Apr 2015 13:26:32 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
Just to make sure this doesn't get lost (SRs against package are not accepted).
Richard.
---------- Forwarded message ---------- Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5
See patch below (default args are not valid in a typedef context).
Thanks, Richard.
--- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09
10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1 typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function ); class OlcConfigEntry {
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 27.4.2015 11:23, Josef Reidinger wrote:
On Mon, 27 Apr 2015 10:45:21 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Fri, 10 Apr 2015, Josef Reidinger wrote:
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules.
The issue is still not fixed in Factory and blocks GCC 5 adoption. The YaST development model doesn't seem sustainable if such fixes can't be applied within two weeks.
It has nothing do to with yast developement model, just with specific part of yast that is not maintained by Yast Team.
I just found that ckornacker no longer work for SUSE. So I add to CC also Mili and if you really need to do something I recommend to escalate it to him or visit him personally. So Peter looks only one who maintain these new modules now. In urgent case I can also merge your fix, but I do not want to act behind maintainers back.
Thanks for taking care, Josef. Anyway, during the SLE offsite, I've got a feedback, that "it's hard to contribute to Yast, because people would need to not only learn Ruby, C++, Perl or even YCP, but also how to work with Git and GitHub". Some people would prefer to send us patches via e-mail or put them into Bugzilla (or on floppy). Just consider the fact that what seems to be easy for us, might be a "big challenge" for others. I think that this is a valid point. The only problem I see is that we might not like the patch enough and we might want to refactor it. Then I'd propose to use the patch as-is and do the refactoring later in the same PR. Or we could send the patch back with comments, depends. The question is - Do we want it? Opinions? Thanks in advance. Lukas -- Lukas Ocilka, Systems Management (Yast) Team Leader SLE Department, SUSE Linux -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Anyway, during the SLE offsite, I've got a feedback, that "it's hard to contribute to Yast, because people would need to not only learn Ruby, C++, Perl or even YCP, but also how to work with Git and GitHub". Some people would prefer to send us patches via e-mail or put them into Bugzilla (or on floppy). Just consider the fact that what seems to be easy for us, might be a "big challenge" for others.
it already happened in network ... twice. Patches were pretty simple usually related to proper usage of a tool (Dell's biosdevname), or fixing a corner case.
I think that this is a valid point. The only problem I see is that we might not like the patch enough and we might want to refactor it. Then I'd propose to use the patch as-is and do the refactoring later in the same PR. Or we could send the patch back with comments, depends. The question is - Do we want it?
i've worked exactly this way. it turned out that it makes easy to pass through review on our side (code quality, ...) even on contributors side when done this way. Michal -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 28.4.2015 v 08:46 Lukas Ocilka napsal(a):
Anyway, during the SLE offsite, I've got a feedback, that "it's hard to contribute to Yast, because people would need to not only learn Ruby, C++, Perl or even YCP, but also how to work with Git and GitHub".
Git and GitHub as an obstacle? Really? If I think of the "good" old times with SVN and email patches... Anyway, a patch sent via email is still better then nothing, so we should accept the contributions also in this form. I guess 90% of the Yast code is now in Ruby (or YcpRuby...). You do not need to learn the other languages unless you dig into Yast internals (core, ruby-bindings = C++) or work on a specific module (users = Perl). BTW we have a new contributing documentation [1], if it does not describe something we can add it.
Some people would prefer to send us patches via e-mail or put them into Bugzilla (or on floppy). Just consider the fact that what seems to be easy for us, might be a "big challenge" for others.
I think a patch in bugzilla or via email is OK if it is a simple change. For complex patches which need some discussion or review by more people then PR at GitHub is way better.
I think that this is a valid point. The only problem I see is that we might not like the patch enough and we might want to refactor it. Then I'd propose to use the patch as-is and do the refactoring later in the same PR. Or we could send the patch back with comments, depends. The question is - Do we want it?
It depends, if the refactoring would not require comment from the author and was easy I'd use the original patch and refactor it in a separate commit. For more complex refactoring I'd probably sent the commented patch back. [1] http://yastgithubio.readthedocs.org/en/latest/contributing/ -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Am 27.04.2015 um 11:23 schrieb Josef Reidinger:
On Mon, 27 Apr 2015 10:45:21 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Fri, 10 Apr 2015, Josef Reidinger wrote:
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules. The issue is still not fixed in Factory and blocks GCC 5 adoption. The YaST development model doesn't seem sustainable if such fixes can't be applied within two weeks. It has nothing do to with yast developement model, just with specific part of yast that is not maintained by Yast Team.
I just found that ckornacker no longer work for SUSE. So I add to CC also Mili and if you really need to do something I recommend to escalate it to him or visit him personally. So Peter looks only one who maintain these new modules now. In urgent case I can also merge your fix, but I do not want to act behind maintainers back.
Josef
thanks Josef, I apologize we're in the hot phase of a product release and did not have time yet to focus on this. I'm adding Howard Guo, he is replacing ckornacker in that respect. Please explain the issue and he will take it from there (I'm currently travelling and won't be able to address this before Thursday. regards mili
And no, I don't want to get "involved" in YaST development other than sending you a trivial fix.
Richard.
Just to know, SR against package is useless, you have to modify it on github. Otherwise next automatic submission from git remove it.
Josef
On Fri, 10 Apr 2015 13:26:32 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
Just to make sure this doesn't get lost (SRs against package are not accepted).
Richard.
---------- Forwarded message ---------- Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5
See patch below (default args are not valid in a typedef context).
Thanks, Richard.
--- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09 10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1 typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function ); class OlcConfigEntry {
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Tue, 28 Apr 2015, Milisav Radmanic wrote:
Am 27.04.2015 um 11:23 schrieb Josef Reidinger:
On Mon, 27 Apr 2015 10:45:21 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Fri, 10 Apr 2015, Josef Reidinger wrote:
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules. The issue is still not fixed in Factory and blocks GCC 5 adoption. The YaST development model doesn't seem sustainable if such fixes can't be applied within two weeks. It has nothing do to with yast developement model, just with specific part of yast that is not maintained by Yast Team.
I just found that ckornacker no longer work for SUSE. So I add to CC also Mili and if you really need to do something I recommend to escalate it to him or visit him personally. So Peter looks only one who maintain these new modules now. In urgent case I can also merge your fix, but I do not want to act behind maintainers back.
Josef
thanks Josef, I apologize we're in the hot phase of a product release and did not have time yet to focus on this. I'm adding Howard Guo, he is replacing ckornacker in that respect. Please explain the issue and he will take it from there (I'm currently travelling and won't be able to address this before Thursday.
See below with a trivial patch.
From rguenther@suse.de Thu Apr 9 10:51:07 2015 Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5
See patch below (default args are not valid in a typedef context). Thanks, Richard. --- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09 10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1 typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function ); class OlcConfigEntry { -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Hi Howard, welcome on board, if you need any help regarding yast do not hesitate to ask yast team. As this issue blocks gcc5 integration, I think it should have priority as rest of yast is already adapted. So do not hesitate to contact us on mailing list or on freenode#yast Thanks Josef On Tue, 28 Apr 2015 11:25:25 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Tue, 28 Apr 2015, Milisav Radmanic wrote:
Am 27.04.2015 um 11:23 schrieb Josef Reidinger:
On Mon, 27 Apr 2015 10:45:21 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Fri, 10 Apr 2015, Josef Reidinger wrote:
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules. The issue is still not fixed in Factory and blocks GCC 5 adoption. The YaST development model doesn't seem sustainable if such fixes can't be applied within two weeks. It has nothing do to with yast developement model, just with specific part of yast that is not maintained by Yast Team.
I just found that ckornacker no longer work for SUSE. So I add to CC also Mili and if you really need to do something I recommend to escalate it to him or visit him personally. So Peter looks only one who maintain these new modules now. In urgent case I can also merge your fix, but I do not want to act behind maintainers back.
Josef
thanks Josef, I apologize we're in the hot phase of a product release and did not have time yet to focus on this. I'm adding Howard Guo, he is replacing ckornacker in that respect. Please explain the issue and he will take it from there (I'm currently travelling and won't be able to address this before Thursday.
See below with a trivial patch.
From rguenther@suse.de Thu Apr 9 10:51:07 2015 Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5
See patch below (default args are not valid in a typedef context).
Thanks, Richard.
--- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09 10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1
typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function );
class OlcConfigEntry {
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Good day Josef. A pull request has been created with Richard's patch applied: https://github.com/yast/yast-auth-server/pull/20 Regards, Howard On 28/04/15 12:33, Josef Reidinger wrote:
Hi Howard, welcome on board, if you need any help regarding yast do not hesitate to ask yast team. As this issue blocks gcc5 integration, I think it should have priority as rest of yast is already adapted. So do not hesitate to contact us on mailing list or on freenode#yast
Thanks Josef
On Tue, 28 Apr 2015 11:25:25 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Tue, 28 Apr 2015, Milisav Radmanic wrote:
On Mon, 27 Apr 2015 10:45:21 +0200 (CEST) Richard Biener <rguenther@suse.de> wrote:
On Fri, 10 Apr 2015, Josef Reidinger wrote:
Hi, I think you did it right to write ckornacker and varkoly, they are maintainers of yast2-auth-server. YaST team itself do not handle it, just do mass changes affecting all modules. The issue is still not fixed in Factory and blocks GCC 5 adoption. The YaST development model doesn't seem sustainable if such fixes can't be applied within two weeks. It has nothing do to with yast developement model, just with specific part of yast that is not maintained by Yast Team.
I just found that ckornacker no longer work for SUSE. So I add to CC also Mili and if you really need to do something I recommend to escalate it to him or visit him personally. So Peter looks only one who maintain these new modules now. In urgent case I can also merge your fix, but I do not want to act behind maintainers back.
Josef
Am 27.04.2015 um 11:23 schrieb Josef Reidinger: thanks Josef, I apologize we're in the hot phase of a product release and did not have time yet to focus on this. I'm adding Howard Guo, he is replacing ckornacker in that respect. Please explain the issue and he will take it from there (I'm currently travelling and won't be able to address this before Thursday.
See below with a trivial patch.
From rguenther@suse.de Thu Apr 9 10:51:07 2015 Date: Thu, 9 Apr 2015 10:51:07 +0200 (CEST) From: Richard Biener <rguenther@suse.de> To: ckornacker@suse.com, varkoly@suse.com Subject: yast2-auth-server fails to build with GCC 5
See patch below (default args are not valid in a typedef context).
Thanks, Richard.
--- yast2-auth-server-3.1.13/lib/slapd-config.h.orig 2015-04-09 10:47:38.777711978 +0200 +++ yast2-auth-server-3.1.13/lib/slapd-config.h 2015-04-09 10:47:45.377785905 +0200 @@ -28,7 +28,7 @@ #define SLAPD_LOG_ERR 1
typedef void (SlapdConfigLogCallback) (int level, const std::string &msg, - const char* file=0, const int line=0, const char* function=0 ); + const char* file, const int line, const char* function );
class OlcConfigEntry {
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (7)
-
Howard Guo -
Josef Reidinger -
Ladislav Slezak -
Lukas Ocilka -
Michal Filka -
Milisav Radmanic -
Richard Biener