On 06/18/2013 05:52 PM, Cristian Rodríguez wrote:
El 18/06/13 05:21, Lukas Ocilka escribió: Yes I have comments ;)
Thanks!
- I suggest not to use the "runlevel" name anywhere.
Yep, already suggested by Duncan. Runlevel-Ruby is a Work In Progress name bound to be changed.
- I strongly suggest that you do not call systemctl from the module, this is the most important part, please use the systemd dbus api for YAST.
I've thoroughly went through all the pros and cons and I will not use D-BUS API as it's too low level and I would need to create special high-level API (library) to be used from YaST, plus I would need to maintain it. Using D-BUS API is similar to creating sockets and all the handling just to download a file if I could simply use Net::HTTP.get instead. Anyway, if there was a library (that could be used from Ruby) using D-BUS API, I would use it. I could not find any and it seems such library doesn't exist. BTW, implementation sounds like a nice HackWeek or Workshop project.
- You can currently do all operations except setting the default target using the DBUS-API , this limitation has been corrected recently and a systemd supporting this operation will land later in factory.
Right now, I have to create a symlink anyway. I wonder why nobody objected that commandline doesn't support setting the default target. Bye Lukas -- Lukas Ocilka, Cloud & Systems Management Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org