[yast-devel] [PATCH] yast2-core: agent-process: fix stdout/stderr test cases

23 Nov 2011

When running the stdout and stderr test cases while building yast2-core
for ARM, we execute processes slower than the yast developer machines
apparently :).

The test cases expect data to flow between the ycp code and cat within
50 ms, but we can't guarantee that. In fact, it basically never worked
in my tests.

The real fix would probably to listen on the socket and see if new data
comes in and only then read from there, but I'm not sure it's worth it
for a test case. Instead, we can just increase the sleeps to something
really high so we definitely catch all the shiny new data on the other
end of the pipe.

Please apply.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 agent-process/testsuite/tests/stderr.ycp |    8 ++++----
 agent-process/testsuite/tests/stdout.ycp |    8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/agent-process/testsuite/tests/stderr.ycp b/agent-process/testsuite/tests/stderr.ycp
index 3d420e2..74282aa 100644
--- a/agent-process/testsuite/tests/stderr.ycp
+++ b/agent-process/testsuite/tests/stderr.ycp
@@ -8,12 +8,12 @@
     string out1 = (string)SCR::Read(.read_stderr, id);
 
     SCR::Write(., id, "foo\n");
-    sleep(50);
+    sleep(500);
     // read "foo\n"
     string out2 = (string)SCR::Read(.read_stderr, id);
 
     SCR::Write(., id, "foo2\nfoo2\n");
-    sleep(50);
+    sleep(500);
     // read "foo2\nfoo2\n"
     string out3 = (string)SCR::Read(.read_stderr, id);
 
@@ -35,12 +35,12 @@
     string out1 = (string)SCR::Read(.read_line_stderr, id);
 
     SCR::Write(., id, "foo\n");
-    sleep(50);
+    sleep(500);
     // read "foo\n"
     string out2 = (string)SCR::Read(.read_line_stderr, id);
 
     SCR::Write(., id, "foo2\nfoo2\n");
-    sleep(50);
+    sleep(500);
     // read "foo2\n"
     string out3 = (string)SCR::Read(.read_line_stderr, id);
 
diff --git a/agent-process/testsuite/tests/stdout.ycp b/agent-process/testsuite/tests/stdout.ycp
index 86c29fd..f1d0241 100644
--- a/agent-process/testsuite/tests/stdout.ycp
+++ b/agent-process/testsuite/tests/stdout.ycp
@@ -8,12 +8,12 @@
     string out1 = (string)SCR::Read(.read, id);
 
     SCR::Write(., id, "foo\n");
-    sleep(50);
+    sleep(500);
     // read "foo\n"
     string out2 = (string)SCR::Read(.read, id);
 
     SCR::Write(., id, "foo2\nfoo2\n");
-    sleep(50);
+    sleep(500);
     // read "foo2\nfoo2\n"
     string out3 = (string)SCR::Read(.read, id);
 
@@ -34,12 +34,12 @@
     string out1 = (string)SCR::Read(.read_line, id);
 
     SCR::Write(., id, "foo\n");
-    sleep(50);
+    sleep(500);
     // read "foo\n"
     string out2 = (string)SCR::Read(.read_line, id);
 
     SCR::Write(., id, "foo2\nfoo2\n");
-    sleep(50);
+    sleep(500);
     // read "foo2\n"
     string out3 = (string)SCR::Read(.read_line, id);
 
-- 
1.6.0.2

-- 
To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org
To contact the owner, e-mail: yast-devel+owner@opensuse.org

    