On Tue, 13 May 2014 15:10:24 +0200 Arvin Schnell <aschnell@suse.de> wrote:
On Tue, May 13, 2014 at 03:05:56PM +0200, Josef Reidinger wrote:
On Tue, 13 May 2014 10:41:26 +0200 Josef Reidinger <jreidinger@suse.cz> wrote:
After discussions on lunch, IRC and also directly in pull request I change slightly API.
If noone have objections I will add it tomorrow and start modifying users of API to use it.
Examples of usage:
# getter Bootloader.kernel_param("cio_ignore", :recovery)
# setter Bootloader.modify_kernel_params(:common, :recovery, :xen_guest, "crashkernel" => "256M@64M")
I think it's confusing to once pass the target as second parameter and the other time the value.
Regards, Arvin
OK, valid objection. If I change it to Bootloader.kernel_param(:recovery, "cio_ignore") then it won't be possible to specify default value of flavor ( now :common ). So it is question what worse. but I think non-confusing API is more important, so I just remove default for flavor Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org