Hello, On Nov 26 18:03 Lukas Ocilka wrote (excerpt):
On 26.11.2014 09:27, Josef Reidinger wrote:
3) Add a button [Apply current settings] which works exactly like "ok" but without quitting. Initially disabled. Enabled once the user has changed something.
Well, it is more tricky as sometimes is hard to know if you need "reload" or if you need "restart". For some changes is enough to send SIGHUP, but for some changes real restart is needed including temporary unavailability of service or reset of existing connections. From serious bussiness point of view it is huge difference. And for "Apply" it is not clear for me what is effects.
[Apply] is a good idea. Whether service needs to be restarted, reloaded or stopped & started again should be hidden behind the module API. It would just provide `apply_settings` method without any details.
On Nov 26 18:16 Lukas Ocilka additionally wrote (excerpt):
Whenever we can't decide what is the correct decision, we have to ask user.
Only all those together makes sense from my point of view: Have a simple [Apply] button but when the service does not support a really safe "reload" method (i.e. that neither makes the service temporaryly unavailability nor resets existing connections), then ask the user for confirmation if he wants to disrupt the currently running service to apply the new settings right now. As far as I understand it this means the `apply_settings` method whould have to be able to ask the user if needed. Kind Regards Johannes Meixner -- SUSE LINUX GmbH -- Maxfeldstrasse 5 -- 90409 Nuernberg -- Germany HRB 21284 (AG Nuernberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org