On Wed, 30 Nov 2011 09:58:13 -0000 gs@svn2.opensuse.org wrote:
Author: gs Date: Wed Nov 30 10:58:12 2011 New Revision: 66973
URL: http://svn.opensuse.org/viewcvs/yast?rev=66973&view=rev Log: don't allow to change AUTO_VLAN setting for a configured device, call fcoeadm -d correctly
Modified: branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp
Modified: branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp?rev=66973&r1=66972&r2=66973&view=diff ============================================================================== --- branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp (original) +++ branches/SuSE-Code-11-SP2-Branch/fcoe-client/src/complex.ycp Wed Nov 30 10:58:12 2011 @@ -83,7 +83,10 @@ y2milestone( "Calling %1", command ); map output = (map)SCR::Execute( .target.bash_output, command ); y2milestone( "Output: %1", output ); - + if ( output["exit"]:255 != 0 ) + { + Popup::Error( sformat( _("Command %1 failed"), command ) ); + }
Hi, I see this as quite common practice in YaST and I don't like it much. 1) I am user and I see this error Command <blabla> failed. What it means for me? is something broken? what should I do? retry it? report bug? Also it would be nice if there is details section which add e.g. stderr output for experienced users. 2) You report error, fine. So I am user and click OK and YaST continue doing something ( your error is in foreach loop that run set of commands ). This is very strange behavior for me. Josef -- Josef Reidinger Software Engineer Appliance Department SUSE LINUX, s. r. o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic jreidinger@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org