On 11/02/2011 06:38 PM, Ladislav Slezak wrote:
Dne 2.11.2011 14:51, locilka@svn2.opensuse.org napsal(a):
Author: locilka Date: Wed Nov 2 14:51:17 2011 New Revision: 66662
URL: http://svn.opensuse.org/viewcvs/yast?rev=66662&view=rev Log: - Unified starting, stopping and checking for firewall status (bnc#727445)
- //if (Mode::normal() || Mode::commandline()) { - foreach (string service, firewall_services, { - if (Service::Status(service) == 0) { - started = true; - break; - } - }); - //} + if (Mode::testsuite()) return true;
WATCH OUT! This breaks many testsuites!!
E.g. in yast2-nis-client, yast2-nfs-client, yast2-nfs-server, see https://build.opensuse.org/project/monitor?project=YaST%3AHead
Their tests expect the call in the output, they fail with this diff:
-Execute .target.bash "/sbin/service SuSEfirewall2_init status" $["TERM":"raw"] 0
Either fix the code or the affected tests.
So I'll fix the tests. IMO they might be wrong anyway, if they are affected by change in SuSEfirewall internals. Thanks for reporting. L. -- Lukas Ocilka, Appliances Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org