On 12/15/23 16:35, Ancor Gonzalez Sosa wrote:
While testing my new code that adds a most-representative country to each one of the timezones known by Agama (so it's easier for the users to find their zones), I found my code was able to do the work for 434 out of 473 timezones.
In a few cases it actually makes sense to have timezones that are associated to no country at all (UTC), but in other cases I was not sure whether I should try to fix the problem or simply drop the timezone from the list.
So I wrote this report (as a Gist so it's easier to edit): https://gist.github.com/ancorgs/8bd5f42ea847e1ba7590bc7e3d54cdad
What should we do for each category?
Obviously in the case A there is nothing to fix. For C, I would add a couple of exceptions to the code, making the name conversion. I wouldn't know how to handle the case D. Keep the timezone without the country? Drop that timezone? Open a PR to langtable to add GS (South Georgia and the South Sandwich Islands)? For all other cases, I would first go for the drastic approach and would remove the timezones from Agama. We offer more than 450 timezones, sure the users can find something that is fully equivalent (in many occasions, that equivalent timezone is even called in a VERY similar way). Cheers. -- Ancor González Sosa YaST Team at SUSE Software Solutions