Author: aschnell Date: Sun Dec 21 17:47:06 2008 New Revision: 54319 URL: http://svn.opensuse.org/viewcvs/yast?rev=54319&view=rev Log: - removed unneeded checks - extended testsuite Modified: trunk/core/libycp/src/YCPBuiltinSymbol.cc trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.err trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.out trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.ycp Modified: trunk/core/libycp/src/YCPBuiltinSymbol.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/libycp/src/YCPBuiltinSymbol.cc?rev=54319&r1=54318&r2=54319&view=diff ============================================================================== --- trunk/core/libycp/src/YCPBuiltinSymbol.cc (original) +++ trunk/core/libycp/src/YCPBuiltinSymbol.cc Sun Dec 21 17:47:06 2008 @@ -34,7 +34,7 @@ static YCPValue s_tosymbol (const YCPString& v) { - /* @builtin tostring + /* @builtin tosymbol * @short Converts a string to a symbol. * * @param string VALUE @@ -43,11 +43,7 @@ * @usage tosymbol("test") -> `test */ - if (v.isNull()) - return YCPNull(); - if (v->valuetype() == YT_STRING) - return YCPSymbol(v->asString()->value()); - return YCPNull(); + return YCPSymbol(v->value()); } Modified: trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.err URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.err?rev=54319&r1=54318&r2=54319&view=diff ============================================================================== --- trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.err (original) +++ trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.err Sun Dec 21 17:47:06 2008 @@ -6,3 +6,8 @@ ---------------------------------------------------------------------- tosymbol ("test") ---------------------------------------------------------------------- +Parsed: +---------------------------------------------------------------------- +tosymbol (nil) +---------------------------------------------------------------------- +[Interpreter] tests/builtin/Builtin-Symbol.ycp:14 Argument (nil) to tosymbol(...) is nil Modified: trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.out URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.out?rev=54319&r1=54318&r2=54319&view=diff ============================================================================== --- trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.out (original) +++ trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.out Sun Dec 21 17:47:06 2008 @@ -1,2 +1,3 @@ ("** tosymbol **") (`test) +(nil) Modified: trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.ycp?rev=54319&r1=54318&r2=54319&view=diff ============================================================================== --- trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.ycp (original) +++ trunk/core/libycp/testsuite/tests/builtin/Builtin-Symbol.ycp Sun Dec 21 17:47:06 2008 @@ -11,4 +11,5 @@ ("** tosymbol **") (tosymbol ("test")) +(tosymbol (nil)) -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org