Author: mvidner Date: Fri Jul 10 13:04:29 2009 New Revision: 58005 URL: http://svn.opensuse.org/viewcvs/yast?rev=58005&view=rev Log: Fixed org.opensuse.YaST.modules.ModuleManager.Import to return false on failure. DBusMsg::addBoolean was broken in 2 ways and Import is the only user. Modified: branches/tmp/mvidner/core-dbus-values/dbus/namespace_service/testsuite/t3-unknown-method.py branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.cc branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.h Modified: branches/tmp/mvidner/core-dbus-values/dbus/namespace_service/testsuite/t3-unknown-method.py URL: http://svn.opensuse.org/viewcvs/yast/branches/tmp/mvidner/core-dbus-values/dbus/namespace_service/testsuite/t3-unknown-method.py?rev=58005&r1=58004&r2=58005&view=diff ============================================================================== --- branches/tmp/mvidner/core-dbus-values/dbus/namespace_service/testsuite/t3-unknown-method.py (original) +++ branches/tmp/mvidner/core-dbus-values/dbus/namespace_service/testsuite/t3-unknown-method.py Fri Jul 10 13:04:29 2009 @@ -31,7 +31,7 @@ MM_o = dbus.SessionBus().get_object('org.opensuse.YaST.modules', '/org/opensuse/YaST/modules') MM = dbus.Interface(MM_o, 'org.opensuse.YaST.modules.ModuleManager') -# self.assertFalse(MM.Import("UNKNOWN")) + self.assertFalse(MM.Import("UNKNOWN")) # TODO more sense to raise on error than return false # self.assertRaisesDBus("", MM.Import, "UNKNOWN") Modified: branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.cc URL: http://svn.opensuse.org/viewcvs/yast/branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.cc?rev=58005&r1=58004&r2=58005&view=diff ============================================================================== --- branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.cc (original) +++ branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.cc Fri Jul 10 13:04:29 2009 @@ -124,9 +124,9 @@ return addValue(DBUS_TYPE_INT32, &val); } -bool DBusMsg::addBoolean(bool val) +bool DBusMsg::addBoolean(dbus_bool_t val) { - return addValue(DBUS_TYPE_INT64, &val); + return addValue(DBUS_TYPE_BOOLEAN, &val); } bool DBusMsg::addDouble(double val) Modified: branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.h URL: http://svn.opensuse.org/viewcvs/yast/branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.h?rev=58005&r1=58004&r2=58005&view=diff ============================================================================== --- branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.h (original) +++ branches/tmp/mvidner/core-dbus-values/liby2dbus/src/DBusMsg.h Fri Jul 10 13:04:29 2009 @@ -42,7 +42,7 @@ bool addString(const std::string &val); bool addInt64(dbus_int64_t val); bool addInt32(dbus_int32_t val); - bool addBoolean(bool val); + bool addBoolean(dbus_bool_t val); bool addDouble(double val); bool addYCPValue(const YCPValue &val); -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org