Author: jsuchome Date: Mon Mar 31 15:58:50 2008 New Revision: 45888

URL: http://svn.opensuse.org/viewcvs/yast?rev=45888&view=rev Log: - use the real password in the Password fields (bnc#374787) - change the label for the additional groups (bnc#367926) - fixed incorrect usage of YCPValue in crack-agent (bnc#375385) - 2.16.21

Modified: trunk/users/agent-crack/src/CrackAgent.cc trunk/users/package/yast2-users.changes trunk/users/src/dialogs.ycp trunk/users/src/helps.ycp trunk/users/src/inst_root_first.ycp trunk/users/src/inst_user_first.ycp

Modified: trunk/users/agent-crack/src/CrackAgent.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/users/agent-crack/src/CrackAgent.... ============================================================================== --- trunk/users/agent-crack/src/CrackAgent.cc (original) +++ trunk/users/agent-crack/src/CrackAgent.cc Mon Mar 31 15:58:50 2008 @@ -58,14 +58,14 @@ YCPValue CrackAgent::Execute(const YCPPath &path, const YCPValue& value, const YCPValue& arg) { - const char *pass = value->toString().c_str(); + string pass = value->asString()->value(); const char *dictpath = "/usr/lib/cracklib_dict"; if (!arg.isNull()) { dictpath = arg->asString()->value().c_str(); }

- const char *out = FascistCheck (pass, dictpath); + const char *out = FascistCheck (pass.c_str(), dictpath); if (out) { return YCPString (out); }

Modified: trunk/users/package/yast2-users.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/users/package/yast2-users.changes... ============================================================================== --- trunk/users/package/yast2-users.changes (original) +++ trunk/users/package/yast2-users.changes Mon Mar 31 15:58:50 2008 @@ -1,4 +1,12 @@ ------------------------------------------------------------------- +Mon Mar 31 15:48:58 CEST 2008 - jsuchome@suse.cz + +- use the real password in the Password fields (bnc#374787) +- change the label for the additional groups (bnc#367926) +- fixed incorrect usage of YCPValue in crack-agent (bnc#375385) +- 2.16.21 + +------------------------------------------------------------------- Wed Mar 26 10:51:12 CET 2008 - jsuchome@suse.cz

- installation proposal: show full name and encryption method

Modified: trunk/users/src/dialogs.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/users/src/dialogs.ycp?rev=45888&a... ============================================================================== --- trunk/users/src/dialogs.ycp (original) +++ trunk/users/src/dialogs.ycp Mon Mar 31 15:58:50 2008 @@ -143,6 +143,9 @@ Users::SetUseNextTime (false); }

+ map display_info = UI::GetDisplayInfo (); + boolean text_mode = display_info["TextMode"]:false; + map<string,any>user = Users::GetCurrentUser (); string error_msg = "";

@@ -541,8 +544,8 @@ group memberships can be changed.")) : `VSpacing (0), `VSpacing(0.5), `HBox( - `HSpacing (1), - `VBox( + text_mode ? `Empty () : `HSpacing (1), + `HWeight (3, `VBox( `VSpacing (0.5), `Top(`InputField( `id(`uid), `opt (`hstretch), // textentry label @@ -556,20 +559,20 @@ `Top(edit_shell), `Top(edit_defaultgroup), `VStretch() - ), - `HSpacing(2), - `VBox( + )), + text_mode ? `Empty () : `HSpacing (2), + `HWeight (2, `VBox ( `VSpacing (0.5), `MultiSelectionBox( `id(`grouplist), // selection box label - _("Gr&oups"), additional_groups), + _("Additional Gr&oups"), additional_groups), (user_type == "ldap") ? `MultiSelectionBox( `id(`ldapgrouplist), // selection box label _("&LDAP Groups"), additional_ldap_groups) : `Empty() - ), - `HSpacing (1) + )), + text_mode ? `Empty () : `HSpacing (1) ), `VSpacing(0.5) ),

Modified: trunk/users/src/helps.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/users/src/helps.ycp?rev=45888&... ============================================================================== --- trunk/users/src/helps.ycp (original) +++ trunk/users/src/helps.ycp Mon Mar 31 15:58:50 2008 @@ -428,7 +428,7 @@ </p>") + // help text 8/8 _("<p> -<b>Groups:</b> +<b>Additional Groups:</b> Select the additional groups in which the user should be a member. </p> ");

Modified: trunk/users/src/inst_root_first.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/users/src/inst_root_first.ycp?rev... ============================================================================== --- trunk/users/src/inst_root_first.ycp (original) +++ trunk/users/src/inst_root_first.ycp Mon Mar 31 15:58:50 2008 @@ -45,13 +45,11 @@ `VSpacing(0.8), `Password (`id(`pw1), `opt (`hstretch), // Label: get password for user root - _("&Password for root User"), - password == "" ? "" : "*****"), + _("&Password for root User"), password), `VSpacing(0.8), `Password (`id(`pw2), `opt (`hstretch), // Label: get same password again for verification - _("Con&firm Password"), - password == "" ? "" : "*****") + _("Con&firm Password"), password) )), `VStretch () );

Modified: trunk/users/src/inst_user_first.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/users/src/inst_user_first.ycp?rev... ============================================================================== --- trunk/users/src/inst_user_first.ycp (original) +++ trunk/users/src/inst_user_first.ycp Mon Mar 31 15:58:50 2008 @@ -380,9 +380,9 @@ // input field for login name _("&Username"),username), `Password (`id (`pw1), `opt (`hstretch), Label::Password(), - password == nil ? "" : "*****"), + password == nil ? "" : password), `Password (`id (`pw2), `opt (`hstretch), Label::ConfirmPassword(), - password == nil ? "" : "*****") + password == nil ? "" : password) );

term optionbox = `VBox ( @@ -575,6 +575,7 @@ if (contains ([`back, `abort, `cancel, `next], ret)) break; } +y2internal ("password is %1", password); if (ret == `next) { UsersSimple::SetAfterAuth (auth_method);