Author: locilka Date: Fri Aug 26 13:43:21 2011 New Revision: 65404 URL: http://svn.opensuse.org/viewcvs/yast?rev=65404&view=rev Log: - Fixed Custom Rules dialog to handle additional flags (bnc#712670) Modified: branches/SuSE-Code-11-SP1-Branch/firewall/package/yast2-firewall.changes branches/SuSE-Code-11-SP1-Branch/firewall/src/subdialogs.ycp branches/SuSE-Code-11-SP1-Branch/firewall/src/summary.ycp branches/SuSE-Code-11-SP1-Branch/firewall/src/uifunctions.ycp Modified: branches/SuSE-Code-11-SP1-Branch/firewall/package/yast2-firewall.changes URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/firewall/package/yast2-firewall.changes?rev=65404&r1=65403&r2=65404&view=diff ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/firewall/package/yast2-firewall.changes (original) +++ branches/SuSE-Code-11-SP1-Branch/firewall/package/yast2-firewall.changes Fri Aug 26 13:43:21 2011 @@ -1,4 +1,9 @@ ------------------------------------------------------------------- +Fri Aug 26 13:33:57 CEST 2011 - locilka@suse.cz + +- Fixed Custom Rules dialog to handle additional flags (bnc#712670) + +------------------------------------------------------------------- Fri Apr 2 15:24:40 CEST 2010 - locilka@suse.cz - Added missing help for accepting-broadcast-reply (BNC #583046). Modified: branches/SuSE-Code-11-SP1-Branch/firewall/src/subdialogs.ycp URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/firewall/src/subdialogs.ycp?rev=65404&r1=65403&r2=65404&view=diff ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/firewall/src/subdialogs.ycp (original) +++ branches/SuSE-Code-11-SP1-Branch/firewall/src/subdialogs.ycp Fri Aug 26 13:43:21 2011 @@ -903,7 +903,8 @@ _("Source Network"), _("Protocol"), _("Destination Port"), - _("Source Port") + _("Source Port"), + _("Options") ), [] ), @@ -930,7 +931,8 @@ `item( `id("_rpc_"), SuSEFirewall::GetProtocolTranslatedName("_rpc_")), ])), `InputField (`id("add_destination_port"), `opt (`hstretch), _("&Destination Port (Optional)")), - `InputField (`id("add_source_port"), `opt (`hstretch), _("&Source Port (Optional)")) + `InputField (`id("add_source_port"), `opt (`hstretch), _("&Source Port (Optional)")), + `InputField (`id("add_options"), `opt (`hstretch), _("Additiona &Options (Optional)")) ) ), Modified: branches/SuSE-Code-11-SP1-Branch/firewall/src/summary.ycp URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/firewall/src/summary.ycp?rev=65404&r1=65403&r2=65404&view=diff ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/firewall/src/summary.ycp (original) +++ branches/SuSE-Code-11-SP1-Branch/firewall/src/summary.ycp Fri Aug 26 13:43:21 2011 @@ -280,11 +280,12 @@ foreach (map one_rule, custom_rules, { string proto = one_rule["protocol"]:"tcp"; string one_rule_s = li_start + sformat ( - _("Network: <i>%1</i>, Protocol: <i>%2</i>, Destination port: <i>%3</i>, Source port: <i>%4</i>"), + _("Network: <i>%1</i>, Protocol: <i>%2</i>, Destination port: <i>%3</i>, Source port: <i>%4</i>, Options: <i>%5</i>"), String::EscapeTags (one_rule["network"]:_("All")), String::EscapeTags (SuSEFirewall::GetProtocolTranslatedName (one_rule["protocol"]:_("All"))), (one_rule["dport"]:"" != "" ? String::EscapeTags (UserReadablePortName (one_rule["dport"]:"", proto)) : _("All")), - (one_rule["sport"]:"" != "" ? String::EscapeTags (UserReadablePortName (one_rule["sport"]:"", proto)) : _("All")) + (one_rule["sport"]:"" != "" ? String::EscapeTags (UserReadablePortName (one_rule["sport"]:"", proto)) : _("All")), + (one_rule["options"]:"" != "" ? String::EscapeTags (one_rule["options"]:"") : _("None")) ) + li_end; rules = rules + one_rule_s; }); Modified: branches/SuSE-Code-11-SP1-Branch/firewall/src/uifunctions.ycp URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/firewall/src/uifunctions.ycp?rev=65404&r1=65403&r2=65404&view=diff ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/firewall/src/uifunctions.ycp (original) +++ branches/SuSE-Code-11-SP1-Branch/firewall/src/uifunctions.ycp Fri Aug 26 13:43:21 2011 @@ -1244,7 +1244,8 @@ one_rule["network"]:"", SuSEFirewall::GetProtocolTranslatedName (one_rule["protocol"]:""), UserReadablePortName (one_rule["dport"]:"", one_rule["protocol"]:""), - UserReadablePortName (one_rule["sport"]:"", "") + UserReadablePortName (one_rule["sport"]:"", ""), + one_rule["options"]:"" ); }); @@ -1324,6 +1325,7 @@ string add_protocol = (string) UI::QueryWidget(`id("add_protocol"), `Value); string add_destination_port = (string) UI::QueryWidget(`id("add_destination_port"), `Value); string add_source_port = (string) UI::QueryWidget(`id("add_source_port"), `Value); + string add_options = (string) UI::QueryWidget(`id("add_options"), `Value); // network is mandatory if (add_source_network == "" || ! CheckNetwork (add_source_network)) { @@ -1367,8 +1369,9 @@ $[ "network" : add_source_network, "protocol" : add_protocol, - "dport" : add_destination_port, - "sport" : add_source_port + "dport" : add_destination_port, + "sport" : add_source_port, + "options" : add_options, ] ); -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org