See <https://ci.opensuse.org/job/yast-yast-installation-master/179/display/redirect?page=changes> Changes: [Stefan.Hundhammer] First unmounter [Stefan.Hundhammer] Added /proc/mnt samples for unit tests [Stefan.Hundhammer] Added unit test and improved testability [Stefan.Hundhammer] Use common shortcut [Stefan.Hundhammer] Fixed rubocop complaint [Stefan.Hundhammer] Flatly refusing to make rubocop force me to use a less readable casecmp [Stefan.Hundhammer] Typo [Stefan.Hundhammer] Added usage sample to docs [Stefan.Hundhammer] Treat btrfs subvolumes like all other mounts [Stefan.Hundhammer] Implemented mvidner's code review suggestions [Stefan.Hundhammer] Fix up prefix with a trailing slash [Stefan.Hundhammer] Use method arg initializers directly [Stefan.Hundhammer] Use Pathname::cleanpath to fix up broken prefixes (as Ancor suggested) [Stefan.Hundhammer] Link to PR with extensive docs [Stefan.Hundhammer] Removed dead code [Stefan.Hundhammer] Refactored to modern style and made usable standalone [Stefan.Hundhammer] Adapted to modernized version [Stefan.Hundhammer] Removed obsolete requires and improved docs [Stefan.Hundhammer] Adapted unit test and made the tested method public [Stefan.Hundhammer] Fixed rubocop complaints [Stefan.Hundhammer] Change log and version bump [Stefan.Hundhammer] run wants no arguments after all [Stefan.Hundhammer] Better logging [Stefan.Hundhammer] Don't close SCR prematurely [Stefan.Hundhammer] Improved comment ------------------------------------------ [...truncated 135.51 KB...] [ 114s] when a valid repository is not found [ 114s] raises a NotValidRepo error [ 114s] when update could not be fetched [ 114s] raises a CouldNotFetchUpdateFromRepo error [ 114s] #repositories [ 114s] when no update was added [ 114s] returns an empty array [ 114s] when some update was added [ 114s] returns an array containing the updates [ 114s] #driver_updates [ 114s] when no driver updates exist [ 114s] returns an empty array [ 114s] when some driver update exist [ 114s] returns an array containing existing updates [ 114s] #apply_all [ 114s] applies all the updates [ 114s] does not replace the control file [ 114s] when some driver update exists [ 114s] also re-applies the driver updates [ 114s] when a new control file is available [ 114s] updates the control file [ 114s] #repositories? [ 114s] when some repository was added [ 114s] returns true [ 114s] when no repository was added [ 114s] returns false [ 114s] [ 114s] #<Yast::ImageInstallationClass:0x0000557f62610990> [ 114s] #FindImageSet [ 115s] finds images matching architecture and selected patterns and returns if processing was successful [ 115s] does not find any image using unsupported architecture and returns if processing was successful [ 115s] does not find any image using unsupported patterns and returns if processing was successful [ 115s] returns true if no xml is provided [ 115s] returns false and reports error if xml is not valid [ 115s] [ 115s] Installation::Services [ 115s] .enabled [ 115s] returns list of previously set services [ 115s] returns empty list if not set previously [ 115s] .enabled= [ 115s] sets list of services to enable [ 115s] raise exception if non-array is passed [ 115s] .write [ 115s] enables all services previously set [ 115s] raises Yast2::Systemd::ServiceNotFound exception if service to enable does not exist [ 115s] [ 115s] Installation::SshConfig [ 115s] .from_dir [ 115s] reads the name of the systems with /etc/os-release [ 115s] does not crash if /etc/os-release contains empty value [ 115s] uses 'Linux' as name for systems without /etc/os-release file [ 115s] uses name and version when PRETTY_NAME is missing in /etc/os-release [ 115s] stores all the keys and files with their names [ 115s] stores the content of the config files [ 115s] stores the content of both files for the keys [ 115s] uses the most recent file of each key to set #atime [ 115s] .write_files [ 115s] creates /etc/ssh/ if it does not exist [ 115s] reuses /etc/ssh if it's already there [ 115s] writes all the files by default [ 115s] writes only the key files if write_config_files is false [ 115s] writes only the config files if write_keys is false [ 115s] preserves original permissions for files and keys [ 115s] backups config files found in the target directory [ 115s] writes the original content for each file [ 115s] #keys_atime [ 115s] returns the access time of the most recently accessed key [ 115s] returns nil if no keys has been read [ 115s] [ 115s] Yast::InstUpdateInstaller [ 115s] #main [ 115s] cleans up the package management at the end [ 115s] displays a progress [ 115s] finishes the progress at the end [ 115s] when returning back from other dialog [ 115s] returns :back [ 115s] when some update is available [ 115s] and update works [ 115s] creates update file and returns :restart_yast [ 115s] copies the add-on packages from the self-update repository [ 115s] and update fails [ 115s] does not create any file and returns :next [ 115s] when the update cannot be fetched from a user defined repository [ 115s] shows an error and returns :next [ 115s] when the update cannot be fetched from a default repository [ 115s] does not show any error and returns :next [ 115s] when repository is empty [ 115s] does not restart YaST [ 115s] when a default repository can't be probed [ 115s] does not show any error and returns :next [ 115s] when a user defined repository can't be probed [ 115s] and self-update URL is remote [ 115s] shows a dialog suggesting to check the network configuration [ 115s] in AutoYaST installation or upgrade [ 115s] shows an error [ 115s] and self-update URL is not remote [ 115s] shows a dialog suggesting to check the network configuration [ 115s] when network is not available [ 115s] does not update the installer [ 115s] when a error happens while applying the update [ 115s] does not catch the exception [ 115s] when update is disabled through Linuxrc [ 115s] does not update the installer [ 115s] when restarting YaST2 [ 115s] finishes the restarting process [ 115s] and data file is available [ 115s] sets custom_url [ 115s] and data file is not available [ 115s] does not set custom_url [ 115s] and yast2-registration is not available [ 115s] does not load custom_url [ 115s] #update_installer [ 115s] when update works [ 115s] returns true [ 115s] when update fails [ 115s] returns false [ 115s] when the repository contains old packages [ 115s] does not update the installer [ 115s] [ 115s] Installation::SelfupdateVerifier [ 115s] #downgraded_packages [ 115s] returns the downgraded packages [ 115s] [ 115s] Installation::UpdateRepository [ 115s] #packages [ 115s] when the repository type can't be determined [ 115s] raises a NotValidRepo error [ 115s] when the repository can't be probed [ 115s] raises a CouldNotProbeRepo error [ 115s] when repository cannot be refreshed [ 115s] raises a CouldNotRefreshRepo error [ 115s] when the repo does not have packages [ 115s] returns an empty array [ 115s] when the source contains packages [ 115s] returns update repository packages sorted by name [ 115s] #fetch [ 115s] builds a squashed filesystem containing all updates [ 115s] when a package can't be retrieved [ 115s] raises a CouldNotFetchUpdate error [ 115s] when a package can't be extracted [ 115s] raises a CouldNotFetchUpdate error [ 115s] when a package can't be squashed [ 115s] raises a CouldNotFetchUpdate error [ 115s] #apply [ 115s] mounts and adds files/dir [ 115s] writes the list of updated packages to the /.packages.self_update file [ 115s] adds mounted filesystem to instsys.parts file [ 115s] when a squashed package can't be mounted [ 115s] raises a CouldNotMountUpdate error [ 115s] when files can't be added to inst-sys [ 115s] raises a CouldNotBeApplied error [ 115s] #cleanup [ 115s] deletes and releases the repository [ 116s] #user_defined? [ 116s] when origin is :user [ 116s] returns true [ 116s] when origin is :default [ 116s] returns false [ 116s] when origin is not specified [ 116s] returns false [ 116s] #remote? [ 116s] when is a remote URL according to libzypp [ 116s] returns true [ 116s] when is not a remote URL according to libzypp [ 116s] returns false [ 116s] #inspect [ 116s] does not contain sensitive information [ 116s] #to_s [ 116s] does not contain sensitive information [ 116s] [ 116s] Installation::SshImporterPresenter [ 116s] #summary [ 116s] when no previous configurations were found [ 116s] and mode is installation [ 116s] returns 'No previous Linux...' message [ 116s] and mode is autoinstallation [ 116s] returns 'No previous Linux...' message [ 116s] and mode is not installation or autoinstallation [ 116s] returns 'No previous Linux...' message [ 116s] when device is set and copy config is enabled [ 116s] returns 'SSH host keys and configuration...' [ 116s] when device is set and copy config is disabled [ 116s] returns 'SSH host keys will be copied...' [ 116s] [ 116s] Pending: (Failures listed here are expected and do not affect your suite's status) [ 116s] [ 116s] 1) Yast::InstallationMiscInclude [ 116s] # Not yet implemented [ 116s] # ./test/installation_misc_test.rb:12 [ 116s] [ 116s] 2) Installation::Clients::SecurityFinish#write when running in AutoYaST when firewall section is present calls AY client write [ 116s] # Temporarily skipped with xcontext [ 116s] # ./test/lib/clients/security_finish_test.rb:80 [ 116s] [ 116s] 3) Installation::Clients::SecurityFinish#write when running in AutoYaST when firewall section is not present configures firewall according to product settings [ 116s] # Temporarily skipped with xcontext [ 116s] # ./test/lib/clients/security_finish_test.rb:90 [ 116s] [ 116s] 4) Installation::PrepShrinkFinish#run first parameter "Write" shrink prep partitions too big [ 116s] # TODO: not converted to storage-ng yet [ 116s] # ./test/prep_shrink_test.rb:224 [ 116s] [ 116s] Failures: [ 116s] [ 116s] 1) Installation::Unmounter#new when reading the actual /proc/mounts file ignores /, /proc, /sys, /dev [ 116s] Failure/Error: expect(subject.ignored_paths).to include("/", "/proc", "/sys", "/dev") [ 116s] expected ["/proc", "/sys", "/dev/pts", "/dev/shm"] to include "/" and "/dev" [ 116s] # ./test/unmounter_test.rb:41:in `block (4 levels) in <top (required)>' [ 116s] [ 116s] Finished in 5.89 seconds (files took 2.24 seconds to load) [ 116s] 718 examples, 1 failure, 4 pending [ 116s] [ 116s] Failed examples: [ 116s] [ 116s] rspec ./test/unmounter_test.rb:40 # Installation::Unmounter#new when reading the actual /proc/mounts file ignores /, /proc, /sys, /dev [ 116s] [ 116s] rake aborted! [ 116s] Command failed with status (1): [rspec --color --format doc 'test/file_from...] [ 116s] [ 116s] Tasks: TOP => test:unit [ 116s] (See full trace by running task with --trace) [ 116s] error: Bad exit status from /var/tmp/rpm-tmp.wXJz3o (%check) [ 116s] [ 116s] [ 116s] RPM build errors: [ 116s] line 124: It's not recommended to have unversioned Obsoletes: Obsoletes: yast2-installation-devel-doc [ 116s] line 124: It's not recommended to have unversioned Obsoletes: Obsoletes: yast2-installation-devel-doc [ 116s] Bad exit status from /var/tmp/rpm-tmp.wXJz3o (%check) [ 116s] [ 116s] yast-jenkins failed "build yast2-installation.spec" at Thu Aug 26 13:22:24 UTC 2021. [ 116s] The buildroot was: /var/tmp/build-root/openSUSE_Factory-x86_64 rm -rf YaST:Head rake aborted! Command failed with status (1): [yes | osc -A 'https://api.opensuse.org/' b...] Tasks: TOP => osc:sr => osc:commit => osc:build (See full trace by running task with --trace) cleaning Result: PID 1697 exited with value 1 Scanning for a pull request... Found pull request #975 Adding comment ":x: Public Jenkins [job #179](https://ci.opensuse.org/job/yast-yast-installation-master/179/) failed" to pull request https://github.com/yast/yast-installation/pull/975 Sending Net::HTTP::Post request to https://api.github.com/repos/yast/yast-installation/issues/975/comments... OK Success Build step 'Execute shell' marked build as failure Not sending mail to unregistered user Stefan.Hundhammer@gmx.de