[yast-commit] [yast/yast-autoinstallation] 12ac7f: Split partition section page in two tabs
Branch: refs/heads/third-round Home: https://github.com/yast/yast-autoinstallation Commit: 12ac7f6b78b8ab7abbc2a4da1fb79728740460e8 https://github.com/yast/yast-autoinstallation/commit/12ac7f6b78b8ab7abbc2a4d... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: A src/lib/autoinstall/widgets/storage/partition_general_tab.rb M src/lib/autoinstall/widgets/storage/partition_page.rb A src/lib/autoinstall/widgets/storage/partition_usage_tab.rb A test/lib/widgets/storage/partition_general_tab_test.rb M test/lib/widgets/storage/partition_page_test.rb A test/lib/widgets/storage/partition_usage_tab_test.rb Log Message: ----------- Split partition section page in two tabs A partition section could have three groups of options * those that are always (create, size, etc) * others that depends on the drive section type (e.g., LVM name) * options related to the partition usage (filesystem, LVM group, etc) which have been organized in two tabs, one for the two first groups and other for the last one. That way, the interface will look less crowded. Commit: 358073cb1468536404f6d1b0f069f02bec7aba56 https://github.com/yast/yast-autoinstallation/commit/358073cb1468536404f6d1b... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/presenters/partition.rb M src/lib/autoinstall/presenters/section.rb M src/lib/autoinstall/widgets/storage/partition_usage_tab.rb M test/lib/presenters/partition_test.rb Log Message: ----------- Restrict attributes to reset in a partition section Each tab widget in the partition section will trigger its #store method to #update it. So, it's needed to limit the performed attributes cleanup in order to avoid missing options. In some way, this commit support the argument stated in the FIXME claiming that the attributes cleanup logic should be moved to a better place, likely in the Y2Storage section class. Commit: 48a8b6456b385eda5f753f3e863bb2115329a10a https://github.com/yast/yast-autoinstallation/commit/48a8b6456b385eda5f753f3... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/partition_general_tab.rb M src/lib/autoinstall/widgets/storage/partition_usage_tab.rb Log Message: ----------- Adapt #store method of partition section tabs Commit: 7e06bbbcd14316268814a0e6bff1c3b33bc1682f https://github.com/yast/yast-autoinstallation/commit/7e06bbbcd14316268814a0e... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/filesystem_attrs.rb Log Message: ----------- Fix filesytem attributes widget To include all its known values unconditionally Commit: 025f356f3141391f29db349a3b58fb498116285f https://github.com/yast/yast-autoinstallation/commit/025f356f3141391f29db349... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: A src/lib/autoinstall/widgets/storage/boolean_selector.rb A test/lib/widgets/storage/boolean_selector_test.rb A test/lib/widgets/storage/shared_examples.rb Log Message: ----------- Add base widget for boolean options Which allows to include the empty option Commit: cdc68e7bd62a35b1b7c8754be6e6770f93f9396d https://github.com/yast/yast-autoinstallation/commit/cdc68e7bd62a35b1b7c8754... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: A src/lib/autoinstall/widgets/storage/create.rb M src/lib/autoinstall/widgets/storage/partition_general_tab.rb A test/lib/widgets/storage/create_test.rb Log Message: ----------- Add the `create` option to partition section Commit: dcf769fc2b9fa111fdbb6ce50241a7e7f58de0fb https://github.com/yast/yast-autoinstallation/commit/dcf769fc2b9fa111fdbb6ce... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: A src/lib/autoinstall/widgets/storage/common_partition_attrs.rb M src/lib/autoinstall/widgets/storage/partition_general_tab.rb A test/lib/widgets/storage/common_partition_attrs_test.rb M test/lib/widgets/storage/partition_general_tab_test.rb Log Message: ----------- Move common partition attributes to their own widget Commit: 0701bb7524f51f41d876fb144b62b0b6b0b5b357 https://github.com/yast/yast-autoinstallation/commit/0701bb7524f51f41d876fb1... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/common_partition_attrs.rb A src/lib/autoinstall/widgets/storage/resize.rb M test/lib/widgets/storage/common_partition_attrs_test.rb A test/lib/widgets/storage/resize_test.rb Log Message: ----------- Add the `resize` option to partition section Commit: 35af05d9dd3bf7d7d720b77cdc3cf4d9278c4bf4 https://github.com/yast/yast-autoinstallation/commit/35af05d9dd3bf7d7d720b77... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/common_partition_attrs.rb A src/lib/autoinstall/widgets/storage/partition_nr.rb M test/lib/widgets/storage/common_partition_attrs_test.rb A test/lib/widgets/storage/partition_nr_test.rb Log Message: ----------- Add `partition_nr` option to partition sections Commit: 02c15cab3692597908748bc1842626bee235dd0d https://github.com/yast/yast-autoinstallation/commit/02c15cab3692597908748bc... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/common_partition_attrs.rb A src/lib/autoinstall/widgets/storage/uuid.rb M test/lib/widgets/storage/common_partition_attrs_test.rb A test/lib/widgets/storage/uuid_test.rb Log Message: ----------- Add `uuid` option to partition section Commit: 46037f2607eb678c41b27d38e1a2623b78e64cc5 https://github.com/yast/yast-autoinstallation/commit/46037f2607eb678c41b27d3... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/common_partition_attrs.rb M src/lib/autoinstall/widgets/storage/filesystem_attrs.rb A src/lib/autoinstall/widgets/storage/format.rb R src/lib/autoinstall/widgets/storage/format_filesystem.rb M test/lib/widgets/storage/common_partition_attrs_test.rb R test/lib/widgets/storage/format_filesystem_test.rb A test/lib/widgets/storage/format_test.rb Log Message: ----------- Move `format` option to the general partition tab Commit: 7ea4e7e323caef700ee14a50e0218acbc3f895a3 https://github.com/yast/yast-autoinstallation/commit/7ea4e7e323caef700ee14a5... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M test/lib/widgets/storage/partition_general_tab_test.rb Log Message: ----------- Remove broken test Commit: 2753a1feab7abf1c3b30d7aaeb83f48e301ded8f https://github.com/yast/yast-autoinstallation/commit/2753a1feab7abf1c3b30d7a... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/lvm_partition_attrs.rb Log Message: ----------- Adjust presentation of lv_name option Commit: f7b6a02917ef901b75f40cfbe4c508e688406258 https://github.com/yast/yast-autoinstallation/commit/f7b6a02917ef901b75f40cf... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/common_partition_attrs.rb A src/lib/autoinstall/widgets/storage/size.rb M test/lib/widgets/storage/shared_examples.rb M test/lib/widgets/storage/size_selector_test.rb A test/lib/widgets/storage/size_test.rb M test/lib/widgets/storage/vg_extent_size_test.rb Log Message: ----------- Make SizeSelector a base widget Commit: 6c3145ca37b4ed17c43f42a3f3a496113c3d298b https://github.com/yast/yast-autoinstallation/commit/6c3145ca37b4ed17c43f42a... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/lvm_page.rb A src/lib/autoinstall/widgets/storage/pesize.rb R src/lib/autoinstall/widgets/storage/vg_extent_size.rb M test/lib/widgets/storage/lvm_page_test.rb A test/lib/widgets/storage/pesize_test.rb R test/lib/widgets/storage/vg_extent_size_test.rb Log Message: ----------- Rename widget to manage the VG Physical Extent Size (pesize) Commit: 35c32abcf23ec3b605f1cc8471b8a06bf7d147a9 https://github.com/yast/yast-autoinstallation/commit/35c32abcf23ec3b605f1cc8... Author: David Díaz González <dgonzalez@suse.de> Date: 2020-05-12 (Tue, 12 May 2020) Changed paths: M src/lib/autoinstall/widgets/storage/lvm_partition_attrs.rb A src/lib/autoinstall/widgets/storage/pool.rb M test/lib/widgets/storage/lvm_partition_attrs_test.rb A test/lib/widgets/storage/pool_test.rb Log Message: ----------- Add `pool` option to LV partition attributes Compare: https://github.com/yast/yast-autoinstallation/compare/12ac7f6b78b8%5E...35c3...
participants (1)
-
David Díaz