[yast-commit] [ci_new_pac] JFYI yast2-users -> sle12

19 Feb 2014

Script 'mail_helper' called by ro
Hello packager,

This is just FYI.  Your package was checked in in distribution "sle12"
by autobuild-member: ro.

Here comes the log...

---------------------------%<------------------------------
Hi,

here is the log from ci_new_pac /mounts/work_src_done/SLE12/yast2-users -> sle12



## BNC# 864124 : "Build0062: Create New User Dialog doesn't check password against rules as if for root" (RESOLVED/FIXED)

Changes:
--------

--- /work/SRC/SUSE:SLE-12:GA/yast2-users/yast2-users.changes	2014-02-13 13:23:32.000000000 +0100
+++ /mounts/work_src_done/SLE12/yast2-users/yast2-users.changes	2014-02-19 09:54:22.000000000 +0100
@@ -1,0 +2,7 @@
+Tue Feb 18 11:14:05 CET 2014 - jsuchome@suse.cz
+
+- check root's password when it is same as one for 1st user
+  (bnc#864124)
+- 3.1.10
+
+-------------------------------------------------------------------

calling whatdependson for sle12-i586
Packages directly triggered for rebuild:
- yast2-auth-server
- yast2-ftp-server
- yast2-inetd
- yast2-mail
- yast2-samba-server
- yast2-sudo
- yast2-users
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/SUSE:SLE-12:GA/yast2-users (Old)
 and      /mounts/work_src_done/SLE12/yast2-users (BS:build ID:33148 MAIL:yast-commit@opensuse.org) (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-users", Maintainer is "yast-commit@opensuse.org"


Old:
----
  yast2-users-3.1.9.tar.bz2

New:
----
  yast2-users-3.1.10.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-users.spec ++++++
--- /var/tmp/diff_new_pack.kfOM9S/_old	2014-02-19 11:53:13.000000000 +0100
+++ /var/tmp/diff_new_pack.kfOM9S/_new	2014-02-19 11:53:13.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-users
-Version:        3.1.9
+Version:        3.1.10
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build

++++++ yast2-users-3.1.9.tar.bz2 -> yast2-users-3.1.10.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-users-3.1.9/package/yast2-users.changes new/yast2-users-3.1.10/package/yast2-users.changes
--- old/yast2-users-3.1.9/package/yast2-users.changes	2014-02-13 12:55:29.000000000 +0100
+++ new/yast2-users-3.1.10/package/yast2-users.changes	2014-02-19 09:50:20.000000000 +0100
@@ -1,4 +1,11 @@
 -------------------------------------------------------------------
+Tue Feb 18 11:14:05 CET 2014 - jsuchome@suse.cz
+
+- check root's password when it is same as one for 1st user
+  (bnc#864124)
+- 3.1.10
+
+-------------------------------------------------------------------
 Thu Feb 13 11:01:33 UTC 2014 - varkoly@suse.com
 
 - BNC#863612 YaST reports Cannot find client ldap/routines.rb 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-users-3.1.9/package/yast2-users.spec new/yast2-users-3.1.10/package/yast2-users.spec
--- old/yast2-users-3.1.9/package/yast2-users.spec	2014-02-13 12:55:29.000000000 +0100
+++ new/yast2-users-3.1.10/package/yast2-users.spec	2014-02-19 09:50:20.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-users
-Version:        3.1.9
+Version:        3.1.10
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-users-3.1.9/src/clients/inst_user_first.rb new/yast2-users-3.1.10/src/clients/inst_user_first.rb
--- old/yast2-users-3.1.9/src/clients/inst_user_first.rb	2014-02-13 12:55:29.000000000 +0100
+++ new/yast2-users-3.1.10/src/clients/inst_user_first.rb	2014-02-19 09:50:20.000000000 +0100
@@ -694,7 +694,7 @@
       end
 
       errors = UsersSimple.CheckPasswordUI(
-        { "uid" => username, "userPassword" => pw1, "type" => "local" }
+        { "uid" => username, "userPassword" => pw1, "type" => "local", "root" => @use_pw_for_root }
       )
 
       if @use_pw_for_root && @check_CA_constraints && pw1.size < MIN_PW_LEN_CA
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-users-3.1.9/src/modules/UsersSimple.pm new/yast2-users-3.1.10/src/modules/UsersSimple.pm
--- old/yast2-users-3.1.9/src/modules/UsersSimple.pm	2014-02-13 12:55:29.000000000 +0100
+++ new/yast2-users-3.1.10/src/modules/UsersSimple.pm	2014-02-19 09:50:20.000000000 +0100
@@ -626,26 +626,29 @@
 
 ##------------------------------------
 # Just some simple checks for password contens
-# @param username user or group name
+# @param usernames list of  user or group names
 # @param pw password
 # @param user/group
 # @return error message (password too simple) or empty string (OK)
 BEGIN { $TYPEINFO{CheckObscurity} = ["function", "string",
-    "string", "string", "string"];}
+    ["list", "string"],
+    "string", "string"];}
 sub CheckObscurity {
 
     my $self		= shift;
-    my $name		= shift;
+    my $names		= shift;
     my $pw 		= shift;
     my $what		= shift;
 
-    if ($pw =~ m/$name/) {
+    foreach my $name (@$names) {
+      if ($pw =~ m/$name/) {
 	if ($what eq "groups") {
 	    # popup question
 	    return __("You have used the group name as a part of the password.");
 	}
 	# popup question
         return __("You have used the username as a part of the password.");
+      }
     }
 
     # check for lowercase
@@ -790,19 +793,19 @@
 	}
     }
     
-    if (1) {#$self->ObscureChecksUsed ()) {
-	my $what	= "users";
-	$what		= "groups" if (! defined $data->{"uid"});
-	my $error	= $self->CheckObscurity ($name, $pw, $what);
-	push @ret, $error if $error;
-    }
+    my $what	= "users";
+    $what       = "groups" if (! defined $data->{"uid"});
+    my @names   = ( $name );
+    push @names, "root" if $data->{"root"} || 0;
+    my $error	= $self->CheckObscurity (\@names, $pw, $what);
+    push @ret, $error if $error;
 
     if (length ($pw) < $min_length) {
 	# popup error, %i is number
 	push @ret, sprintf (__("The password should have at least %i characters."), $min_length);
     }
     
-    my $error = $self->CheckPasswordMaxLength ($pw, $type);
+    $error = $self->CheckPasswordMaxLength ($pw, $type);
     push @ret, $error if $error;
 
     return \@ret;

continue with "q"...


Checked in at Wed Feb 19 11:54:23 CET 2014 by ro

Remember to have fun...

-- 
To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org
For additional commands, e-mail: yast-commit+help@opensuse.org

    

ro

tags

participants (1)