Author: fehr Date: Mon Apr 26 16:53:25 2010 New Revision: 61875 URL: http://svn.opensuse.org/viewcvs/yast?rev=61875&view=rev Log: - make alignment of created partitions configurable (optimal,cylinder) to be able to work around problems like in bnc #597723 Modified: trunk/storage/data/sysconfig.storage-yast2-storage trunk/storage/package/yast2-storage.changes trunk/storage/storage/src/include/ep-settings.ycp trunk/storage/storage/src/modules/Storage.ycp trunk/storage/storage/src/modules/StorageSettings.ycp Modified: trunk/storage/data/sysconfig.storage-yast2-storage URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/data/sysconfig.storage-yast2-storage?rev=61875&r1=61874&r2=61875&view=diff ============================================================================== --- trunk/storage/data/sysconfig.storage-yast2-storage (original) +++ trunk/storage/data/sysconfig.storage-yast2-storage Mon Apr 26 16:53:25 2010 @@ -20,3 +20,8 @@ # Separate individual values by single space HIDDEN_FIELDS="uuid mount_by used_by bios_id fc_wwpn fc_fcp_lun fc_port_id" +## Type: string +# Value for partition alignment +# Allowed values are: optimal cylinder +PARTITION_ALIGN="optimal" + Modified: trunk/storage/package/yast2-storage.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/package/yast2-storage.changes?rev=61875&r1=61874&r2=61875&view=diff ============================================================================== --- trunk/storage/package/yast2-storage.changes (original) +++ trunk/storage/package/yast2-storage.changes Mon Apr 26 16:53:25 2010 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Apr 26 16:51:56 CEST 2010 - fehr@suse.de + +- make alignment of created partitions configurable (optimal,cylinder) + to be able to work around problems like in bnc #597723 + +------------------------------------------------------------------- Mon Apr 19 12:17:36 CEST 2010 - aschnell@suse.de - added list of possible root filesystems to FileSystems module Modified: trunk/storage/storage/src/include/ep-settings.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/include/ep-settings.ycp?rev=61875&r1=61874&r2=61875&view=diff ============================================================================== --- trunk/storage/storage/src/include/ep-settings.ycp (original) +++ trunk/storage/storage/src/include/ep-settings.ycp Mon Apr 26 16:53:25 2010 @@ -71,6 +71,10 @@ return `item(`id(fs), FileSystems::GetName(fs, "Error")); }); + list<term> partalign_items = maplist(symbol pal, [ `align_optimal, `align_cylinder ], { + return `item(`id(pal), substring( sformat( "%1", pal ), 7 )); + }); + UI::ReplaceWidget(`tree_panel, Greasemonkey::Transform( @@ -88,6 +92,11 @@ _("Default File System"), filesystem_items, `id(Partitions::DefaultFs()))), + `Left(`ComboBoxSelected(`id(`part_align),`opt(`notify), + // combo box label + _("Alignment of Newly Created Partitions"), + partalign_items, + `id(Storage::GetPartitionAlignment()))), `VSpacing(1), `Left(`ComboBoxSelected(`id(`display_name), `opt(`notify), // combo box label @@ -175,9 +184,11 @@ symbol default_mount = (symbol) UI::QueryWidget(`id(`default_mountby), `Value); symbol default_fs = (symbol) UI::QueryWidget(`id(`default_fs), `Value); + symbol part_align = (symbol) UI::QueryWidget(`id(`part_align), `Value); Storage::SetDefaultMountBy( default_mount ); Partitions::SetDefaultFs( default_fs ); + Storage::SetPartitionAlignment( part_align ); StorageSettings::InvertVisibleFields(visible_fields, selected); } } Modified: trunk/storage/storage/src/modules/Storage.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/modules/Storage.ycp?rev=61875&r1=61874&r2=61875&view=diff ============================================================================== --- trunk/storage/storage/src/modules/Storage.ycp (original) +++ trunk/storage/storage/src/modules/Storage.ycp Mon Apr 26 16:53:25 2010 @@ -178,6 +178,14 @@ "right_asymmetric" : LibStorage::RIGHT_ASYMMETRIC(), "right_symmetric" : LibStorage::RIGHT_SYMMETRIC() ]; +map conv_partalign = + $[ "def_sym" : `align_optimal, + "def_int" : LibStorage::ALIGN_OPTIMAL(), + "m" : $[ LibStorage::ALIGN_OPTIMAL() : `align_optimal, + LibStorage::ALIGN_CYLINDER() : `align_cylinder + ] + ]; + map DiskMapVersion = $[]; map DiskMap = $[]; @@ -4269,6 +4277,21 @@ LibStorage::StorageInterface::setZeroNewPartitions( sint, val ); } +global void SetPartitionAlignment( symbol pal ) + { + y2milestone( "SetPartitionAlignment val:%1", pal ); + integer val = fromSymbol( conv_partalign, pal ); + LibStorage::StorageInterface::setPartitionAlignment( sint, val ); + } + +global symbol GetPartitionAlignment() + { + integer val = LibStorage::StorageInterface::getPartitionAlignment( sint ); + symbol pal = toSymbol( conv_partalign, val ); + y2milestone( "GetPartitionAlignment val:%1", pal ); + return( pal ); + } + /** * GetMountPoints() * collect mountpoint:device as map to get a sorted list Modified: trunk/storage/storage/src/modules/StorageSettings.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/modules/StorageSettings.ycp?rev=61875&r1=61874&r2=61875&view=diff ============================================================================== --- trunk/storage/storage/src/modules/StorageSettings.ycp (original) +++ trunk/storage/storage/src/modules/StorageSettings.ycp Mon Apr 26 16:53:25 2010 @@ -143,13 +143,13 @@ } - global string Summary() { list<string> tmp = [ _("Default Mount-by:") + " " + substring(tostring(Storage::GetDefaultMountBy()), 1), _("Default Filesystem:") + " " + substring(tostring(Partitions::DefaultFs()), 1), _("Show Storage Devices by:") + " " + substring(tostring(display_name), 1), + _("Partition Alignment:") + " " + substring(tostring(Storage::GetPartitionAlignment()), 7), _("Visible Information on Storage Devices:") + " " + HTML::List(visible_fields) ]; @@ -184,5 +184,20 @@ string tmp = substring(tostring(Partitions::DefaultFs()), 1); SCR::Write(.sysconfig.storage.DEFAULT_FS, tmp); } + + if (true) + { + string tmp = "optimal"; + switch( Storage::GetPartitionAlignment() ) + { + case `align_cylinder: + tmp = "cylinder"; + break; + default: + tmp = "optimal"; + break; + } + SCR::Write(.sysconfig.storage.PARTITION_ALIGN, tmp); + } } } -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org