Author: rpmcruz Date: Sat Dec 20 02:46:20 2008 New Revision: 54304 URL: http://svn.opensuse.org/viewcvs/yast?rev=54304&view=rev Log: * src/YGWidget.h, src/YGLayoutBox.cc, src/YGDialog.h, src/YGFrame.cc, src/YGDumbTab.cc, src/YGRadioButton.cc, src/YGWizard.cc: bug fix 460728: make sure to call parent class for add and removeChild methods. Affects YAlignment. * src/ygtkfieldentry.c: select entry besides focusing it. Modified: trunk/gtk/ChangeLog trunk/gtk/src/YGDialog.h trunk/gtk/src/YGDumbTab.cc trunk/gtk/src/YGFrame.cc trunk/gtk/src/YGInputField.cc trunk/gtk/src/YGLayout.cc trunk/gtk/src/YGRadioButton.cc trunk/gtk/src/YGWidget.h trunk/gtk/src/YGWizard.cc trunk/gtk/src/ygtkfieldentry.c Modified: trunk/gtk/ChangeLog URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/ChangeLog?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/ChangeLog (original) +++ trunk/gtk/ChangeLog Sat Dec 20 02:46:20 2008 @@ -1,3 +1,12 @@ +2008-12-20 Ricardo Cruz + + * src/YGWidget.h, src/YGLayoutBox.cc, src/YGDialog.h, src/YGFrame.cc, + src/YGDumbTab.cc, src/YGRadioButton.cc, src/YGWizard.cc: + bug fix 460728: make sure to call parent class for add and removeChild + methods. Affects YAlignment. + + * src/ygtkfieldentry.c: select entry besides focusing it. + 2008-12-18 Ricardo Cruz * src/YGSelectionModel.h/cc: bug fix 459313: we are using GTK model Modified: trunk/gtk/src/YGDialog.h URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGDialog.h?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGDialog.h (original) +++ trunk/gtk/src/YGDialog.h Sat Dec 20 02:46:20 2008 @@ -44,8 +44,8 @@ void setTitle (const std::string &title, bool sticky = false); void setIcon (const std::string &icon); - YGWIDGET_IMPL_CHILD_ADDED (m_containee) - YGWIDGET_IMPL_CHILD_REMOVED (m_containee) + YGWIDGET_IMPL_CHILD_ADDED (YDialog, m_containee) + YGWIDGET_IMPL_CHILD_REMOVED (YDialog, m_containee) }; #endif // YGDIALOG_H Modified: trunk/gtk/src/YGDumbTab.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGDumbTab.cc?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGDumbTab.cc (original) +++ trunk/gtk/src/YGDumbTab.cc Sat Dec 20 02:46:20 2008 @@ -153,8 +153,8 @@ } YGWIDGET_IMPL_COMMON - YGWIDGET_IMPL_CHILD_ADDED (m_containee) - YGWIDGET_IMPL_CHILD_REMOVED (m_containee) + YGWIDGET_IMPL_CHILD_ADDED (YDumbTab, m_containee) + YGWIDGET_IMPL_CHILD_REMOVED (YDumbTab, m_containee) }; YDumbTab *YGOptionalWidgetFactory::createDumbTab (YWidget *parent) Modified: trunk/gtk/src/YGFrame.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGFrame.cc?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGFrame.cc (original) +++ trunk/gtk/src/YGFrame.cc Sat Dec 20 02:46:20 2008 @@ -101,8 +101,8 @@ { return label(); } YGWIDGET_IMPL_COMMON - YGWIDGET_IMPL_CHILD_ADDED (m_containee) - YGWIDGET_IMPL_CHILD_REMOVED (m_containee) + YGWIDGET_IMPL_CHILD_ADDED (YFrame, m_containee) + YGWIDGET_IMPL_CHILD_REMOVED (YFrame, m_containee) }; @@ -173,8 +173,8 @@ } YGWIDGET_IMPL_COMMON - YGWIDGET_IMPL_CHILD_ADDED (m_containee) - YGWIDGET_IMPL_CHILD_REMOVED (m_containee) + YGWIDGET_IMPL_CHILD_ADDED (YCheckBoxFrame, m_containee) + YGWIDGET_IMPL_CHILD_REMOVED (YCheckBoxFrame, m_containee) private: static void toggled_cb (GtkWidget *widget, YGCheckBoxFrame *pThis) Modified: trunk/gtk/src/YGInputField.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGInputField.cc?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGInputField.cc (original) +++ trunk/gtk/src/YGInputField.cc Sat Dec 20 02:46:20 2008 @@ -8,7 +8,7 @@ #include "YGUtils.h" #include "ygtkfieldentry.h" -#include "YInputField.h" +#include class YGInputField : public YInputField, public YGLabeledWidget { Modified: trunk/gtk/src/YGLayout.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGLayout.cc?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGLayout.cc (original) +++ trunk/gtk/src/YGLayout.cc Sat Dec 20 02:46:20 2008 @@ -83,12 +83,12 @@ virtual void addChild (YWidget *ychild) { - YWidget::addChild (ychild); + YLayoutBox::addChild (ychild); doAddChild (ychild, getWidget()); if (primary() == YD_HORIZ) group.addWidget (ychild); } - YGWIDGET_IMPL_CHILD_REMOVED (getWidget()) + YGWIDGET_IMPL_CHILD_REMOVED (YLayoutBox, getWidget()) YGLAYOUT_PREFERRED_SIZE_IMPL (YLayoutBox) YGLAYOUT_SET_SIZE_IMPL (YLayoutBox) }; @@ -119,11 +119,11 @@ virtual void addChild (YWidget *ychild) { - YWidget::addChild (ychild); + YButtonBox::addChild (ychild); doAddChild (ychild, getWidget()); group.addWidget (ychild); } - YGWIDGET_IMPL_CHILD_REMOVED (getWidget()) + YGWIDGET_IMPL_CHILD_REMOVED (YButtonBox, getWidget()) YGLAYOUT_PREFERRED_SIZE_IMPL (YButtonBox) YGLAYOUT_SET_SIZE_IMPL (YButtonBox) }; @@ -158,8 +158,8 @@ g_object_unref (G_OBJECT (m_background_pixbuf)); } - YGWIDGET_IMPL_CHILD_ADDED (m_widget) - YGWIDGET_IMPL_CHILD_REMOVED (m_widget) + YGWIDGET_IMPL_CHILD_ADDED (YAlignment, m_widget) + YGWIDGET_IMPL_CHILD_REMOVED (YAlignment, m_widget) YGLAYOUT_PREFERRED_SIZE_IMPL (YAlignment) YGLAYOUT_SET_SIZE_IMPL (YAlignment) @@ -278,8 +278,8 @@ } YGWIDGET_IMPL_COMMON - YGWIDGET_IMPL_CHILD_ADDED (getWidget()) - YGWIDGET_IMPL_CHILD_REMOVED (getWidget()) + YGWIDGET_IMPL_CHILD_ADDED (YReplacePoint, getWidget()) + YGWIDGET_IMPL_CHILD_REMOVED (YReplacePoint, getWidget()) }; YReplacePoint *YGWidgetFactory::createReplacePoint (YWidget *parent) @@ -303,8 +303,8 @@ } YGWIDGET_IMPL_COMMON - YGWIDGET_IMPL_CHILD_ADDED (getWidget()) - YGWIDGET_IMPL_CHILD_REMOVED (getWidget()) + YGWIDGET_IMPL_CHILD_ADDED (YSquash, getWidget()) + YGWIDGET_IMPL_CHILD_REMOVED (YSquash, getWidget()) }; YSquash *YGWidgetFactory::createSquash (YWidget *parent, bool hsquash, bool vsquash) Modified: trunk/gtk/src/YGRadioButton.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGRadioButton.cc?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGRadioButton.cc (original) +++ trunk/gtk/src/YGRadioButton.cc Sat Dec 20 02:46:20 2008 @@ -128,8 +128,8 @@ } YGWIDGET_IMPL_COMMON - YGWIDGET_IMPL_CHILD_ADDED (m_widget) - YGWIDGET_IMPL_CHILD_REMOVED (m_widget) + YGWIDGET_IMPL_CHILD_ADDED (YRadioButtonGroup, m_widget) + YGWIDGET_IMPL_CHILD_REMOVED (YRadioButtonGroup, m_widget) }; YRadioButtonGroup *YGWidgetFactory::createRadioButtonGroup (YWidget *parent) Modified: trunk/gtk/src/YGWidget.h URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGWidget.h?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGWidget.h (original) +++ trunk/gtk/src/YGWidget.h Sat Dec 20 02:46:20 2008 @@ -116,14 +116,14 @@ } // for containers -#define YGWIDGET_IMPL_CHILD_ADDED(container) \ +#define YGWIDGET_IMPL_CHILD_ADDED(ParentClass, container) \ virtual void addChild (YWidget *ychild) { \ - YWidget::addChild (ychild); \ + ParentClass::addChild (ychild); \ doAddChild (ychild, container); \ } -#define YGWIDGET_IMPL_CHILD_REMOVED(container) \ +#define YGWIDGET_IMPL_CHILD_REMOVED(ParentClass, container) \ virtual void removeChild (YWidget *ychild) { \ - YWidget::removeChild (ychild); \ + ParentClass::removeChild (ychild); \ doRemoveChild (ychild, container); \ } Modified: trunk/gtk/src/YGWizard.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/YGWizard.cc?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/YGWizard.cc (original) +++ trunk/gtk/src/YGWizard.cc Sat Dec 20 02:46:20 2008 @@ -293,8 +293,8 @@ } YGWIDGET_IMPL_COMMON - YGWIDGET_IMPL_CHILD_ADDED (getWidget()) - YGWIDGET_IMPL_CHILD_REMOVED (getWidget()) + YGWIDGET_IMPL_CHILD_ADDED (YWizard, getWidget()) + YGWIDGET_IMPL_CHILD_REMOVED (YWizard, getWidget()) }; YWizard *YGOptionalWidgetFactory::createWizard (YWidget *parent, Modified: trunk/gtk/src/ygtkfieldentry.c URL: http://svn.opensuse.org/viewcvs/yast/trunk/gtk/src/ygtkfieldentry.c?rev=54304&r1=54303&r2=54304&view=diff ============================================================================== --- trunk/gtk/src/ygtkfieldentry.c (original) +++ trunk/gtk/src/ygtkfieldentry.c Sat Dec 20 02:46:20 2008 @@ -192,7 +192,9 @@ GList *children = gtk_container_get_children (GTK_CONTAINER (fields)); g_return_val_if_fail (children != NULL, FALSE); GtkWidget *widget = GTK_WIDGET (children->data); + g_list_free (children); + gtk_editable_select_region (GTK_EDITABLE (widget), 0, -1); gtk_widget_grab_focus (widget); return gtk_widget_is_focus (widget); } -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org