Author: kmachalkova Date: Wed May 28 15:28:46 2008 New Revision: 47915 URL: http://svn.opensuse.org/viewcvs/yast?rev=47915&view=rev Log: createPopups is evil: any dialogs will be created on demand only Modified: trunk/ncurses-pkg/src/NCPackageSelector.cc trunk/ncurses-pkg/src/NCPackageSelector.h Modified: trunk/ncurses-pkg/src/NCPackageSelector.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/ncurses-pkg/src/NCPackageSelector.cc?rev=47915&r1=47914&r2=47915&view=diff ============================================================================== --- trunk/ncurses-pkg/src/NCPackageSelector.cc (original) +++ trunk/ncurses-pkg/src/NCPackageSelector.cc Wed May 28 15:28:46 2008 @@ -124,8 +124,8 @@ testMode = true; saveState (); + diskspacePopup = new NCPkgDiskspace( testMode ); - // The creation of the popups is moved to createPopups() } @@ -140,19 +140,6 @@ // NCPackageSelectorPlugin::runPkgSelection } -/////////////////////////////////////////////////////////////////// -// -// createPopups() -// -// Create popups -// -// Don't create the popups any longer in constructur because the current dialog -// wouldn't be the PackageSelector dialog then but a PopupDialog and -// NCPackageSelectorPlugin::runPkgSelection wouldn't find the selector widget. -// Call NCPackageSelector::createPopups() instead after the PackageSelector dialog -// is created (see NCPackageSelectorStart::showDefaultList()). -// - bool NCPackageSelector::checkNow( bool *ok ) { bool ret = false; @@ -173,19 +160,6 @@ return ret; } -void NCPackageSelector::createPopups() -{ - // Patterns, Languages, Repositories, RPM Groups and Search filter are part of NCPkgFilterMain. - // NCPkgFilterPattern, NCPkgLocaleTable, NCPkgRepoTable, NCPkgFilterRPMGroups and - // NCPkgFilterSearch are created in NCPackageSelector::replaceFilter. - - // the dependency popup - - // the disk space popup - diskspacePopup = new NCPkgDiskspace( testMode ); -} - - ////////////////////////////////////////////////////////////////// // // detection whether the user has made any changes Modified: trunk/ncurses-pkg/src/NCPackageSelector.h URL: http://svn.opensuse.org/viewcvs/yast/trunk/ncurses-pkg/src/NCPackageSelector.h?rev=47915&r1=47914&r2=47915&view=diff ============================================================================== --- trunk/ncurses-pkg/src/NCPackageSelector.h (original) +++ trunk/ncurses-pkg/src/NCPackageSelector.h Wed May 28 15:28:46 2008 @@ -191,12 +191,6 @@ virtual ~NCPackageSelector(); /** - * Create all NCPkgPopus - * @return void - */ - void createPopups(); - - /** * Create layout for the PackageSelector * @param parent Parent is PackageSelectorStart * @param type The package table type -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org