Author: mfilka Date: Thu Feb 16 13:43:13 2012 New Revision: 67462 URL: http://svn.opensuse.org/viewcvs/yast?rev=67462&view=rev Log: Accepted comments from 2.21.3 review Modified: trunk/nfs-client/VERSION trunk/nfs-client/package/yast2-nfs-client.changes trunk/nfs-client/src/Nfs.ycp trunk/nfs-client/src/ui.ycp trunk/nfs-client/yast2-nfs-client.spec.in Modified: trunk/nfs-client/VERSION URL: http://svn.opensuse.org/viewcvs/yast/trunk/nfs-client/VERSION?rev=67462&r1=67461&r2=67462&view=diff ============================================================================== --- trunk/nfs-client/VERSION (original) +++ trunk/nfs-client/VERSION Thu Feb 16 13:43:13 2012 @@ -1 +1 @@ -2.21.3 +2.21.4 Modified: trunk/nfs-client/package/yast2-nfs-client.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/nfs-client/package/yast2-nfs-client.changes?rev=67462&r1=67461&r2=67462&view=diff ============================================================================== --- trunk/nfs-client/package/yast2-nfs-client.changes (original) +++ trunk/nfs-client/package/yast2-nfs-client.changes Thu Feb 16 13:43:13 2012 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Thu Feb 16 12:23:00 UTC 2012 - mfilka@suse.com + +- accepted comments from earlier review. +- some formatting +- 2.21.4 + +------------------------------------------------------------------- Wed Feb 8 12:00:10 UTC 2012 - mfilka@suse.com - Base server hostname combobox on existing values - bnc#547983 Modified: trunk/nfs-client/src/Nfs.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/nfs-client/src/Nfs.ycp?rev=67462&r1=67461&r2=67462&view=diff ============================================================================== --- trunk/nfs-client/src/Nfs.ycp (original) +++ trunk/nfs-client/src/Nfs.ycp Thu Feb 16 13:43:13 2012 @@ -137,22 +137,23 @@ } }); - //Backwards compatibility: with FaTE#302031, we support nfsv4 mounts - //thus we need to keep info on nfs version (v3 vs. v4) - //But older AY profiles might not contain this element - //so let's assume nfsv3 in that case (#395850) - if ( !haskey(s, "vfstype") ) - { - s["vfstype"] = "nfs"; - } else { - if (s["vfstype"]:"nfs" == "nfs4") - { - nfs4_enabled = true; - } - } + //Backwards compatibility: with FaTE#302031, we support nfsv4 mounts + //thus we need to keep info on nfs version (v3 vs. v4) + //But older AY profiles might not contain this element + //so let's assume nfsv3 in that case (#395850) + if ( !haskey(s, "vfstype") ) + { + s["vfstype"] = "nfs"; + } else { + if (s["vfstype"]:"nfs" == "nfs4") + { + nfs4_enabled = true; + } + } return s; }); + if (missing) { return false; @@ -305,10 +306,10 @@ Progress::set(progress_orig); portmapper = FindPortmapper(); - //There is neither rpcbind nor portmap + //There is neither rpcbind nor portmap if ( portmapper == "" ) { - //so let's install rpcbind (default since #423026) + //so let's install rpcbind (default since #423026) required_packages = add( required_packages, "rpcbind" ); portmapper = "rpcbind"; } Modified: trunk/nfs-client/src/ui.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/nfs-client/src/ui.ycp?rev=67462&r1=67461&r2=67462&view=diff ============================================================================== --- trunk/nfs-client/src/ui.ycp (original) +++ trunk/nfs-client/src/ui.ycp Thu Feb 16 13:43:13 2012 @@ -223,9 +223,7 @@ foreach( map nfs_entry, nfs_entries, { term couple = SpecToServPath( nfs_entry[ "spec"]:""); - string known_server = ""; - - known_server = couple[0]:""; + string known_server = couple[0]:""; if( !contains( servers, known_server)) servers = add( servers, known_server); Modified: trunk/nfs-client/yast2-nfs-client.spec.in URL: http://svn.opensuse.org/viewcvs/yast/trunk/nfs-client/yast2-nfs-client.spec.in?rev=67462&r1=67461&r2=67462&view=diff ============================================================================== --- trunk/nfs-client/yast2-nfs-client.spec.in (original) +++ trunk/nfs-client/yast2-nfs-client.spec.in Thu Feb 16 13:43:13 2012 @@ -21,6 +21,7 @@ BuildArch: noarch Summary: YaST2 - NFS Configuration +Url: http://en.opensuse.org/Portal:YaST %description The YaST2 component for configuration of NFS. NFS stands for network -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org