Branch: refs/heads/SLE-15-SP3 Home: https://github.com/yast/yast-users Commit: b3f0c512c4adfbae8d8e3855df4ab75e3442ced7 https://github.com/yast/yast-users/commit/b3f0c512c4adfbae8d8e3855df4ab75e34... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-19 (Mon, 19 Jul 2021) Changed paths: M test/lib/users/ssh_authorized_keyring_test.rb Log Message: ----------- Fix test description Commit: 06a7ebd4bacad91ab8d1fbb1e7509fb4899fc436 https://github.com/yast/yast-users/commit/06a7ebd4bacad91ab8d1fbb1e7509fb489... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-19 (Mon, 19 Jul 2021) Changed paths: M src/lib/users/ssh_authorized_keyring.rb M test/lib/users/ssh_authorized_keyring_test.rb Log Message: ----------- Do not write keys if they have not changed Because it make no sense to remove and recreate the authorized_keys file when nothing changed from the previous status. For example when keys were read from an existing file and there is nothing new to add. This avoids removing additional content (such as comments and blank lines) unnecessarily. See https://bugzilla.suse.com/show_bug.cgi?id=1188361 Commit: 184213302372e352a34c38f70cd7166c50108a31 https://github.com/yast/yast-users/commit/184213302372e352a34c38f70cd7166c50... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M src/lib/users/ssh_authorized_keyring.rb Log Message: ----------- Fix authorized_keys creation by setting right perms Commit: e34c0e111985ae7e3dd26c981fd958b60427f51a https://github.com/yast/yast-users/commit/e34c0e111985ae7e3dd26c981fd958b604... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M src/lib/users/ssh_authorized_keyring.rb M test/lib/users/ssh_authorized_keyring_test.rb Log Message: ----------- Do not add duplicated authorized keys Commit: 59f98c07e456e1c24199e37ce638942281ed31e2 https://github.com/yast/yast-users/commit/59f98c07e456e1c24199e37ce638942281... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M test/lib/users/ssh_authorized_keyring_test.rb Log Message: ----------- Add missing unit test Commit: defb8938d84c6830f59150644508b8a5fbdc7989 https://github.com/yast/yast-users/commit/defb8938d84c6830f59150644508b8a5fb... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M src/lib/users/ssh_authorized_keys_file.rb M test/lib/users/ssh_authorized_keys_file_test.rb Log Message: ----------- Do not log warnings for comments and empty lines When SSHAuthorizedKeysFile#keys hold keys read by SSHAuthorizedKeyring#read_keys, it could include comments or empty lines too, which are valid but ignored authorized_keys entries (see sshd(8) man page). Thus, it's useless to log warnings about them. Only not valid keys deserve an entry in the logs. Commit: be9d070c55b022c8bc938c0ac9c838f9b38254dc https://github.com/yast/yast-users/commit/be9d070c55b022c8bc938c0ac9c838f9b3... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M src/lib/users/ssh_authorized_keyring.rb Log Message: ----------- Revert "Fix authorized_keys creation by setting right perms" This reverts commit 184213302372e352a34c38f70cd7166c50108a31 because file permissions are being properly set through `umask` in SSHAuthorizedKeysFile#save method. See @imobachgs' comment at https://github.com/yast/yast-users/pull/320#discussion_r673158587 Commit: 2c375c8ad1694f891a59219cbaa4224be91e0358 https://github.com/yast/yast-users/commit/2c375c8ad1694f891a59219cbaa4224be9... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M src/lib/users/ssh_authorized_keyring.rb M test/lib/users/ssh_authorized_keyring_test.rb M test/lib/users/ssh_authorized_keys_file_test.rb Log Message: ----------- Fix unit test and remove leftover Commit: ee305025e94d0b7b2f12d5eb4e2b2173cff5ef0e https://github.com/yast/yast-users/commit/ee305025e94d0b7b2f12d5eb4e2b2173cf... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-20 (Tue, 20 Jul 2021) Changed paths: M package/yast2-users.changes M package/yast2-users.spec Log Message: ----------- Bump version and update changelog Commit: 9546e99c741e202cdf0aca72be2c2ac7c3a37186 https://github.com/yast/yast-users/commit/9546e99c741e202cdf0aca72be2c2ac7c3... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-21 (Wed, 21 Jul 2021) Changed paths: M src/modules/Users.pm Log Message: ----------- Adapt Users perl module for not overwriting authorized_keys file Commit: 0e361ce62ebaf4bac1e0bb6f44a19f9c8c93c8b2 https://github.com/yast/yast-users/commit/0e361ce62ebaf4bac1e0bb6f44a19f9c8c... Author: David Díaz <1691872+dgdavid@users.noreply.github.com> Date: 2021-07-21 (Wed, 21 Jul 2021) Changed paths: M package/yast2-users.changes M package/yast2-users.spec M src/lib/users/ssh_authorized_keyring.rb M src/lib/users/ssh_authorized_keys_file.rb M src/modules/Users.pm M test/lib/users/ssh_authorized_keyring_test.rb M test/lib/users/ssh_authorized_keys_file_test.rb Log Message: ----------- Merge pull request #320 from yast/bsc-1188361 Improve handling of authorized_keys Commit: d7be04d47a6c665006a64a594016e3d566621d60 https://github.com/yast/yast-users/commit/d7be04d47a6c665006a64a594016e3d566... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-21 (Wed, 21 Jul 2021) Changed paths: M package/yast2-users.changes M package/yast2-users.spec M src/lib/users/ssh_authorized_keyring.rb M src/lib/users/ssh_authorized_keys_file.rb M src/modules/Users.pm M test/lib/users/ssh_authorized_keyring_test.rb M test/lib/users/ssh_authorized_keys_file_test.rb Log Message: ----------- Merge remote-tracking branch 'origin/SLE-15-SP2' into SLE-15-SP3 Commit: c1c08895fc02b58db370905fdb1327311b849471 https://github.com/yast/yast-users/commit/c1c08895fc02b58db370905fdb1327311b... Author: David Díaz González <dgonzalez@suse.de> Date: 2021-07-21 (Wed, 21 Jul 2021) Changed paths: M test/lib/users/ssh_authorized_keyring_test.rb Log Message: ----------- Do not use .twice constraint in unit test The count constraint for include matcher was included in RSpec 3.10, reason why lower versions fails with a `undefined method `twice'. See https://github.com/rspec/rspec-expectations/commit/d7082704f0b248da83debfd3d... Commit: 2150f6c0f060a10cae10ad68f9788b3e821cef58 https://github.com/yast/yast-users/commit/2150f6c0f060a10cae10ad68f9788b3e82... Author: David Díaz <1691872+dgdavid@users.noreply.github.com> Date: 2021-07-21 (Wed, 21 Jul 2021) Changed paths: M package/yast2-users.changes M package/yast2-users.spec M src/lib/users/ssh_authorized_keyring.rb M src/lib/users/ssh_authorized_keys_file.rb M src/modules/Users.pm M test/lib/users/ssh_authorized_keyring_test.rb M test/lib/users/ssh_authorized_keys_file_test.rb Log Message: ----------- Merge pull request #321 from yast/bsc-1188361-sp3 [SLE-15-SP3] Improve handling of authorized_keys Compare: https://github.com/yast/yast-users/compare/a97d57dd38c7...2150f6c0f060