[yast-commit] [yast/yast-network] a9a26b: Fixed testsuite.
![](https://seccdn.libravatar.org/avatar/9181eb84f9c35729a3bad740fb7f9d93.jpg?s=120&d=mm&r=g)
Branch: refs/heads/master Home: https://github.com/yast/yast-network Commit: a9a26bbc8be5c739df5e94aa9edc7f8250419167 https://github.com/yast/yast-network/commit/a9a26bbc8be5c739df5e94aa9edc7f82... Author: Michal Filka <mfilka@suse.cz> Date: 2012-11-12 (Mon, 12 Nov 2012) Changed paths: M testsuite/tests/include.out M testsuite/tests/include.ycp M testsuite/tests/udev.out M testsuite/tests/udev.ycp Log Message: ----------- Fixed testsuite. Failed due to missing /etc/sysconfig/console at OBS' build host. Commit: 5f0f4f7ef93f252bd5591a280f71ee8c19c59ba1 https://github.com/yast/yast-network/commit/5f0f4f7ef93f252bd5591a280f71ee8c... Author: Michal Filka <mfilka@suse.cz> Date: 2012-11-12 (Mon, 12 Nov 2012) Changed paths: M package/yast2-network.changes Log Message: ----------- Updated changelog. Commit: 42028be517538261cce0cf84eb8f18806f55018d https://github.com/yast/yast-network/commit/42028be517538261cce0cf84eb8f1880... Author: Martin Vidner <martin.github@vidner.net> Date: 2012-11-12 (Mon, 12 Nov 2012) Changed paths: M package/yast2-network.changes M testsuite/tests/include.out M testsuite/tests/include.ycp M testsuite/tests/udev.out M testsuite/tests/udev.ycp Log Message: ----------- Merge pull request #32 from mchf/master Why this? Recall that this test suite works by mocking and watching the SCR layer. Even if we don't mock anything, errors are recorded, like if a sysconfig file (console here) is missing. The tested code imports several modules, and some of them have *constructors*. That's where we read sysconfig/console even if we don't care. A better way to fix this is to remove the constructors and replace the public variables they initialize by a lazy functional API. In this case it means touching yast2.rpm (Encoding.ycp) and yast2-country.rpm (using Encoding::console). Compare: https://github.com/yast/yast-network/compare/60062452c3d9...42028be51753
participants (1)
-
GitHub