Branch: refs/heads/new_rubocop
Home: https://github.com/yast/yast-yast2
Commit: 763f8d5c6603ae4b1d648e8407a6437ce238828f
https://github.com/yast/yast-yast2/commit/763f8d5c6603ae4b1d648e8407a6437ce2...
Author: Josef Reidinger
Date: 2022-01-06 (Thu, 06 Jan 2022)
Changed paths:
M .rubocop.yml
Log Message:
-----------
adapt rubocop config
Commit: ded6ca4ca6733ae83559e3f88be3323362d98ab3
https://github.com/yast/yast-yast2/commit/ded6ca4ca6733ae83559e3f88be3323362...
Author: Josef Reidinger
Date: 2022-01-06 (Thu, 06 Jan 2022)
Changed paths:
M doc/examples/ask_resize_windows_partition.rb
M doc/examples/popups2.rb
M library/commandline/src/clients/other_tools_warning.rb
M library/commandline/src/modules/CommandLine.rb
M library/commandline/test/test_helper.rb
M library/control/src/modules/InstError.rb
M library/control/src/modules/InstExtensionImage.rb
M library/control/src/modules/ProductControl.rb
M library/control/src/modules/WorkflowManager.rb
M library/control/test/test_helper.rb
M library/control/test/workflow_manager_test.rb
M library/cwm/examples/object_api_tree.rb
M library/cwm/src/lib/cwm/abstract_widget.rb
M library/cwm/src/lib/cwm/pager.rb
M library/cwm/src/lib/cwm/replace_point.rb
M library/cwm/src/lib/cwm/ui_state.rb
M library/cwm/src/modules/CWM.rb
M library/cwm/src/modules/CWMServiceStart.rb
M library/cwm/src/modules/CWMTable.rb
M library/cwm/src/modules/CWMTsigKeys.rb
M library/cwm/src/modules/DialogTree.rb
M library/cwm/src/modules/TablePopup.rb
M library/cwm/src/modules/WizardHW.rb
M library/cwm/test/dialog_test.rb
M library/cwm/test/pager_test.rb
M library/cwm/test/test_helper.rb
M library/cwm/test/tree_pager_test.rb
M library/desktop/src/clients/menu.rb
M library/desktop/src/modules/Desktop.rb
M library/desktop/test/test_helper.rb
M library/general/example/popup_serie.rb
M library/general/src/lib/cfa/conflict_report.rb
M library/general/src/lib/cfa/sysctl_config.rb
M library/general/src/lib/installation/autoinst_issues/missing_value.rb
M library/general/src/lib/ui/greasemonkey.rb
M library/general/src/lib/y2issues/invalid_value.rb
M library/general/src/lib/yast2/popup.rb
M library/general/src/modules/Distro.rb
M library/general/src/modules/DontShowAgain.rb
M library/general/src/modules/FileUtils.rb
M library/general/src/modules/Hooks.rb
M library/general/src/modules/Icon.rb
M library/general/src/modules/Linuxrc.rb
M library/general/src/modules/Message.rb
M library/general/src/modules/Misc.rb
M library/general/src/modules/OSRelease.rb
M library/general/src/modules/Popup.rb
M library/general/src/modules/Report.rb
M library/general/src/modules/Summary.rb
M library/general/src/modules/ValueBrowser.rb
M library/general/test/asciifile_test.rb
M library/general/test/autoinst_issues/invalid_value_test.rb
M library/general/test/autoinst_issues/issues_presenter_test.rb
M library/general/test/autoinst_issues/missing_value_test.rb
M library/general/test/test_helper.rb
M library/general/test/ui/greasemonkey_test.rb
M library/general/test/ui/text_helpers_test.rb
M library/general/test/ui/ui_extension_checker_test.rb
M library/general/test/yast2/secret_attributes_test.rb
M library/gpg/src/modules/GPG.rb
M library/gpg/src/modules/GPGWidgets.rb
M library/gpg/test/test_helper.rb
M library/log/src/modules/LogView.rb
M library/network/src/lib/network/susefirewall.rb
M library/network/src/lib/network/susefirewall2.rb
M library/network/src/lib/network/susefirewall2services.rb
M library/network/src/lib/network/susefirewalld.rb
M library/network/src/modules/CWMFirewallInterfaces.rb
M library/network/src/modules/Internet.rb
M library/network/src/modules/NetworkInterfaces.rb
M library/network/src/modules/NetworkPopup.rb
M library/network/src/modules/NetworkService.rb
M library/network/src/modules/PortAliases.rb
M library/network/src/modules/PortRanges.rb
M library/network/src/modules/SuSEFirewallProposal.rb
M library/network/src/modules/firewalld_wrapper.rb
M library/network/test/test_helper.rb
M library/packages/src/lib/packages/file_conflict_callbacks.rb
M library/packages/src/lib/y2packager/license.rb
M library/packages/src/lib/y2packager/licenses_fetchers/base.rb
M library/packages/src/lib/y2packager/licenses_fetchers/rpm.rb
M library/packages/src/lib/y2packager/licenses_fetchers/tarball.rb
M library/packages/src/lib/y2packager/product.rb
M library/packages/src/lib/y2packager/release_notes_fetchers/rpm.rb
M library/packages/src/lib/y2packager/release_notes_fetchers/url.rb
M library/packages/src/lib/y2packager/repository.rb
M library/packages/src/lib/y2packager/resolvable.rb
M library/packages/src/modules/PackageCallbacks.rb
M library/packages/src/modules/PackageKit.rb
M library/packages/src/modules/PackageLock.rb
M library/packages/src/modules/PackageSystem.rb
M library/packages/src/modules/PackagesUI.rb
M library/packages/src/modules/SignatureCheckCallbacks.rb
M library/packages/src/modules/SignatureCheckDialogs.rb
M library/packages/src/modules/SlideShow.rb
M library/packages/src/modules/Slides.rb
M library/packages/test/dummy_callbacks_test.rb
M library/packages/test/product_factory.rb
M library/packages/test/test_helper.rb
M library/packages/test/y2packager/licenses_fetchers/rpm_test.rb
M library/packages/test/y2packager/product_reader_test.rb
M library/packages/test/y2packager/product_test.rb
M library/packages/test/y2packager/release_notes_fetchers/url_test.rb
M library/sequencer/src/lib/ui/sequence.rb
M library/sequencer/src/modules/Sequencer.rb
M library/sequencer/test/test_helper.rb
M library/system/src/lib/yast2/clients/view_anymsg.rb
M library/system/src/lib/yast2/fs_snapshot.rb
M library/system/src/modules/FileChanges.rb
M library/system/src/modules/HwStatus.rb
M library/system/src/modules/Initrd.rb
M library/system/src/modules/Kernel.rb
M library/system/test/fs_snapshot_test.rb
M library/system/test/test_helper.rb
M library/systemd/src/lib/yast2/service_widget.rb
M library/systemd/src/modules/Service.rb
M library/systemd/test/test_helper.rb
M library/systemd/test/yast2/compound_service_test.rb
M library/types/src/modules/Hostname.rb
M library/types/src/modules/IP.rb
M library/types/src/modules/Netmask.rb
M library/types/src/modules/Punycode.rb
M library/types/src/modules/String.rb
M library/types/src/modules/URL.rb
M library/types/test/test_helper.rb
M library/types/test/url_test.rb
M library/wizard/src/modules/Confirm.rb
M library/wizard/src/modules/HTML.rb
M library/wizard/src/modules/Progress.rb
M library/wizard/src/modules/Wizard.rb
M library/wizard/test/test_helper.rb
M library/xml/src/modules/XML.rb
M library/xml/test/test_helper.rb
M library/xml/test/xml_test.rb
Log Message:
-----------
safe auto corrections
Commit: 826cb04a4b813abe37447a4b53ca4074b248dc7a
https://github.com/yast/yast-yast2/commit/826cb04a4b813abe37447a4b53ca4074b2...
Author: Josef Reidinger
Date: 2022-01-07 (Fri, 07 Jan 2022)
Changed paths:
M library/commandline/src/modules/CommandLine.rb
M library/control/src/modules/Installation.rb
M library/control/src/modules/ProductControl.rb
M library/cwm/src/modules/CWM.rb
M library/cwm/src/modules/CWMServiceStart.rb
M library/cwm/src/modules/CWMTsigKeys.rb
M library/cwm/src/modules/TablePopup.rb
M library/general/src/modules/Mode.rb
M library/general/src/modules/OSRelease.rb
M library/general/src/modules/Popup.rb
M library/general/src/modules/Stage.rb
M library/general/test/autoinst_issues/issues_presenter_test.rb
M library/general/test/directory_test.rb
M library/general/test/linuxrc_test.rb
M library/log/examples/logviewcore1.rb
M library/log/examples/logviewcore2.rb
M library/log/examples/logviewcore3.rb
M library/network/src/lib/network/firewalld.rb
M library/network/src/lib/network/susefirewall2.rb
M library/network/src/lib/network/susefirewalld.rb
M library/network/src/lib/network/susefirewalldservices.rb
M library/network/src/lib/network/susefirewallservices.rb
M library/network/src/lib/y2firewall/firewalld/api/services.rb
M library/network/src/lib/y2firewall/firewalld/api/zones.rb
M library/network/src/lib/y2firewall/firewalld/zone_reader.rb
M library/network/src/modules/NetworkInterfaces.rb
M library/network/test/y2firewall/firewalld/api/services_test.rb
M library/network/test/y2firewall/firewalld/api/zones_test.rb
M library/packages/src/modules/PackageCallbacks.rb
M library/packages/src/modules/PackagesUI.rb
M library/packages/src/modules/SignatureCheckDialogs.rb
M library/system/src/lib/yast2/ui_plugin_info.rb
M library/system/src/modules/Hotplug.rb
M library/system/src/modules/Kernel.rb
M library/system/test/shared_lib_info_test.rb
M library/systemd/src/lib/yast2/compound_service.rb
M library/types/src/modules/RichText.rb
M library/types/src/modules/String.rb
M library/wizard/src/modules/Progress.rb
M library/wizard/src/modules/Wizard.rb
Log Message:
-----------
unsafe auto corrections ( manually reviewed )
Commit: d6c93b6f09426182d0fb5fad5339bc9e2bd777b7
https://github.com/yast/yast-yast2/commit/d6c93b6f09426182d0fb5fad5339bc9e2b...
Author: Josef Reidinger
Date: 2022-01-07 (Fri, 07 Jan 2022)
Changed paths:
M library/control/src/modules/ProductControl.rb
M library/cwm/src/modules/CWM.rb
M library/cwm/src/modules/TablePopup.rb
M library/network/src/modules/NetworkInterfaces.rb
M library/network/src/modules/PortRanges.rb
M library/types/src/modules/RichText.rb
M library/xml/src/modules/XML.rb
Log Message:
-----------
fix redundant branch cop. It is a bit buggy for workflow encoded in elsifs
Commit: 2c579c986869f5e47168d4371ac3b1a272e18ded
https://github.com/yast/yast-yast2/commit/2c579c986869f5e47168d4371ac3b1a272...
Author: Josef Reidinger
Date: 2022-01-07 (Fri, 07 Jan 2022)
Changed paths:
M library/cwm/examples/date_time.rb
M library/cwm/examples/object_api.rb
M library/cwm/examples/object_api_all_events.rb
M library/cwm/examples/object_api_enabling.rb
M library/cwm/examples/object_api_nested.rb
M library/cwm/examples/object_api_tabs.rb
M library/cwm/examples/object_api_tree.rb
M library/cwm/examples/popup.rb
M library/cwm/examples/replace_point_example.rb
M library/cwm/examples/replace_point_with_nested_custom.rb
M library/cwm/examples/replace_point_with_nested_replace_point.rb
M library/cwm/examples/service_widget.rb
M library/cwm/src/lib/cwm/common_widgets.rb
M library/cwm/src/lib/cwm/dialog.rb
M library/cwm/src/lib/cwm/pager.rb
M library/cwm/src/lib/cwm/replace_point.rb
M library/cwm/src/lib/cwm/service_widget.rb
M library/cwm/src/lib/cwm/wrapper_widget.rb
M library/cwm/test/abstract_widget_test.rb
M library/cwm/test/custom_widget_test.rb
M library/cwm/test/dialog_test.rb
M library/cwm/test/pager_test.rb
M library/cwm/test/tree_pager_test.rb
M library/general/src/lib/installation/autoinst_issues/invalid_value.rb
M library/general/src/lib/installation/autoinst_issues/missing_value.rb
M library/general/src/lib/ui/widgets.rb
M library/general/src/lib/yast2/equatable.rb
M library/general/src/modules/Hooks.rb
M library/general/src/modules/OSRelease.rb
M library/general/test/autoinst_issues/issues_presenter_test.rb
M library/general/test/autoinst_issues/list_test.rb
M library/general/test/installation/autoinst_profile/section_with_attributes_test.rb
M library/network/src/lib/network/susefirewall.rb
M library/network/src/lib/network/susefirewalld.rb
M library/network/src/lib/network/susefirewalldservices.rb
M library/network/src/lib/network/susefirewallservices.rb
M library/network/src/modules/firewalld_wrapper.rb
M library/packages/src/lib/y2packager/zypp_url.rb
M library/packages/src/modules/PackageCallbacks.rb
M library/systemd/src/modules/Service.rb
M library/systemd/src/modules/ServicesProposal.rb
M library/wizard/test/manual/progress_demo.rb
Log Message:
-----------
fix calling super in important methods
Commit: ab0426127eaff5c0023c22ceaab2755827d0e83a
https://github.com/yast/yast-yast2/commit/ab0426127eaff5c0023c22ceaab2755827...
Author: Josef Reidinger
Date: 2022-01-07 (Fri, 07 Jan 2022)
Changed paths:
M library/general/src/modules/Arch.rb
M library/system/src/lib/yast2/fs_snapshot.rb
Log Message:
-----------
fix method naming convention cop
Commit: 953c3a6ca3cd05da387a22847c72094051271680
https://github.com/yast/yast-yast2/commit/953c3a6ca3cd05da387a22847c72094051...
Author: Josef Reidinger
Date: 2022-01-07 (Fri, 07 Jan 2022)
Changed paths:
M library/packages/src/modules/PackageCallbacks.rb
Log Message:
-----------
fix document dynamic eval cop
Commit: 745a207c44f8790b3eb72a2d8c2fd93b5714513e
https://github.com/yast/yast-yast2/commit/745a207c44f8790b3eb72a2d8c2fd93b57...
Author: Josef Reidinger
Date: 2022-01-08 (Sat, 08 Jan 2022)
Changed paths:
M library/control/test/InstExtensionImage_test.rb
M library/cwm/src/lib/cwm/rspec.rb
M library/cwm/test/tree_test.rb
M library/general/test/popup_test.rb
M library/general/test/ui/installation/layout_test.rb
M library/packages/test/file_conflict_callbacks_test.rb
Log Message:
-----------
fix empty block cop
Commit: 71d7b4096701e0df10ea9758bc09f021a6e58626
https://github.com/yast/yast-yast2/commit/71d7b4096701e0df10ea9758bc09f021a6...
Author: Josef Reidinger
Date: 2022-01-08 (Sat, 08 Jan 2022)
Changed paths:
M library/network/src/lib/network/susefirewalld.rb
Log Message:
-----------
fix Style/CombinableLoops cop
Commit: 6866413d9fdfc94619d8236b9e311b0da158a56e
https://github.com/yast/yast-yast2/commit/6866413d9fdfc94619d8236b9e311b0da1...
Author: Josef Reidinger
Date: 2022-01-08 (Sat, 08 Jan 2022)
Changed paths:
M library/network/src/modules/PortRanges.rb
Log Message:
-----------
fix bug found by Lint/DuplicateElsifCondition as condition was wrong (I spend 5 minutes to reading and understanding this hell code)
Commit: 687fb667135be82e3bb101e537fad4b012f8bd78
https://github.com/yast/yast-yast2/commit/687fb667135be82e3bb101e537fad4b012...
Author: Josef Reidinger
Date: 2022-01-08 (Sat, 08 Jan 2022)
Changed paths:
M .rubocop.yml
Log Message:
-----------
disable cop for optional boolean parameters to avoid API changes
Compare: https://github.com/yast/yast-yast2/compare/763f8d5c6603%5E...687fb667135b