Author: jsrain Date: Mon Nov 2 11:58:59 2009 New Revision: 59267 URL: http://svn.opensuse.org/viewcvs/yast?rev=59267&view=rev Log: warn in installation proposal if not formatting /home partition and using remote authentication (fate#306325) Modified: trunk/storage/package/yast2-storage.changes trunk/storage/storage/src/proposal/partitions_proposal.ycp Modified: trunk/storage/package/yast2-storage.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/package/yast2-storage.changes?rev=59267&r1=59266&r2=59267&view=diff ============================================================================== --- trunk/storage/package/yast2-storage.changes (original) +++ trunk/storage/package/yast2-storage.changes Mon Nov 2 11:58:59 2009 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Nov 2 11:25:05 CET 2009 - jsrain@suse.cz + +- warn in installation proposal if not formatting /home partition + and using remote authentication (fate#306325) + +------------------------------------------------------------------- Thu Oct 29 11:59:20 CET 2009 - aschnell@suse.de - provide usedby information as list in target-map (bnc #472812) Modified: trunk/storage/storage/src/proposal/partitions_proposal.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/proposal/partitions_proposal.ycp?rev=59267&r1=59266&r2=59267&view=diff ============================================================================== --- trunk/storage/storage/src/proposal/partitions_proposal.ycp (original) +++ trunk/storage/storage/src/proposal/partitions_proposal.ycp Mon Nov 2 11:58:59 2009 @@ -25,6 +25,25 @@ y2milestone( "func:%1 param:%2", func, param ); + // check if /home partition keeps unformatted in order to warn for + // possible incorrectly set file ownership (fate#306325) + boolean home_not_formatted() { + map tm = Storage::GetTargetMap(); + boolean ret = false; + foreach (string disk, map info, tm, { + list<map> partitions = info["partitions"]:[]; + foreach (map p, partitions, { + if (p["mount"]:"" == "/home" && ! p["format"]:false) + { + y2milestone ("The /home partition will not be formatted."); + ret = true; + break; + } + }); + }); + return ret; + } + if( func == "MakeProposal" && Mode::autoinst() ) { ret["preformatted_proposal"] = Storage::ChangeText(); @@ -65,6 +84,17 @@ !Storage::GetPartProposalActive() ) { ret["preformatted_proposal"] = Storage::ChangeText(); + // detect non-formated /home together with remote authentication - Fate#306325 + if (home_not_formatted()) + { + import "UsersSimple"; + if (UsersSimple::AfterAuth() != "users") + { + ret["warning"] = _("The /home partition will not be formatted. After installation, +ensure that the permissions to home directories are set properly."); + ret["warning_level"] = `warning; + } + } } else { -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org