Branch: refs/heads/rubocop_SLE12_attempt2 Home: https://github.com/yast/yast-yast2 Commit: 293968f7a5fcaa2a4706c9f4998cec6473273168 https://github.com/yast/yast-yast2/commit/293968f7a5fcaa2a4706c9f4998cec6473... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml Log Message: ----------- explain why not to fix double negation Commit: 536c2435393759e4e01a80d243dce1019593f7fc https://github.com/yast/yast-yast2/commit/536c2435393759e4e01a80d243dce10195... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/commandline/src/clients/other_tools_warning.rb M library/general/src/modules/Arch.rb M library/network/src/modules/NetworkInterfaces.rb M library/runlevel/src/modules/ServicesProposal.rb M library/system/src/clients/view_anymsg.rb M library/system/src/modules/Kernel.rb M library/types/src/modules/IP.rb Log Message: ----------- fix conditionals and guard causule Commit: 4a9a454d212811f90ea4166ab2d6e2bd8be6c3ef https://github.com/yast/yast-yast2/commit/4a9a454d212811f90ea4166ab2d6e2bd8b... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M Rakefile M library/commandline/src/clients/other_tools_warning.rb M library/control/src/modules/AutoinstData.rb M library/control/src/modules/InstError.rb M library/control/src/modules/InstExtensionImage.rb M library/desktop/src/clients/menu.rb M library/desktop/src/modules/Desktop.rb M library/general/src/modules/ConfigHistory.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/network/src/modules/SuSEFirewallExpertRules.rb M library/network/testsuite/tests/NetworkInterfaces2.rb M library/network/testsuite/tests/NetworkInterfaces4.rb M library/network/testsuite/tests/NetworkInterfaces5-Type.rb M library/packages/src/modules/Package.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageSystem.rb M library/packages/src/modules/SlideShow.rb M library/sequencer/testsuite/tests/WS_next.rb M library/types/src/modules/Address.rb M library/types/src/modules/Hostname.rb M library/types/src/modules/IP.rb M library/types/src/modules/RichText.rb M library/types/src/modules/String.rb M library/types/src/modules/TypeRepository.rb M library/types/test/ip_test.rb M library/types/testsuite/tests/FindMountPoint.rb M library/wizard/src/modules/Progress.rb M library/wizard/src/modules/Wizard.rb Log Message: ----------- fix leading space in comments Commit: cbf452fb64a072043cf8c40fcfb71239813bc0c7 https://github.com/yast/yast-yast2/commit/cbf452fb64a072043cf8c40fcfb7123981... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/general/src/modules/Hooks.rb M library/network/src/modules/SuSEFirewallServices.rb M library/packages/src/modules/SlideShow.rb M library/packages/test/slide_show_test.rb M library/runlevel/src/modules/Service.rb M library/runlevel/test/service_test.rb M library/system/test/kernel_test.rb M library/systemd/src/lib/yast2/systemctl.rb M library/systemd/src/lib/yast2/systemd_unit.rb M library/systemd/src/modules/systemd_service.rb M library/systemd/src/modules/systemd_socket.rb M library/systemd/src/modules/systemd_target.rb M library/systemd/test/systemd_unit_test.rb M library/systemd/test/test_helper.rb Log Message: ----------- fix parentheses Commit: 563bde05056c4b90ac002cdec97c06a3e96b7a76 https://github.com/yast/yast-yast2/commit/563bde05056c4b90ac002cdec97c06a3e9... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/control/src/modules/ProductFeatures.rb M library/gpg/src/modules/GPG.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/SuSEFirewallProposal.rb M library/network/testsuite/tests/NetworkInterfaces.rb M library/network/testsuite/tests/NetworkInterfaces3.rb M library/network/testsuite/tests/PortAliases.rb Log Message: ----------- fix block alignment Commit: 0b409f973f759bf65ee683469892a80804924fd6 https://github.com/yast/yast-yast2/commit/0b409f973f759bf65ee683469892a80804... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/control/src/modules/WorkflowManager.rb M library/cwm/src/modules/CWM.rb M library/system/src/modules/Initrd.rb M library/types/src/modules/String.rb M library/types/src/modules/URL.rb Log Message: ----------- fix multiline operation indentation Commit: 3e8f58f463759594c4b5d47d151dc716468db21d https://github.com/yast/yast-yast2/commit/3e8f58f463759594c4b5d47d151dc71646... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/InstError.rb M library/control/src/modules/ProductControl.rb M library/cwm/src/modules/CWMServiceStart.rb M library/cwm/src/modules/CWMTable.rb M library/cwm/src/modules/TablePopup.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Report.rb M library/general/src/modules/Syslog.rb M library/gpg/src/modules/GPG.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/network/src/modules/NetworkService.rb M library/network/src/modules/SuSEFirewallExpertRules.rb M library/network/src/modules/SuSEFirewallProposal.rb M library/packages/src/include/packages/common.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageLock.rb M library/packages/src/modules/PackageSystem.rb M library/packages/src/modules/PackagesUI.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/system/src/modules/Kernel.rb M library/types/src/modules/Hostname.rb M library/types/src/modules/String.rb M library/types/src/modules/URL.rb M library/wizard/src/modules/Progress.rb M library/wizard/src/modules/Wizard.rb Log Message: ----------- do not use multiline ternary operator Commit: fa2ca82b35481d0e6a47c7c7e074ec186005c8fc https://github.com/yast/yast-yast2/commit/fa2ca82b35481d0e6a47c7c7e074ec1860... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/commandline/src/modules/CommandLine.rb M library/cwm/src/modules/TablePopup.rb M library/general/src/modules/Misc.rb Log Message: ----------- do not use negated while Commit: ee3ab32427da34aa48d59302bba3a9c7925448f4 https://github.com/yast/yast-yast2/commit/ee3ab32427da34aa48d59302bba3a9c792... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/types/src/modules/Netmask.rb Log Message: ----------- do not use nested ternary operator Commit: 9308c86534dc989b454d73775fcc33ef0d14d1cd https://github.com/yast/yast-yast2/commit/9308c86534dc989b454d73775fcc33ef0d... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/cwm/src/modules/DialogTree.rb M library/cwm/src/modules/TablePopup.rb M library/general/src/modules/Popup.rb M library/packages/src/modules/PackagesUI.rb M library/packages/src/modules/Product.rb M library/system/src/lib/yast2/hw_detection.rb Log Message: ----------- use next to decrease nesting in loops Commit: e0913ac2e3c508a7311bb9531bb83433352fcac4 https://github.com/yast/yast-yast2/commit/e0913ac2e3c508a7311bb9531bb8343335... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/commandline/src/modules/CommandLine.rb M library/control/src/modules/InstError.rb M library/control/src/modules/InstExtensionImage.rb M library/control/src/modules/Installation.rb M library/control/src/modules/ProductControl.rb M library/control/src/modules/ProductFeatures.rb M library/control/src/modules/ProductProfile.rb M library/control/src/modules/WorkflowManager.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMTab.rb M library/cwm/src/modules/CWMTable.rb M library/cwm/src/modules/CWMTsigKeys.rb M library/cwm/src/modules/DialogTree.rb M library/cwm/src/modules/TablePopup.rb M library/cwm/src/modules/WizardHW.rb M library/cwm/testsuite/tests/testfunc.rb M library/desktop/src/modules/Desktop.rb M library/general/src/modules/Arch.rb M library/general/src/modules/AsciiFile.rb M library/general/src/modules/ConfigHistory.rb M library/general/src/modules/Directory.rb M library/general/src/modules/Distro.rb M library/general/src/modules/DontShowAgain.rb M library/general/src/modules/Encoding.rb M library/general/src/modules/FileUtils.rb M library/general/src/modules/Icon.rb M library/general/src/modules/Linuxrc.rb M library/general/src/modules/Misc.rb M library/general/src/modules/Mode.rb M library/general/src/modules/PackagesProposal.rb M library/general/src/modules/Popup.rb M library/general/src/modules/Stage.rb M library/general/src/modules/ValueBrowser.rb M library/general/src/modules/XVersion.rb M library/gpg/doc/example.rb M library/gpg/src/modules/GPG.rb M library/gpg/src/modules/GPGWidgets.rb M library/log/src/modules/ALog.rb M library/log/src/modules/LogView.rb M library/log/src/modules/LogViewCore.rb M library/network/src/modules/CWMFirewallInterfaces.rb M library/network/src/modules/Internet.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkPopup.rb M library/network/src/modules/PortAliases.rb M library/network/src/modules/PortRanges.rb M library/network/src/modules/SuSEFirewall.rb M library/network/src/modules/SuSEFirewallExpertRules.rb M library/network/src/modules/SuSEFirewallProposal.rb M library/network/src/modules/SuSEFirewallServices.rb M library/packages/src/include/packages/common.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageLock.rb M library/packages/src/modules/PackageSystem.rb M library/packages/src/modules/PackagesUI.rb M library/packages/src/modules/SignatureCheckDialogs.rb M library/packages/src/modules/SlideShow.rb M library/packages/src/modules/Slides.rb M library/runlevel/src/modules/Systemd.rb M library/sequencer/src/modules/Sequencer.rb M library/system/src/clients/view_anymsg.rb M library/system/src/modules/FileChanges.rb M library/system/src/modules/HWConfig.rb M library/system/src/modules/Initrd.rb M library/system/src/modules/Kernel.rb M library/system/src/modules/ModuleLoading.rb M library/types/src/modules/Address.rb M library/types/src/modules/Hostname.rb M library/types/src/modules/IP.rb M library/types/src/modules/Map.rb M library/types/src/modules/Netmask.rb M library/types/src/modules/Punycode.rb M library/types/src/modules/String.rb M library/types/src/modules/TypeRepository.rb M library/types/src/modules/URL.rb M library/wizard/src/modules/Confirm.rb M library/wizard/src/modules/Progress.rb M library/wizard/src/modules/Wizard.rb Log Message: ----------- do not use comparison with nil, including some more tricky conversion Commit: f284b2584b892cf06751a9e52c0c7c5ccd90afcb https://github.com/yast/yast-yast2/commit/f284b2584b892cf06751a9e52c0c7c5ccd... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/cwm/src/modules/CWM.rb M library/general/src/modules/Misc.rb M library/general/test/agents_test/proc_meminfo_agent_test.rb M library/general/testsuite/tests/FileUtils.rb M library/network/src/modules/PortAliases.rb M library/network/src/modules/PortRanges.rb M library/packages/test/slide_show_test.rb M library/system/src/modules/Kernel.rb M library/system/test/hw_detection_test.rb M library/types/src/modules/IP.rb M library/types/src/modules/Punycode.rb M library/types/test/ip_test.rb M library/types/testsuite/tests/String.rb Log Message: ----------- make numberic literals more readable Commit: c38c6978f8dd7d488af20f1476ea94d0fc7efbf9 https://github.com/yast/yast-yast2/commit/c38c6978f8dd7d488af20f1476ea94d0fc... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/types/src/modules/URLRecode.rb Log Message: ----------- do not use perl backrefs Commit: babb257b8b744f76958314b7b4348f2593cef382 https://github.com/yast/yast-yast2/commit/babb257b8b744f76958314b7b4348f2593... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/network/src/modules/NetworkService.rb M library/packages/src/modules/Product.rb M library/runlevel/src/modules/Service.rb M library/sequencer/src/modules/Sequencer.rb M library/system/src/lib/yast2/hw_detection.rb M library/types/src/modules/IP.rb Log Message: ----------- remove redundant return Commit: 1f2295cc2f9e4d18f5596ceb6afc4779ce2a7554 https://github.com/yast/yast-yast2/commit/1f2295cc2f9e4d18f5596ceb6afc4779ce... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/cwm/src/modules/CWM.rb M library/general/src/modules/ConfigHistory.rb Log Message: ----------- avoid self assignment Commit: 0ee8ce6ecd19c98d834c272ffa33a730bb5048cc https://github.com/yast/yast-yast2/commit/0ee8ce6ecd19c98d834c272ffa33a730bb... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/control/src/modules/ProductControl.rb M library/general/src/modules/AsciiFile.rb M library/wizard/src/modules/Wizard.rb Log Message: ----------- remove semicolons Commit: 653b463394d6bef6e40bdb07be50586d9da935a2 https://github.com/yast/yast-yast2/commit/653b463394d6bef6e40bdb07be50586d9d... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/packages/test/slide_show_test.rb M library/types/src/modules/IP.rb M library/types/src/modules/Integer.rb Log Message: ----------- use recommended reduce params name for single line Commit: 057bfed92df77c45fc63184715a45cab7bb2060e https://github.com/yast/yast-yast2/commit/057bfed92df77c45fc63184715a45cab7b... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/commandline/src/modules/CommandLine.rb M library/commandline/testsuite/tests/unique1.rb M library/control/src/modules/WorkflowManager.rb M library/cwm/src/modules/CWM.rb M library/cwm/src/modules/CWMTab.rb M library/cwm/src/modules/WizardHW.rb M library/cwm/testsuite/tests/t1.rb M library/cwm/testsuite/tests/t2.rb M library/desktop/src/clients/menu.rb M library/general/src/modules/Hooks.rb M library/general/test/linuxrc_test.rb M library/general/test/popup_test.rb M library/log/examples/logviewcore1.rb M library/log/examples/logviewcore2.rb M library/log/examples/logviewcore3.rb M library/log/src/modules/LogView.rb M library/log/src/modules/LogViewCore.rb M library/network/src/modules/NetworkConfig.rb M library/network/src/modules/NetworkInterfaces.rb M library/network/src/modules/NetworkService.rb M library/network/src/modules/SuSEFirewall.rb M library/network/test/load_ipv6_cfg_test.rb M library/network/test/network_service_test.rb M library/network/test/susefirewall_services_test.rb M library/packages/src/include/packages/common.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/src/modules/PackageSystem.rb M library/packages/src/modules/Product.rb M library/packages/test/product_test.rb M library/packages/test/slide_show_test.rb M library/runlevel/src/modules/Service.rb M library/runlevel/src/modules/ServicesProposal.rb M library/sequencer/src/modules/Sequencer.rb M library/sequencer/testsuite/tests/WS_check.rb M library/sequencer/testsuite/tests/Wizard0.rb M library/system/src/lib/yast2/hw_detection.rb M library/system/src/modules/Kernel.rb M library/system/test/hw_detection_test.rb M library/system/test/kernel_test.rb M library/systemd/src/lib/yast2/systemctl.rb M library/systemd/src/lib/yast2/systemd_unit.rb M library/systemd/src/modules/systemd_service.rb M library/systemd/src/modules/systemd_socket.rb M library/systemd/src/modules/systemd_target.rb M library/systemd/test/systemctl_test.rb M library/systemd/test/systemd_service_test.rb M library/systemd/test/systemd_socket_test.rb M library/systemd/test/systemd_target_test.rb M library/systemd/test/systemd_unit_test.rb M library/systemd/test/test_helper.rb M library/types/src/modules/IP.rb M library/types/src/modules/Netmask.rb M library/types/src/modules/URLRecode.rb M library/types/test/ip_test.rb M library/types/test/ipv4_netmask_test.rb M library/types/testsuite/tests/Map.rb M library/types/testsuite/tests/isempty.rb Log Message: ----------- fix spacing Commit: d5f9760c557942754c8d4bae419ef35fb4caf005 https://github.com/yast/yast-yast2/commit/d5f9760c557942754c8d4bae419ef35fb4... Author: Josef Reidinger Date: 2015-01-14 (Wed, 14 Jan 2015) Changed paths: M .rubocop.yml M library/control/src/modules/ProductControl.rb M library/general/src/modules/Hooks.rb M library/general/test/hooks_test.rb M library/network/test/network_interfaces_helpers_test.rb M library/packages/src/modules/PackageCallbacks.rb M library/packages/test/product_test.rb M library/runlevel/src/modules/Service.rb M library/runlevel/test/service_test.rb M library/runlevel/test/services_proposal_test.rb M library/systemd/src/lib/yast2/systemctl.rb M library/systemd/src/lib/yast2/systemd_unit.rb M library/systemd/src/modules/systemd_service.rb M library/systemd/src/modules/systemd_socket.rb M library/systemd/src/modules/systemd_target.rb M library/systemd/test/systemctl_test.rb M library/systemd/test/systemd_service_test.rb M library/systemd/test/systemd_socket_test.rb M library/systemd/test/systemd_target_test.rb M library/systemd/test/systemd_unit_test.rb M library/systemd/test/test_helper.rb Log Message: ----------- unify string quotes Compare: https://github.com/yast/yast-yast2/compare/e30ab81babab...d5f9760c5579