Author: jsmeix Date: Thu Dec 4 17:04:41 2008 New Revision: 53885 URL: http://svn.opensuse.org/viewcvs/yast?rev=53885&view=rev Log: - Fixed bugs which were introduced by the change on Wed Dec 3 2008. and align buttons according to the change on Wed Dec 3 2008 not only in basicadd.ycp but also in basicmodify.ycp (see Novell/Suse Bugzilla bnc#447515). - Have a meaningful desciptive label "Search for Drivers" in basicadd.ycp and basicmodify.ycp (see Novell/Suse Bugzilla bnc#446186). - 2.17.51 Modified: trunk/printer/VERSION trunk/printer/package/yast2-printer.changes trunk/printer/src/basicadd.ycp trunk/printer/src/basicmodify.ycp trunk/printer/src/printer_proposal.ycp trunk/printer/src/printingvianetwork.ycp Modified: trunk/printer/VERSION URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/VERSION?rev=53885&r1=53884&r2=53885&view=diff ============================================================================== --- trunk/printer/VERSION (original) +++ trunk/printer/VERSION Thu Dec 4 17:04:41 2008 @@ -1 +1 @@ -2.17.50 +2.17.51 Modified: trunk/printer/package/yast2-printer.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/package/yast2-printer.changes?rev=53885&r1=53884&r2=53885&view=diff ============================================================================== --- trunk/printer/package/yast2-printer.changes (original) +++ trunk/printer/package/yast2-printer.changes Thu Dec 4 17:04:41 2008 @@ -1,4 +1,16 @@ ------------------------------------------------------------------- +Thu Dec 4 16:59:48 CET 2008 - jsmeix@suse.de + +- Fixed bugs which were introduced by the change on Wed Dec 3 2008. + and align buttons according to the change on Wed Dec 3 2008 + not only in basicadd.ycp but also in basicmodify.ycp + (see Novell/Suse Bugzilla bnc#447515). +- Have a meaningful desciptive label "Search for Drivers" + in basicadd.ycp and basicmodify.ycp + (see Novell/Suse Bugzilla bnc#446186). +- 2.17.51 + +------------------------------------------------------------------- Thu Dec 4 16:34:29 CET 2008 - mzugec@suse.cz - align buttons (bnc#447517) @@ -37,7 +49,8 @@ locale which is required for the scripts to work correctly) so that now the connection tests in the Connection Wizard should again work as good as before in the old yast2-printer module - and provided an error popup with details when a test fails. + and provided an error popup with details when a test fails + (see Novell/Suse Bugzilla bnc#445543). - 2.17.48 ------------------------------------------------------------------- Modified: trunk/printer/src/basicadd.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/src/basicadd.ycp?rev=53885&r1=53884&r2=53885&view=diff ============================================================================== --- trunk/printer/src/basicadd.ycp (original) +++ trunk/printer/src/basicadd.ycp Thu Dec 4 17:04:41 2008 @@ -114,36 +114,36 @@ ( `ReplacePoint ( `id(`driver_filter_input_replace_point), `InputField - ( `id(`driver_filter_input), `opt(`stretch), + ( `id(`driver_filter_input), `opt(`hstretch), // Caption for a printer driver selection: - _("Assign &Driver"), + _("Search for &Drivers"), driver_filter_input_text ) ), - `VBox( - `Label(""), - `HBox( - `PushButton - ( `id(`apply_driver_filter), - // This button must be the default - // (it is activated when the user pressed the Enter key) - // because when the user has clicked into TextEntry to enter something - // it is normal to finish entering by pressing the Enter key - // but if the Enter key was linked to 'Next' or 'Back', - // the user would get the wrong action. - `opt(`default), - // Label of a PushButton to search a list for a search string - // and then show the search result: - _("&Show Matching Drivers") - ), - `PushButton - ( `id(`add_driver), - // Label of a PushButton to go to the "Add Driver" dialog - // to install a new driver (and perhaps download it before): - _("&Add Driver") - ) - ) - ) + `VBox + ( `Label(""), + `HBox + ( `PushButton + ( `id(`apply_driver_filter), + // This button must be the default + // (it is activated when the user pressed the Enter key) + // because when the user has clicked into TextEntry to enter something + // it is normal to finish entering by pressing the Enter key + // but if the Enter key was linked to 'Next' or 'Back', + // the user would get the wrong action. + `opt(`default), + // Label of a PushButton to search a list for a search string + // and then show the search result: + _("&Show Matching Drivers") + ), + `PushButton + ( `id(`add_driver), + // Label of a PushButton to go to the "Add Driver" dialog + // to install a new driver (and perhaps download it before): + _("&Add Driver") + ) + ) + ) ), `ReplacePoint ( `id(`driver_selection_replace_point), @@ -346,11 +346,12 @@ driver_filter_string = "qqqqqqqqqq"; } UI::ReplaceWidget( `id(`driver_filter_input_replace_point), - `TextEntry( `id(`driver_filter_input), - // Caption for a printer driver selection: - _("Assign &Driver"), - driver_filter_input_text - ) + `InputField + ( `id(`driver_filter_input), `opt(`hstretch), + // Caption for a printer driver selection: + _("Search for &Drivers"), + driver_filter_input_text + ) ); UI::ReplaceWidget( `id(`driver_selection_replace_point), `SelectionBox( `id(`driver_selection), @@ -397,11 +398,12 @@ { driver_filter_input_text = _("any model"); } UI::ReplaceWidget( `id(`driver_filter_input_replace_point), - `TextEntry( `id(`driver_filter_input), - // Caption for a printer driver selection: - _("Assign &Driver"), - driver_filter_input_text - ) + `InputField + ( `id(`driver_filter_input), `opt(`hstretch), + // Caption for a printer driver selection: + _("Search for &Drivers"), + driver_filter_input_text + ) ); UI::ReplaceWidget( `id(`driver_selection_replace_point), `SelectionBox( `id(`driver_selection), Modified: trunk/printer/src/basicmodify.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/src/basicmodify.ycp?rev=53885&r1=53884&r2=53885&view=diff ============================================================================== --- trunk/printer/src/basicmodify.ycp (original) +++ trunk/printer/src/basicmodify.ycp Thu Dec 4 17:04:41 2008 @@ -296,31 +296,36 @@ ( `HBox ( `ReplacePoint ( `id(`driver_filter_input_replace_point), - `TextEntry - ( `id(`driver_filter_input), + `InputField + ( `id(`driver_filter_input), `opt(`hstretch), // Caption for a printer driver selection: - _("Driver"), + _("Search for &Drivers"), driver_filter_input_text ) ), - `PushButton - ( `id(`apply_driver_filter), - // This button must be the default - // (it is activated when the user pressed the Enter key) - // because when the user has clicked into TextEntry to enter something - // it is normal to finish entering by pressing the Enter key - // but if the Enter key was linked to 'Next' or 'Back', - // the user would get the wrong action. - `opt(`default), - // Label of a PushButton to search a list for a search string - // and then show the search result: - _("&Show Matching Drivers") - ), - `PushButton - ( `id(`add_driver), - // Label of a PushButton to go to the "Add Driver" dialog - // to install a new driver (and perhaps download it before): - _("&Add Driver") + `VBox + ( `Label(""), + `HBox + ( `PushButton + ( `id(`apply_driver_filter), + // This button must be the default + // (it is activated when the user pressed the Enter key) + // because when the user has clicked into TextEntry to enter something + // it is normal to finish entering by pressing the Enter key + // but if the Enter key was linked to 'Next' or 'Back', + // the user would get the wrong action. + `opt(`default), + // Label of a PushButton to search a list for a search string + // and then show the search result: + _("&Show Matching Drivers") + ), + `PushButton + ( `id(`add_driver), + // Label of a PushButton to go to the "Add Driver" dialog + // to install a new driver (and perhaps download it before): + _("&Add Driver") + ) + ) ) ), `ReplacePoint @@ -669,11 +674,12 @@ driver_filter_string = "qqqqqqqqqq"; } UI::ReplaceWidget( `id(`driver_filter_input_replace_point), - `TextEntry( `id(`driver_filter_input), - // Caption for a printer driver selection: - _("Driver"), - driver_filter_input_text - ) + `InputField + ( `id(`driver_filter_input), `opt(`hstretch), + // Caption for a printer driver selection: + _("Search for &Drivers"), + driver_filter_input_text + ) ); UI::ReplaceWidget( `id(`driver_selection_replace_point), `SelectionBox( `id(`driver_selection), @@ -799,11 +805,12 @@ { driver_filter_input_text = _("any model"); } UI::ReplaceWidget( `id(`driver_filter_input_replace_point), - `TextEntry( `id(`driver_filter_input), - // Caption for a printer driver selection: - _("Driver"), - driver_filter_input_text - ) + `InputField + ( `id(`driver_filter_input), `opt(`hstretch), + // Caption for a printer driver selection: + _("Search for &Drivers"), + driver_filter_input_text + ) ); UI::ReplaceWidget( `id(`driver_selection_replace_point), `SelectionBox( `id(`driver_selection), Modified: trunk/printer/src/printer_proposal.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/src/printer_proposal.ycp?rev=53885&r1=53884&r2=53885&view=diff ============================================================================== --- trunk/printer/src/printer_proposal.ycp (original) +++ trunk/printer/src/printer_proposal.ycp Thu Dec 4 17:04:41 2008 @@ -235,15 +235,15 @@ } } ); - foreach( term queue, - (list<term>)Printer::QueueItems( true, false ), - { // Printer::QueueItems adds trailing spaces because the current YaST UI - // has almost no additional space between table columns: - string name = String::CutBlanks(queue[2]:""); - string description = String::CutBlanks(queue[3]:""); - proposal = add( proposal, name + ": " + description ); - } - ); + foreach( term queue, + (list<term>)Printer::QueueItems( true, false ), + { // Printer::QueueItems adds trailing spaces because the current YaST UI + // has almost no additional space between table columns: + string name = String::CutBlanks(queue[2]:""); + string description = String::CutBlanks(queue[3]:""); + proposal = add( proposal, name + ": " + description ); + } + ); } } } Modified: trunk/printer/src/printingvianetwork.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/src/printingvianetwork.ycp?rev=53885&r1=53884&r2=53885&view=diff ============================================================================== --- trunk/printer/src/printingvianetwork.ycp (original) +++ trunk/printer/src/printingvianetwork.ycp Thu Dec 4 17:04:41 2008 @@ -167,15 +167,15 @@ // to do all his printing tasks: _("&Hostname / IP Address") ), - `VBox( - `Label(""), + `VBox + ( `Label(""), `PushButton ( `id(`test_client_conf_server), // A PushButton to test whether or not the one single remote CUPS server // which is used to do all printing tasks is accessible: _("&Test Server") ) - ), + ), `HStretch() ) ) -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org