[Bnc-team-xfce] [Bug 1210562] New: Screen lock on XFCE with efifb leads to a deadlock
http://bugzilla.suse.com/show_bug.cgi?id=1210562 Bug ID: 1210562 Summary: Screen lock on XFCE with efifb leads to a deadlock Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.5 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Xfce Assignee: bnc-team-xfce@forge.provo.novell.com Reporter: tiwai@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- When the system is with efifb (i.e. without DRM) and XFCE screen lock is invoked, it doesn't go to the lock-screen but hangs up. Namely, the keyboard and the mouse focus is no longer taken while the mouse cursor can still move. You can change to other VT via ctrl-alt-Fx, and kill xfce4-screensaver program to recover. As of now, I'm not sure whether it's a problem of xfce4-screensaver, X driver, X lib or kernel. At least the problem could be seen on both QEMU and a bare metal. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Bnc-team-xfce mailing list Bnc-team-xfce@forge.provo.novell.com https://forge.provo.novell.com/mailman/listinfo/bnc-team-xfce
http://bugzilla.suse.com/show_bug.cgi?id=1210562 http://bugzilla.suse.com/show_bug.cgi?id=1210562#c1 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sndirsch@suse.com --- Comment #1 from Takashi Iwai <tiwai@suse.com> --- As far as I tested, the problem isn't seen with TW 6.2.x kernel even with efifb (nomodeset boot option). But this is likely because simplefb is used there, so it's running via DRM, and X modesetting driver is used instead of X fbdev driver. So, the behavior likely depends on X driver. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Bnc-team-xfce mailing list Bnc-team-xfce@forge.provo.novell.com https://forge.provo.novell.com/mailman/listinfo/bnc-team-xfce
http://bugzilla.suse.com/show_bug.cgi?id=1210562 http://bugzilla.suse.com/show_bug.cgi?id=1210562#c2 --- Comment #2 from Takashi Iwai <tiwai@suse.com> --- I checked the code of xfce4-screensaver and found that it's likely some hackish check of the existence of the monitor. src/gs-manager.c contains the function static gboolean gs_manager_is_real_monitor (GdkMonitor *monitor) { // avoiding some weird gdk bug // federico> avb: or if you don't care about a little unexplained messiness, // just discard monitors where both fields are null? :) if (gdk_monitor_get_manufacturer(monitor) == NULL && gdk_monitor_get_model(monitor) == NULL) return FALSE; return TRUE; } ... and quite a few stuff are skipped if this function returns false. It includes the creation of the overlay window. This explains why the things got broken with efifb; it doesn't have the monitor information, so it looks as if no monitor is connected. So obviously there is a bug in the fallback code in xfce4-screensaver. Or, we may simply drop this check at all. I tested quickly by commenting out those check and returning always TRUE, and xfce4-screensaver starts working fine with efifb, too. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Bnc-team-xfce mailing list Bnc-team-xfce@forge.provo.novell.com https://forge.provo.novell.com/mailman/listinfo/bnc-team-xfce
http://bugzilla.suse.com/show_bug.cgi?id=1210562 http://bugzilla.suse.com/show_bug.cgi?id=1210562#c3 --- Comment #3 from Takashi Iwai <tiwai@suse.com> --- For reproducing the bug, just try to boot with "nomodeset" boot option on Leap 15.5. As already mentioned, this bug doesn't appear on TW even with the boot option because of the activated simplefb in TW kernel (hence it's always a DRM device). -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Bnc-team-xfce mailing list Bnc-team-xfce@forge.provo.novell.com https://forge.provo.novell.com/mailman/listinfo/bnc-team-xfce
http://bugzilla.suse.com/show_bug.cgi?id=1210562 http://bugzilla.suse.com/show_bug.cgi?id=1210562#c4 --- Comment #4 from Takashi Iwai <tiwai@suse.com> --- It seems that the check of a real monitor was introduced by the commit https://gitlab.xfce.org/apps/xfce4-screensaver/-/commit/c44e54350c786497b3bf... And it's basically for multi-monitor setups and plug/unplug. Maybe we can assume that the primary monitor is OK even if no monitor info is given? A test fix patch is like below. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Bnc-team-xfce mailing list Bnc-team-xfce@forge.provo.novell.com https://forge.provo.novell.com/mailman/listinfo/bnc-team-xfce
http://bugzilla.suse.com/show_bug.cgi?id=1210562 http://bugzilla.suse.com/show_bug.cgi?id=1210562#c5 --- Comment #5 from Takashi Iwai <tiwai@suse.com> --- Created attachment 866386 --> http://bugzilla.suse.com/attachment.cgi?id=866386&action=edit Test fix patch -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Bnc-team-xfce mailing list Bnc-team-xfce@forge.provo.novell.com https://forge.provo.novell.com/mailman/listinfo/bnc-team-xfce
participants (1)
-
bugzilla_noreply＠suse.com