Branch: refs/heads/master Home: https://github.com/openSUSE/wicked Commit: bde04a1c454b0e07042986ba3985bec73a4f04dc https://github.com/openSUSE/wicked/commit/bde04a1c454b0e07042986ba3985bec73a... Author: Karol Mroz Date: 2014-07-08 (Tue, 08 Jul 2014) Changed paths: M dhcp4/device.c Log Message: ----------- dhcp4: fix link type comparison during device up events Previously we invoked ni_capture_devinfo_refresh() directly which lead to many: ni_error("%s: reconfig changes device type! d%u l%u", devinfo->ifname, devinfo->iftype, link->type); This was comparing an empty dhcp4 dev->link struct with one that was populated during dhcp4 device creation (ie. dhcp4_device_create()-> ni_dhcp4_device_new()->ni_capture_devinfo_init()). Now, on a device up event (ie. ni_dhcp4_event(..., event==NI_EVENT_DEVICE_UP), we invoke the proper refresh function (also used during ni_dhcp4_acquire()) and compare properly initialized dev->system AND dev->link structs to detect potential changes in device type from time of creation (represented by dev->system) to time of configuration/re-configuration (represented by dev->link). This error has been mentioned in: bnc#880700 Commit: 9e7ed14d473e9ba4e3d7038adae2d221b6d8c834 https://github.com/openSUSE/wicked/commit/9e7ed14d473e9ba4e3d7038adae2d221b6... Author: Marius Tomaschewski Date: 2014-07-10 (Thu, 10 Jul 2014) Changed paths: M dhcp4/device.c Log Message: ----------- Merge pull request #305 from kmroz/fix_reconfig_changes_error dhcp4: fix link type comparison during device up events Compare: https://github.com/openSUSE/wicked/compare/6bc1e049b677...9e7ed14d473e