[opensuse-web] Slow tests
Hi, I have been trying to work on test coverage but it isn't going great cause setup time before any of the tests run is just huge -_- spring saves 5-7 seconds, which amount to nothing in front of 30-40 seconds delay. It really shouldn't take a minute if i want run just one test. Delay in start is not because of file loads, besides spring recovers whatever delay file load has. What I do see is that database for test is created and removed multiple times before any of the test has run. Isn't that weird? Anyway, I am wondering if you guys knows have ever investigated this. *About PR #784 <https://github.com/openSUSE/osem/pull/784>* I know you guys don't need that but contributors like me do? You have limited travis builds only to master, now I can't run builds on branches I experiment with and may be send pull requests later on. Even current config sucks, cause every time I (or any other fork ower) updates master you guys will receive notification on irc and a mail. This means I (or every other fork) shouldn't ever update master if I want to be nice and not be cause of unnecessary notifications. Lastly, do you have bi weekly meetings? Any thoughts on gitter? Thank you, Aditya
Hey Aditya, On 18.02.2016 13:26, Aditya Prakash wrote:
I have been trying to work on test coverage
Awesome!
What I do see is that database for test is created and removed multiple times before any of the test has run. Isn't that weird?
Before any test runs we are using DatabaseCleaner to truncate the DB to make sure it's clean and then every test runs in a transaction. Nothing should be created/removed. Why do you think this is happening? Do you have a log or something? :-)
*About PR#784 <https://github.com/openSUSE/osem/pull/784>*
There are two things to this. Limiting the build to master and notifications. Limiting this to master is stupid, you're right and I have fixed this. Now that it builds for every branch we want those notifications, they are not unnecessary and just fine :-)
Lastly, do you have bi weekly meetings?
We don't. We just hang out on IRC.
Any thoughts on gitter?
Yeah but they are not suitable for persons under 18 ;-) No seriously, we think Free Software and open protocols are very important that's one of the reasons we use IRC. Henne -- Henne Vogelsang http://www.opensuse.org Everybody has a plan, until they get hit. - Mike Tyson -- To unsubscribe, e-mail: opensuse-web+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-web+owner@opensuse.org
Hi Henne,
Why do you think this is happening? Do you have a log or something?
Time is going backwards? I know it sounds stupid but at least thats what I see. Use this gist <https://gist.github.com/sonalkr132/cc3df89f440f63452375>, add it to top of spec_helper.rb and call it again from any of the spec files. I called it from `conference_controller_spec.rb` with `stamp "running it block"` and output was: 0.000 start -56922094.628 running it block I guess you will have to run it yourself to believe me. Or may it like this just in my local env? You guys see the same delay (of 30-40 secs) before test runs, right? In any case, I am try to go through the call stack and trying to investigate this further. Now that it builds for every branch we want those notifications, they are
not unnecessary and just fine
I hope you know that now you will receive notification on irc as well an email for every failing and then fixed builds on from all the forks of osem. You can get around notification on irc with somewhat mozilla guys did: https://github.com/mozilla/build-tools/commit/c13a2978e0869219295013eeb52cf5... However there is no fix for email thingy. It really sucked to find out that it an issue known to travis <https://github.com/travis-ci/travis-ci/issues/1094> for three year :'( Cheers, Aditya
Hey, On 18.02.2016 15:50, Aditya Prakash wrote:
Why do you think this is happening? Do you have a log or something?
Time is going backwards? I know it sounds stupid but at least thats what I see.
Also without spring?
You guys see the same delay (of 30-40 secs) before test runs, right?
No I don't. But I don't use spring...
I hope you know that now you will receive notification on irc as well an email for every failing and then fixed builds on from all the forks of osem.
Yes don't worry :-) Henne -- Henne Vogelsang http://www.opensuse.org Everybody has a plan, until they get hit. - Mike Tyson -- To unsubscribe, e-mail: opensuse-web+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-web+owner@opensuse.org
Hi,
Also without spring?
I wasn't using for spring to avoid any side-effects it might have on boot time.
No I don't. But I don't use spring...
Again, nothing related to spring in this issue. I think you might not have test run times as bad as me cause of faster internet connection. You can find more details on the issue on my PR: https://github.com/openSUSE/osem/pull/786 Cheers, Aditya
Hi everyone, I have blogged about it here: https://chasingcrazydreams.wordpress.com/2016/02/20/running-tests-should-be-... Check it out and let me know why do you think. I am eagerly waiting for Christian's opinion on this. Cheers, Aditya On Fri, Feb 19, 2016 at 11:23 AM, Aditya Prakash < aditya.prakash132@gmail.com> wrote:
Hi,
Also without spring?
I wasn't using for spring to avoid any side-effects it might have on boot time.
No I don't. But I don't use spring...
Again, nothing related to spring in this issue. I think you might not have test run times as bad as me cause of faster internet connection.
You can find more details on the issue on my PR: https://github.com/openSUSE/osem/pull/786
Cheers, Aditya
I commented in the PR. When you ask me, spending several hours to make the test 5 seconds faster (as you stated in your blog article) isn't worth the effort ... On 02/20/2016 08:21 AM, Aditya Prakash wrote:
Hi everyone,
I have blogged about it here: https://chasingcrazydreams.wordpress.com/2016/02/20/running-tests-should-be-... Check it out and let me know why do you think. I am eagerly waiting for Christian's opinion on this.
Cheers, Aditya
On Fri, Feb 19, 2016 at 11:23 AM, Aditya Prakash <aditya.prakash132@gmail.com <mailto:aditya.prakash132@gmail.com>> wrote:
Hi,
Also without spring?
I wasn't using for spring to avoid any side-effects it might have on boot time.
No I don't. But I don't use spring...
Again, nothing related to spring in this issue. I think you might not have test run times as bad as me cause of faster internet connection.
You can find more details on the issue on my PR: https://github.com/openSUSE/osem/pull/786
Cheers, Aditya
-- To unsubscribe, e-mail: opensuse-web+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-web+owner@opensuse.org
participants (3)
-
Aditya Prakash -
Christian Bruckmayer -
Henne Vogelsang