Olaf, Am 25.08.2014 09:35, schrieb Olaf Hering:
On Thu, Aug 21, Andreas Färber wrote:
One thing that's not yet clear to me is, the QEMU package seems to be still building libcacard itself but removing it on installation? Shouldn't qemu instead get a BuildRequires: libcacard-devel and reuse the same binary as the spice package? That may require patches to QEMU.
qemu should not duplicate code. So if libcacard is maintained and qemu can cope with the external package it should build/link against the external package.
Package is getting confusing now: The external package in security repository was ancient and therefore dropped. The code is part of qemu.git for several years now [1] and shipped inside the QEMU tarballs. Thus [2] contains a QEMU tarball more recent than any libcacard tarball. Right now with Coolo's changes, both are building the exact same source code, but in two different places. It looks like QEMU's configure doesn't check for a system-installed libcacard today, which we/I should then fix upstream. My immediate concern however was whether those two packages, qemu and libcacard, could run out of step without qemu.spec growing an BuildRequires on libcacard-devel - may understanding is no, due to the indirect dependency through spice, but a second pair of eyes would be appreciated. Cheers, Andreas [1] http://git.qemu-project.org/?p=qemu.git;a=history;f=libcacard;hb=HEAD [2] http://www.spice-space.org/download/libcacard/ -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe, e-mail: opensuse-virtual+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-virtual+owner@opensuse.org