I have identified the apsfilter related printing problem reported by Purple Shirt on the 8 Dec. 2001, in the suse-english mailing list. Due to a nasty bug at the beginning of apsfilter, printing of non plain-ascii postscript is just impossible, as it gets interpreted as text (ironic, isn't it). Apple MacOSX and probably others sends Postsript files which contains special characters like null characters. It took me two full days to pinpoint and fix (I had no previous knowledge of lpd and apsfilter). However, the fix is quite straight-forward for someone who master apsfilter's internals, except, maybe, for a second bug that would still deprive french users and possibly others from printing. I find it surprising that no one at SuSE seems to have taken any action so far. The following patch fixes both bugs. Of course, SuSE is free to use it at once and publish the patched apsfilter for Yast Online Update ASAP ;) to apply the patch, put it in /var/lib/apsfilter/ cd /var/lib/apsfilter/ patch -p0 < apsfilter-patch Raphael Marmier raphael@marmier.net *** apsfilter Sun Dec 30 05:59:52 2001 --- apsfilter.new Sun Dec 30 05:29:28 2001 *************** *** 87,99 **** # # Strange GNU grep 2.3 (and higher?) ! # grepver=$(grep -V 2> /dev/null | head -n 1) GREPOPT="" case $grepver in ! *GNU*grep*) ! major=${grepver##* } ! minor=${major##*.} ! major=${major%%.*} ! test $major -ge 2 -a $minor -ge 3 && GREPOPT="-a" ;; *) ;; --- 87,102 ---- # # Strange GNU grep 2.3 (and higher?) ! # And strange consequences of excessive localisation ;) Raph grepver=$(grep -V 2> /dev/null | head -n 1) GREPOPT="" case $grepver in ! # The french grep -V puts "GNU" _after_ "grep", causing old expr to fail! ! *GNU*) ! vernum=${grepver##* } ! # Must make sure we grab the first 2 digits. Newer versions have three! ! major=$(echo $vernum|cut -d'.' -f1) ! minor=$(echo $vernum|cut -d'.' -f2) ! test $major -eq 2 -a $minor -ge 3 \ ! -o $major -ge 3 && GREPOPT="-a" ;; *) ;;
Raphael Marmier schrieb:
I have identified the apsfilter related printing problem reported by Purple Shirt on the 8 Dec. 2001, in the suse-english mailing list.
Due to a nasty bug at the beginning of apsfilter, printing of non plain-ascii postscript is just impossible, as it gets interpreted as text (ironic, isn't it).
Apple MacOSX and probably others sends Postsript files which contains special characters like null characters.
It took me two full days to pinpoint and fix (I had no previous knowledge of lpd and apsfilter). However, the fix is quite straight-forward for someone who master apsfilter's internals, except, maybe, for a second bug that would still deprive french users and possibly others from printing.
I find it surprising that no one at SuSE seems to have taken any action so far.
The following patch fixes both bugs. Of course, SuSE is free to use it at once and publish the patched apsfilter for Yast Online Update ASAP ;)
to apply the patch, put it in /var/lib/apsfilter/ cd /var/lib/apsfilter/ patch -p0 < apsfilter-patch
Raphael Marmier raphael@marmier.net
Raphael, which version of apsfilter needs the fix (or which SuSE version)? You should mail both the fix and a short problem discription to feedback@suse.com. The latter makes sure it finds it's way to the SDB. Juergen [...] -- =========================================== __ _ Juergen Braukmann juergen.braukmann@gmx.de| -o)/ / (_)__ __ ____ __ Tel: 0201-743648 dk4jb@db0qs.#nrw.deu.eu | /\\ /__/ / _ \/ // /\ \/ / ===========================================_\_v __/_/_//_/\_,_/ /_/\_\
Well done Raphael ! Brian Marr On Sunday 30 December 2001 16:45, you wrote:
I have identified the apsfilter related printing problem reported by Purple Shirt on the 8 Dec. 2001, in the suse-english mailing list.
Due to a nasty bug at the beginning of apsfilter, printing of non plain-ascii postscript is just impossible, as it gets interpreted as text (ironic, isn't it).
Apple MacOSX and probably others sends Postsript files which contains special characters like null characters.
It took me two full days to pinpoint and fix (I had no previous knowledge of lpd and apsfilter). However, the fix is quite straight-forward for someone who master apsfilter's internals, except, maybe, for a second bug that would still deprive french users and possibly others from printing.
I find it surprising that no one at SuSE seems to have taken any action so far.
The following patch fixes both bugs. Of course, SuSE is free to use it at once and publish the patched apsfilter for Yast Online Update ASAP ;)
to apply the patch, put it in /var/lib/apsfilter/ cd /var/lib/apsfilter/ patch -p0 < apsfilter-patch
Raphael Marmier raphael@marmier.net
*** apsfilter Sun Dec 30 05:59:52 2001 --- apsfilter.new Sun Dec 30 05:29:28 2001 *************** *** 87,99 **** # # Strange GNU grep 2.3 (and higher?) ! # grepver=$(grep -V 2> /dev/null | head -n 1) GREPOPT="" case $grepver in ! *GNU*grep*) ! major=${grepver##* } ! minor=${major##*.} ! major=${major%%.*} ! test $major -ge 2 -a $minor -ge 3 && GREPOPT="-a" ;; *) ;; --- 87,102 ---- # # Strange GNU grep 2.3 (and higher?) ! # And strange consequences of excessive localisation ;) Raph grepver=$(grep -V 2> /dev/null | head -n 1) GREPOPT="" case $grepver in ! # The french grep -V puts "GNU" _after_ "grep", causing old expr to fail! ! *GNU*) ! vernum=${grepver##* } ! # Must make sure we grab the first 2 digits. Newer versions have three! ! major=$(echo $vernum|cut -d'.' -f1) ! minor=$(echo $vernum|cut -d'.' -f2) ! test $major -eq 2 -a $minor -ge 3 \ ! -o $major -ge 3 && GREPOPT="-a" ;; *) ;;
On Sunday 30 December 2001 07:15, you wrote:
I have identified the apsfilter related printing problem reported by Purple Shirt on the 8 Dec. 2001, in the suse-english mailing list. Hey. This solved my problem to!
Thanks a lot! Regards Klaus V. Slott
participants (4)
-
Brian Marr -
Juergen Braukmann -
Klaus Slott -
Raphael Marmier