On 08/07/2017 03:12 AM, Marcus Meissner wrote:
On Mon, Aug 07, 2017 at 03:06:56AM -0500, David C. Rankin wrote:
On 08/07/2017 01:40 AM, Marcus Meissner wrote:
Also maintenance submissions need a correct changelog, use "osc vc" Mention the opensuse bugnr, patchfilename and a short desc what it fixes.
Oh no. I think the osc sr did actually submit it as a maintenance request. I included the following as the comment description:
Patched for https://bugzilla.gnome.org/show_bug.cgi?id=779605 - gtkrecentchooser GLib-CRITICAL Source ID xxx was not found when attempting to remove it. Gtk+2 2.24 commit https://git.gnome.org/browse/gtk+/commit/?h=gtk-2-24&id=491d79d54083044a5de3bfa2d7afe9cced3974f0
The original bug I filed was with gnome.org, so there will not be an opensuse bug number.
I've installed the new libgtk-2_0-0-2.24.31-13.5.1.x86_64.rpm and it works like a champ, bug is gone when activating the gtkrecentchooser.
If I need to resubmit with 'vc' instead of 'sr', let me know. The id is 514841, but I cannot see it with 'osc my'. I don't know if that is normal or it means that it really wasn't submitted.
No, osc vc is for changelog creation and needs to be done before the submission.
It will add a gtk2.changes entry.
For tracking purposes a opensuse bug is required, even if it just points to the gnome bug.
Ciao, Marcus
I still have no idea if this actually worked. I filed opensuse bug: https://bugzilla.opensuse.org/show_bug.cgi?id=1052668 I used $ osc vc and added to gtk2.changes the following: ------------------------------------------------------------------- Tue Aug 8 23:08:00 UTC 2017 - drankinatty@suddenlinkmail.com - Fix gtkrecentchooser GLib-CRITICAL Source ID xxx was not found: + Bug 1052668. I used $ osc sr home:drankinatty/gtk2_patch_491d79d5 openSUSE:Leap:42.2:Update/gtk2 added when prompted for comment: OpenSuSE bug: https://bugzilla.opensuse.org/show_bug.cgi?id=1052668. Patched for https://bugzilla.gnome.org/show_bug.cgi?id=779605 - gtkrecentchooser GLib-CRITICAL Source ID xxx was not found when attempting to remove it. Gtk+2 2.24 commit https://git.gnome.org/browse/gtk+/commit/?h=gtk-2-24&id=491d79d54083044a5de3bfa2d7afe9cced3974f0 output: WARNING: WARNING: Project does not accept submit request, request to open a NEW maintenance incident instead WARNING: created request id 515110 I guess it is too soon for osc my to show anything about 515110, all I see is: $ osc my Declined requests created by you (revoke, reopen or supersede): 514841 State:declined By:AndreasStieger When:2017-08-07T12:55:45 maintenance_incident: home:drankinatty/gtk2_patch_491d79d5@8b1c601bb24ab61845738d1c96a97ea3 -> openSUSE:Maintenance (release in openSUSE:Leap:42.2:Update) Review by User is accepted: maintbot(maintbot) Descr: Patched for https://bugzilla.gnome.org/show_bug.cgi?id=779605 - gtkrecentchooser GLib-CRITICAL Source ID xxx was not found when attempting to remove it. Gtk+2 2.24 commit https://git.gnome.org/ browse/gtk+/commit/?h=gtk-2-24&id=491d79d54083044a5de3bfa2d7a fe9cced3974f0 Comment: See https://bugzilla.opensuse.org/show_bug.cgi?id=1052570 514836 State:declined By:msmeissn When:2017-08-07T06:37:28 submit: home:drankinatty/gtk2_patch_491d79d5@4 -> openSUSE:Maintenance:Test:Leap_42.2/gtk2 Descr: Patched for https://bugzilla.gnome.org/show_bug.cgi?id=779605 - gtkrecentchooser GLib-CRITICAL Source ID xxx was not found when attempting to remove it. Gtk+2 2.24 commit https://git.gnome.org/ browse/gtk+/commit/?h=gtk-2-24&id=491d79d54083044a5de3bfa2d7afe9c ced3974f0 Comment: see email So now do we just wait and see? This was a heck of a process. I still don't know why I can choose 'Submit' in my buildservice package and have it do the same thing rather than having to use osc. I guess that will become clearer as I get more familiar with it, but at this point, I still feel like a fish-out-of-water with this whole newfangled process. (which is not entirely uncommon for any newfangled process) -- David C. Rankin, J.D.,P.E. -- To unsubscribe, e-mail: opensuse+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse+owner@opensuse.org