rj45 connections

I've always done this at *both* ends of a straight through cable: pin1 blue stripe pin2 blue pin3 orange stripe pin4 orange pin5 green stripe pin6 green pin7 brown stripe pin8 brown Mate of mine says it's all wrong. Google confuses me still further. Is there anything wrong with my wiring? Thanks, Steve.