On Thursday 22 February 2007 00:09, Joe Morris (NTM) wrote:
John Summerfield wrote:
On Tuesday 20 February 2007 23:20, Joe Morris (NTM) wrote:
Problem is this line in ddclient, debug("glo fw = $globals{'fw'}");,
which causes this error when run, Use of uninitialized value in concatenation (.) or string at /usr/sbin/ddclient line 1646.
What version of ddclient? I'm using 3.3.7 (on CentOS) and do not have a problem, even though it has that line: 1644 debug("server = $server"); 1645 debug("opt(fw = ",opt('fw')); 1646 debug("glo fw = $globals{'fw'}");
Hang on, what's that at the end of line 1646 in yours?
The bug is in that line. I changed it to debug("glo fw = ",$globals{'fw'});
Your response confuses me, but that comma is definitely wrong: Which comma? As I said, the comma at the end of that line in my first
John Summerfield wrote: post must have been an artifact of another sentence or something. i pasted it from the original, and it is not there in the original.
Perl statements are (mostly, and this one is) separated by semicolons, and the comma is not a good way to start a new one.
If you are meaning the comma after the quote sign in the line with the error, then please explain further.
If you didn't put it there, it's a fairly important bug, as you noticed:-) Well, this is an important bug to me, as it caused ddclient not to run on my box. But, to summarize a bit (in addition to over posting for contexts sake) this is what I found. These 2 lines,
debug("opt(fw = ",opt('fw')); debug("glo fw = $globals{'fw'}"); look very similar, but i noticed the quoting was different. I had tried, based on some things Patrick had mentioned, to add fw=no inline with the use=web line in the config, and it ran without error, so I thought maybe that was the problem, but noticed running debug the the first opt had a blank value, but the glo had the word no. Then I noticed the differences in the 2 lines quoting. First, I tried changing the first to debug("opt(fw = opt('fw')") - but this didn't work. Then, I changed the line with the error to debug("glo fw = ",$globals{'fw'}); and it worked without the extra fw=no, and debug had blank values for both, so I assume that is the correct line. But as you can tell, I am not a programmer, and do not know Perl. I see it is working correctly (with ssl btw), and I would like to let the author know if this is valid. This error is present with 3.7.0 and 3.7.1 btw. If you can confirm, since you seem to know Perl, if this looks correct, I will report it to the author and send him a patch to fix it. Thanks. -- Joe Morris Registered Linux user 231871 running openSUSE 10.2 x86_64 -- To unsubscribe, e-mail: opensuse+unsubscribe@opensuse.org For additional commands, e-mail: opensuse+help@opensuse.org