Hello, On Wed, 05 May 2010, David C. Rankin wrote: [..]
/sbin/conf.d/SuSEconfig.gtk2: line 67: test: /usr/share/icons/Royal: binary operator expected gtk-update-icon-cache: The generated cache was invalid. Finished.
Poking around, the names that give the errors don't have spaces in them so that can be eliminated,
Sure? There's exactly one 'test' in line 67: test -f $SUBDIR/icon-theme.cache and that fails on unquoted spaces in the argument, as -f expects _one_ argument. Compare with: $ test -f foo bar test: foo: binary operator expected
and after that, I'm lost as to what SuSEconfig may be looking for. Any help will be appreciated.
David, try this patch: --- /sbin/conf.d/SuSEconfig.gtk2~ 2010-01-21 22:52:34.000000000 +0100 +++ /sbin/conf.d/SuSEconfig.gtk2 2010-05-05 23:02:47.000000000 +0200 @@ -1,4 +1,4 @@ -#! /bin/sh +#! /bin/bash # Copyright (c) 2002 SuSE Gmbh Nuernberg, Germany. All rights reserved. # # Author: Holger Hetterich <hhetter@suse.de>, 2002 @@ -46,8 +46,8 @@ # directories with icon-theme.cache after removing themes. if test -f $r/var/cache/gtk-2.0/icon-theme.cache-list ; then for DIR in $(<$r/var/cache/gtk-2.0/icon-theme.cache-list) ; do - if test $(ls -1 "$DIR" | wc --lines) -le 1 -a -f $DIR/icon-theme.cache; then - rm -f $DIR/icon-theme.cache + if test $(ls -1 "$DIR" | wc -l) -le 1 -a -f "${DIR}/icon-theme.cache"; then + rm -f "${DIR}/icon-theme.cache" rmdir --ignore-fail-on-non-empty "$DIR" fi done @@ -60,12 +60,12 @@ . $r/etc/profile fi IFS="$IFS:" - for DIR in ${XDG_DATA_DIRS:-/usr/local/share/:/usr/share/} ; do - for SUBDIR in $DIR/icons/* ; do + for DIR in "${XDG_DATA_DIRS:-/usr/local/share/:/usr/share/}" ; do + for SUBDIR in "${DIR}/icons"/* ; do if test ! -L "$SUBDIR" -a -d "$SUBDIR" ; then /usr/bin/gtk-update-icon-cache --quiet --ignore-theme-index "$SUBDIR" - if test -f $SUBDIR/icon-theme.cache ; then - echo $SUBDIR >>$r/var/cache/gtk-2.0/icon-theme.cache-list + if test -f "${SUBDIR}/icon-theme.cache" ; then + echo "$SUBDIR" >> /var/cache/gtk-2.0/icon-theme.cache-list fi fi done ==== With that, it run's here. Otherwise, you'll need to mail the remaining errors. -dnh -- Never attribute to malice that which can be adequately explained by stupidity. -- Hanlon's razor -- To unsubscribe, e-mail: opensuse+unsubscribe@opensuse.org For additional commands, e-mail: opensuse+help@opensuse.org