Hi,
find below the review from Michael Chang, based on the rspec version of
the specification.
Jiri
Yast::Storage::BootRequirementsChecker
#needed_partitions in a x86 system
using UEFI
with a partitions-based proposal
if there are no EFI partitions
requires only a new /boot/efi partition
if there is already an EFI partition
only requires to use the existing EFI partition
with a LVM-based proposal
if there are no EFI partitions
requires /boot and a new /boot/efi partition
if there is already an EFI partition
requires /boot and a reused /boot/efi partition
not using UEFI (legacy PC)
with an MS-DOS partition table
with sufficently large MBR gap
in a partitions-based proposal
does not require any particular volume
in a LVM-based proposal
requires only a /boot partition
I am not sure why the /boot parititon is needed here. If you have sufficently
large MBR gap to embed stage2 image, then it could boot off from LVM volumes
directly.
with too small MBR gap
raises an exception
with no MBR gap
raises an exception
It is a little messy here, how it works currently depends on file system and
any disk abstractions user is going to create.
Please note I am assuming we still specify --force to "grub2-install" so that
fallback can really be triggered.
1. Filesystem like extX, XFS: Fallback to blocklist mode, which is more
"fragile" so displaying warnings.
2. COW File system. Btrfs(ZFS): Fallback to use filesystem provided bootloader
pad which can be equivalent to mbr gap.
3. Any disk abstractions like LVM and mdadm: expliclty require MBR gap, so
error out is reasonable.
with GPT partition table
if there is no GRUB partition
in a partitions-based proposal
only requires a new GRUB partition
in a LVM-based proposal
requires /boot and a GRUB partitions
Why not also creating new GRUB partition for LVM so that /boot can be omitted ?
if there is already a GRUB partition
in a partitions-based proposal
does not require any particular volume
in a LVM-based proposal
only requires a /boot partition
Do we have any reason to keep /boot partition for LVM ? It should be the same
with previous "does not require any particular volume" to me.
when proposing a boot partition
requires /boot to be ext4 with at least 100 MiB
requires /boot to be in the system disk out of LVM
recommends /boot to be 200 MiB
when proposing an new EFI partition
requires /boot/efi to be vfat with at least 33 MiB
requires /boot/efi to be out of LVM
recommends /boot/efi to be 500 MiB
requires /boot/efi to be close enough to the beginning of disk
when proposing an new GRUB partition
requires it to have the correct id
requires it to be out of LVM
requires it to be between 256KiB and 8MiB, despite the alignment
recommends it to be 1 MiB
--
To unsubscribe, e-mail: opensuse-storage+unsubscribe(a)opensuse.org
To contact the owner, e-mail: opensuse-storage+owner(a)opensuse.org
