[opensuse-ruby] Gem::all_load_paths method broken in Factory
Hi All, Got a bit of a problem... Gem::all_load_paths in rubygems 1.8.15 in Factory is broken. Some small description is at: https://github.com/rubygems/rubygems/issues/171 Now, this is a deprecated method, but rubygem-gettext uses it, so rubygem-gettext is effectively broken in turn, see: https://github.com/mutoh/gettext/pull/11 This in turn breaks applications which use rubygem-gettext, which is what I actually care about :) AFAICT no patch has been proposed to fix the deprecated method in rubygems (maybe nobody cares, it's deprecated, right?), and nobody has picked up the proposed patch for the gettext gem upstream. So, what's the right course of action? I guess I can patch our version of the gettext gem, assuming we're happy to carry non-upstream patches. Or, I could try to monkey patch around the whole problem in my application, but I don't want to do that, because it's ugly, and it doesn't help anyone else who's going to hit this. Comments? Thanks, Tim -- Tim Serong Senior Clustering Engineer SUSE tserong@suse.com -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
Dne 23.2.2012 10:17, Tim Serong napsal(a):
So, what's the right course of action? I guess I can patch our version of the gettext gem, assuming we're happy to carry non-upstream patches. Or, I could try to monkey patch around the whole problem in my application, but I don't want to do that, because it's ugly, and it doesn't help anyone else who's going to hit this.
Currently I'm using the monkey patch solution in both SLMS and WebYast. Yes, it would be nice to fix it once and for all. The best solution would be to fix it in gettext gem upstream, but if the maintainers do not care to merge the proposed patches... I'm not sure what's a better solution, our own patched gettext version could save some time to our developers, on the other hand monkey patching has an advantage that it also works with upstream gems (so it works also with bundler or rvm). -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
On Thu, 23 Feb 2012 11:15:28 +0100 Ladislav Slezak <lslezak@suse.cz> wrote:
Dne 23.2.2012 10:17, Tim Serong napsal(a):
So, what's the right course of action? I guess I can patch our version of the gettext gem, assuming we're happy to carry non-upstream patches. Or, I could try to monkey patch around the whole problem in my application, but I don't want to do that, because it's ugly, and it doesn't help anyone else who's going to hit this.
Currently I'm using the monkey patch solution in both SLMS and WebYast. Yes, it would be nice to fix it once and for all.
The best solution would be to fix it in gettext gem upstream, but if the maintainers do not care to merge the proposed patches...
I'm not sure what's a better solution, our own patched gettext version could save some time to our developers, on the other hand monkey patching has an advantage that it also works with upstream gems (so it works also with bundler or rvm).
--
Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE
I already created such patch in github and it is accepted, so lets wait until new version of rubygems appear: https://github.com/rubygems/rubygems/pull/284 Josef -- Josef Reidinger Software Engineer Appliance Department SUSE LINUX, s. r. o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic jreidinger@suse.com SUSE -- To unsubscribe, e-mail: opensuse-ruby+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-ruby+owner@opensuse.org
participants (3)
-
Josef Reidinger -
Ladislav Slezak -
Tim Serong