Hi Jimmy, Could you point me where is the code in the new repochecker processing multibuild package request? Regards, Max On 07/13/2017 07:22 AM, Jimmy Berry wrote:
On Wednesday, July 12, 2017 9:18:43 AM CDT Jimmy Berry wrote:
On Wednesday, July 12, 2017 7:24:21 AM CDT Ludwig Nussel wrote:
Jimmy Berry wrote: [...]
The last minor discussion point is that the ReviewBot currently operates either on a project + request type or reviews targeting a user/group. The current repo checker uses the user/group target, but that would mix reviews for Factory and Leap in one cycle. The ReviewBot could be changed (or extended) to allow
Is there a problem with processing all requests in the same bot instance? If we wanted to use different instances we could also use different users instead. Is the new bot faster then the old one?
I performed a basic performance analysis (73% faster in basic test): see https://github.com/openSUSE/osc-plugin-factory/pull/964#issuecomment-3149246... for details.
Yes, different users could be used instead, but it is not clear if that is best approach since it may add needless obfuscation for contributors.
The new bot is 1/4th the size in code (85% less loops, 118 in main code before!?), runs a significantly lower number of queries, and reduces a lot of duplication so I would expect it to run faster. That said I have not run a formal comparison and the new bot also check multiple archs so it now includes i586. For a comparison I may run with multiple archs disabled, pre-download all packages, and limit to same list of requests.
filtering by project in addition to review target or all reviews could be run in the same cycle (same service on packagelists).
Using the project method would need to be tweaked to allow for multiple request types (as currently it has to be run twice, once for submit and once for delete), but that method currently includes already reviewed requests which adds to clutter the repo checker has to dig through.
Adding the project filter to review target method likely makes sense, but perhaps there are some unintended side-effects to other bots?
I don't mind adding more complex modes of operation, the existing ones should continue to work though to avoid breaking other bots.
Adding a new request query type is probably the way to go.
cu Ludwig
I went ahead and re-froze packagelists old repo checker. Assuming everything works out this time I will be looking to merge the new repo checker so if anyone has time to skim/review now would be the time.
Merged the pull request and close 6 issues.
Now those few file conflicts need to be resolved.
-- To unsubscribe, e-mail: opensuse-releaseteam+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-releaseteam+owner@opensuse.org