opensuse-releaseteam, In order to finish things up in regards to the repo checker (#964) [1] I will summarize the situation in the hopes of agreeing on a path forward. As noted [2] on the pull request I had frozen the existing osc-check_repo.py on packagelists in preparation for merging with delayed deployment for Factory. The changes conflicted with the AppArmor profile and were rolled back by Dominique. The new repo-checker user on OBS and _opensuse.org-repo-checker along with new services have remained on packagelists. The new repo checker has been running against Leap:42.3 for the last two weeks and has managed to discover a few legitimate problems. One of the notifications generated a discussion that resulted in a correction without interaction by the release team! The remaining areas for discussion have corresponding issues: - #973: repo_checker: speed up reviews by comparing has of staging project psuedometa - #974: repo_checker: invoke mirror, cycle, and install checks in parallel - #978: repo-checker.pl: detect/handle corrupt package snippet and general error handling - #979: repo_checker: cycles discussion - #980: repo_checker: include non-targeted package messages from installcheck The last two are the primary issues of interest. The cycles difference should not be too common and has a set of pros and cons associated with the changes. The primary blocker is the the inclusion of all installcheck/fileconflict problems from letter stagings. This change is again beneficial in detecting problems encountered by more complex packaging, but does not pass for both Leap:42.3 nor Factory. I have sent a number of SRs to resolve some of the issues, but the rest need to be resolved before the new repo checker will accept letter stagings. My suggested path forward would be to continue making the fixes rather than relaxing the check and resume the freezing of old repo checker. Max had mentioned the AppArmor profile was relaxed/disabled which would be good to confirm. I will likely look around on packagelists and make the change again. Once all the issues have been resolved in Factory I suggest we add both repo checker users for review and see that the results make sense before disabling the old repo checker. Given that I encountered the package snippet corruption bug twice more during local testing it definitely occurs. For those not familiar I also found a case in the deployed cache on packagelists. Anytime the corruption is encountered the old repo checker will accept all reviews regardless of issues. As such it makes sense to target switching to the new repo checker as soon as possible. The last minor discussion point is that the ReviewBot currently operates either on a project + request type or reviews targeting a user/group. The current repo checker uses the user/group target, but that would mix reviews for Factory and Leap in one cycle. The ReviewBot could be changed (or extended) to allow filtering by project in addition to review target or all reviews could be run in the same cycle (same service on packagelists). Using the project method would need to be tweaked to allow for multiple request types (as currently it has to be run twice, once for submit and once for delete), but that method currently includes already reviewed requests which adds to clutter the repo checker has to dig through. Adding the project filter to review target method likely makes sense, but perhaps there are some unintended side-effects to other bots? Additionally, it will mean that two repo checkers may run at the same time which locks up 100% cpu across the two cores on packagelists which makes the box a tad unresponsive. Either packagelists needs increased resources, the new repo checker should find a new home, or we accept the situation. Given all the other tools are split out per project I am leaning towards adding the project filter. [1] https://github.com/openSUSE/osc-plugin-factory [2] https://github.com/openSUSE/osc-plugin-factory/pull/964#issuecomment-3114991... I look forward to your thoughts, -- Jimmy -- To unsubscribe, e-mail: opensuse-releaseteam+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-releaseteam+owner@opensuse.org