[PATCH] RandR-1.3 fixes
`xrandr --prop` currently generates a lot of misleading (EE)s in log when randr-1.3 is used. 0001 fixes this. 0002 just makes GetProperty quieter; the INFO message generated isn't useful. Cheers, -- Yang Zhao http://yangman.ca
On Jun 08, 09 22:42:56 -0700, Yang Zhao wrote:
`xrandr --prop` currently generates a lot of misleading (EE)s in log when randr-1.3 is used. 0001 fixes this.
Hm. The patch changes semantics - the function will return TRUE now for unknown properties, and not FALSE. I thought the latter would be the correct behavior. Also, I don't think that printing them here makes *any* sense at all. Except for debugging. I'm committing a different change now, can you verify that it works for you as well? It looks good for me.
0002 just makes GetProperty quieter; the INFO message generated isn't useful.
This should have been a RHDFUNC, so it's only printed in -logverbose 7.
Thanks
Matthias
--
Matthias Hopf
2009/6/9 Matthias Hopf
On Jun 08, 09 22:42:56 -0700, Yang Zhao wrote:
`xrandr --prop` currently generates a lot of misleading (EE)s in log when randr-1.3 is used. 0001 fixes this.
Hm. The patch changes semantics - the function will return TRUE now for unknown properties, and not FALSE. I thought the latter would be the correct behavior.
I forced the default Success condition because the problematic properties weren't unknown but simply unhandled. My intuition was that GetProperty itself doesn't fail, but it simply has no effect on the current values.
I'm committing a different change now, can you verify that it works for you as well? It looks good for me.
Yup, it's a lot quieter now. Thanks, -- Yang Zhao http://yangman.ca -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
participants (2)
-
Matthias Hopf
-
Yang Zhao