Re: [radeonhd] Non-DRI build broken by 2cc9378e ("DRI/2D: Fix build for --disable-dri.")
Hans Ulrich Niedermann writes:
Hi,
2cc9378e contains changes like the following
-#include "rhd_dri.h" -#include "rhd_cp.h" +#ifdef USE_DRI +# include "rhd_dri.h" +# include "rhd_cp.h" +#else +typedef CARD8 uint8_t; +typedef CARD16 uint16_t; +typedef CARD32 uint32_t; +#endif
without checking that uintNN_t are actually undefined.
This makes a build after "configure --disable-dri" fail as follows (on my Fedora 9 system), just like IRC user "rbmorse" reported about his system:
src/radeon_accel.c:67: error: conflicting types for 'uint32_t' /usr/include/stdint.h:52: error: previous declaration of 'uint32_t' was here
Egbert, for what kinds of systems were those typedefs required, and could there be a different way to define uintNN_t for these systems?
Honestly I don't know. I've checked the header file which normally includes /usr/include/stdint.h. It does quite some voodoo to find out on which system which file is required. I wanted to stay away from this so I wrote up those simple typedefs. I don't know if there is a configure rule to test this and frankly I don't have the time to do any research on this. I personally would do a string replacement on all those types and replace them with well known X types. Cheers, Egbert. -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Wed, Jul 30, 2008 at 5:43 PM, Egbert Eich
Hans Ulrich Niedermann writes:
Hi,
2cc9378e contains changes like the following
-#include "rhd_dri.h" -#include "rhd_cp.h" +#ifdef USE_DRI +# include "rhd_dri.h" +# include "rhd_cp.h" +#else +typedef CARD8 uint8_t; +typedef CARD16 uint16_t; +typedef CARD32 uint32_t; +#endif
without checking that uintNN_t are actually undefined.
This makes a build after "configure --disable-dri" fail as follows (on my Fedora 9 system), just like IRC user "rbmorse" reported about his system:
src/radeon_accel.c:67: error: conflicting types for 'uint32_t' /usr/include/stdint.h:52: error: previous declaration of 'uint32_t' was here
Egbert, for what kinds of systems were those typedefs required, and could there be a different way to define uintNN_t for these systems?
Honestly I don't know. I've checked the header file which normally includes /usr/include/stdint.h. It does quite some voodoo to find out on which system which file is required. I wanted to stay away from this so I wrote up those simple typedefs. I don't know if there is a configure rule to test this and frankly I don't have the time to do any research on this. I personally would do a string replacement on all those types and replace them with well known X types.
I can't reproduce any build problems here, but why not just include stdint.h? Alex
participants (2)
-
Alex Deucher
-
Egbert Eich