PATCH: Report PANEL as disconnected when no modes are available
Report PANEL as disconnected when no modes are available diff --git a/src/rhd_randr.c b/src/rhd_randr.c index 8a6d643..1bbc0e7 100644 --- a/src/rhd_randr.c +++ b/src/rhd_randr.c @@ -749,8 +749,12 @@ rhdRROutputDetect(xf86OutputPtr output) RHDDebug(rhdPtr->scrnIndex, "%s: Output %s\n", __func__, rout->Name); /* Assume that a panel is always connected */ - if (rout->Connector->Type == RHD_CONNECTOR_PANEL) - return XF86OutputStatusConnected; + if (rout->Connector->Type == RHD_CONNECTOR_PANEL) { + if (rout->Connector->Monitor) + return XF86OutputStatusConnected; + else + return XF86OutputStatusDisconnected; + } if (rout->Connector->HPDCheck) { /* Hot Plug Detection available, use it */ -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Jan 30, 08 19:41:08 +0100, Thomas Meyer wrote:
Report PANEL as disconnected when no modes are available
Hm. Interesting. Why do you need this? In which case can this actually happen?
diff --git a/src/rhd_randr.c b/src/rhd_randr.c index 8a6d643..1bbc0e7 100644 --- a/src/rhd_randr.c +++ b/src/rhd_randr.c @@ -749,8 +749,12 @@ rhdRROutputDetect(xf86OutputPtr output) RHDDebug(rhdPtr->scrnIndex, "%s: Output %s\n", __func__, rout->Name); /* Assume that a panel is always connected */ - if (rout->Connector->Type == RHD_CONNECTOR_PANEL) - return XF86OutputStatusConnected; + if (rout->Connector->Type == RHD_CONNECTOR_PANEL) { + if (rout->Connector->Monitor) + return XF86OutputStatusConnected; + else + return XF86OutputStatusDisconnected; + } if (rout->Connector->HPDCheck) { /* Hot Plug Detection available, use it */
CU
Matthias
--
Matthias Hopf
Matthias Hopf schrieb:
On Jan 30, 08 19:41:08 +0100, Thomas Meyer wrote:
Report PANEL as disconnected when no modes are available
Hm. Interesting. Why do you need this? In which case can this actually happen?
compile radeonhd with --without-atombios (--disable-atombios). I'm searching for a way to define the PANEL layout in the xorg.conf file. I already talk with Egbert Eich about this. This has to do with an direct elilo (EFI) boot. In an EFI environment no ATOMBIOS is available. But the EFI mode seems to have some other problems as an external monitor works, but has some glitches. There is also a bug opened for this. With this patch the driver doesn't abend anymore, when no PANEL information is available (ATOMBIOS OR EDD).
diff --git a/src/rhd_randr.c b/src/rhd_randr.c index 8a6d643..1bbc0e7 100644 --- a/src/rhd_randr.c +++ b/src/rhd_randr.c @@ -749,8 +749,12 @@ rhdRROutputDetect(xf86OutputPtr output) RHDDebug(rhdPtr->scrnIndex, "%s: Output %s\n", __func__, rout->Name); /* Assume that a panel is always connected */ - if (rout->Connector->Type == RHD_CONNECTOR_PANEL) - return XF86OutputStatusConnected; + if (rout->Connector->Type == RHD_CONNECTOR_PANEL) { + if (rout->Connector->Monitor) + return XF86OutputStatusConnected; + else + return XF86OutputStatusDisconnected; + } if (rout->Connector->HPDCheck) { /* Hot Plug Detection available, use it */
CU
Matthias
-- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Feb 20, 08 19:08:58 +0100, Thomas Meyer wrote:
Report PANEL as disconnected when no modes are available
Hm. Interesting. Why do you need this? In which case can this actually happen?
compile radeonhd with --without-atombios (--disable-atombios). I'm searching for a way to define the PANEL layout in the xorg.conf file. I already talk with Egbert Eich about this. This has to do with an direct elilo (EFI) boot. In an EFI environment no ATOMBIOS is available. But the EFI mode seems to have some other problems as an external monitor works, but has some glitches. There is also a bug opened for this.
With this patch the driver doesn't abend anymore, when no PANEL information is available (ATOMBIOS OR EDD).
Sounds reasonable. I don't see any issues, so I applied. Thanks!
BTW - next time please try to get whitespace right :-)
Also the Subject was a bit ... unsuitable for git-am, so best use
git-format-patch next time.
CU
Matthias
--
Matthias Hopf
participants (2)
-
Matthias Hopf -
Thomas Meyer