What does rhd_conntest.c include <sys/io.h> for?
Hi, I have just tried to build radeonhd including rhd_conntest on i386, x86_64, ppc, and ppc64. The ppc and ppc64 builds failed. Reason: <sys/io.h> not being found. I checked what <sys/io.h> contained on my i386 system and sure enough, the rhd_conntest.c code uses none of it. I then removed the #include <sys/io.h> line from rhd_conntest.c, and now it built on all four platforms. If you want to click through to the build logs: - Aborts: http://koji.fedoraproject.org/koji/taskinfo?taskID=220906 - Builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=220948 -- Hans Ulrich Niedermann -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
On Tue, Oct 30, 2007 at 09:34:25PM +0100, Hans Ulrich Niedermann wrote:
Hi,
I have just tried to build radeonhd including rhd_conntest on i386, x86_64, ppc, and ppc64.
The ppc and ppc64 builds failed. Reason: <sys/io.h> not being found.
I checked what <sys/io.h> contained on my i386 system and sure enough, the rhd_conntest.c code uses none of it. I then removed the
#include <sys/io.h>
line from rhd_conntest.c, and now it built on all four platforms.
If you want to click through to the build logs: - Aborts: http://koji.fedoraproject.org/koji/taskinfo?taskID=220906 - Builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=220948
-- Hans Ulrich Niedermann
You're right, it isn't needed. It's a remnant from the quick and dirty little utils i tend to write when testing things, ones which need to poke the vga registers directly (in x86 io space) and need to be iopled. On radeonhd, we can do everything through mmio, so we do not need io.h. Luc Verhaegen. SUSE/Novell X Driver Developer. -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Luc Verhaegen wrote: [ "#include <sys/io.h>" line in rhd_conntest.c ]
You're right, it isn't needed. It's a remnant from the quick and dirty little utils i tend to write when testing things, ones which need to poke the vga registers directly (in x86 io space) and need to be iopled.
On radeonhd, we can do everything through mmio, so we do not need io.h.
Fix added to ndim-trivial-fixes, so it will not be forgotten: * http://radeonhd.lauft.net/patches/ndim-trivial-fixes/ * git pull http://radeonhd.lauft.net/xf86-video-radeonhd.git/ \ ndim-trivial-fixes -- Hans Ulrich Niedermann -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Luc Verhaegen wrote: [ #include <sys/io.h> ]
You're right, it isn't needed. It's a remnant from the quick and dirty little utils i tend to write when testing things, ones which need to
Is the linking against libz.so also a remnant of that, or may that possibly be used for something? Watching the symbols ld.so loads shows libz just being initialized at program startup and cleaned up at the end of the program. -- Hans Ulrich Niedermann -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Hans Ulrich Niedermann wrote:
Luc Verhaegen wrote:
[ #include <sys/io.h> ]
You're right, it isn't needed. It's a remnant from the quick and dirty little utils i tend to write when testing things, ones which need to
Is the linking against libz.so also a remnant of that, or may that possibly be used for something?
Answering my own question: -lpci requires -lz! libpci is linked against libz, even though rhd_conntest seems to not invoke that code path. -- Hans Ulrich Niedermann -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
participants (2)
-
Hans Ulrich Niedermann -
Luc Verhaegen