[patch] r5xx power management, take 2
Hi all, Here is an updated r5xx power management patch against the current master, efaebb70294055f371cd328124b23a343cea6a68. References to "PowerPlay" is now kept to only places where appropriate, and removed from the outward-facing interfaces. See John Bridgman's clarification: http://www.phoronix.com/forums/showpost.php?s=fd70114b5c1880e7c38864bde68bebe3&p=48104&postcount=7 . The XRandR property for controlling the active power profile is now "POWERMODE". xorg.conf option for controlling default power mode has been renamed "DefaultPowerMode". Cheers, -- Yang Zhao
On Wed, Oct 15, 2008 at 05:00:35PM -0700, Yang Zhao wrote:
Here is an updated r5xx power management patch against the current master, efaebb70294055f371cd328124b23a343cea6a68.
These patches do not apply. 0001 to 0049 are the same as the last series. They apply to 5fa3dc06d0c03297bd0f53b9fc20f0e647f7d57b but then 0053 does not apply. 0053 mixes stuff from 0011 and the current master, so I think you picked old version for the patches 0001 to 0049. michael
2008/10/18 Michael Olbrich
These patches do not apply. 0001 to 0049 are the same as the last series.
This was intentional. I merge changes to master as they happen, and they occasionally do not merge cleanly. I thought it'd be easier to simply repackage the entire series...
They apply to 5fa3dc06d0c03297bd0f53b9fc20f0e647f7d57b but then 0053 does not apply. 0053 mixes stuff from 0011 and the current master...
... but I was apparently wrong to assume git's smart merging would translate directly to format-patch. Thanks for letting me know. I'll try and figure something out when I have time. Cheers, -- Yang Zhao -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
You can now pull my r5xx_pm branch directly from http://yangman.ca/git/xf86-video-radeonhd.git/ This should hopefully work better than applying patch sets. Cheers, -- Yang Zhao -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
2008/10/21 Yang Zhao
You can now pull my r5xx_pm branch directly from http://yangman.ca/git/xf86-video-radeonhd.git/
Updated the branch with one that's been rebased to master. I've apparently been doing it wrong all these times by pulling changes from master into the branch. Now I know better. :) Cheers, -- Yang -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Yang Zhao wrote:
2008/10/21 Yang Zhao
: You can now pull my r5xx_pm branch directly from http://yangman.ca/git/xf86-video-radeonhd.git/
What do I have to do to use this? I've tried the following: git clone http://yangman.ca/git/xf86-video-radeonhd.git/ cd xf86-video-radeonhd ./autogen.sh make cp src/.libs/radeonhd_drv.so /usr/lib64/xorg/modules/drivers The resulting driver appears to work, but there's no indication (from xrandr --prop or the log) that any power management functionality is enabled. What am I missing? Thanks! -- ======================================================================== Ian Pilcher arequipeno@gmail.com ======================================================================== -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
./autogen.sh --prefix=/usr --libdir=/usr/lib64
make
sudo make install
that's the way I do it on F9 x86_64
LieGrü,
Strub
--- Ian Pilcher
Von: Ian Pilcher
Betreff: [radeonhd] Re: [patch] r5xx power management, take 2 An: radeonhd@opensuse.org Datum: Freitag, 31. Oktober 2008, 23:27 Yang Zhao wrote: 2008/10/21 Yang Zhao
: You can now pull my r5xx_pm branch directly from http://yangman.ca/git/xf86-video-radeonhd.git/
What do I have to do to use this? I've tried the following:
git clone http://yangman.ca/git/xf86-video-radeonhd.git/ cd xf86-video-radeonhd ./autogen.sh make cp src/.libs/radeonhd_drv.so /usr/lib64/xorg/modules/drivers
The resulting driver appears to work, but there's no indication (from xrandr --prop or the log) that any power management functionality is enabled.
What am I missing?
Thanks!
-- ======================================================================== Ian Pilcher arequipeno@gmail.com ========================================================================
-- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
-- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
2008/10/31 Ian Pilcher
Yang Zhao wrote:
2008/10/21 Yang Zhao
: You can now pull my r5xx_pm branch directly from http://yangman.ca/git/xf86-video-radeonhd.git/
What do I have to do to use this? I've tried the following: ...
The resulting driver appears to work, but there's no indication (from xrandr --prop or the log) that any power management functionality is enabled.
You need to specifically checkout the r5xx_pm branch. The HEAD reference on that repository is still pointing at master.
From an existing local git clone of xf86-video-radeonhd, do the following:
git branch -b r5xx_pm master git pull http://yangman.ca/git/xf86-video-radeonhd.git/ r5xx_pm:r5xx_pm The above two commands will create a local branch called r5xx_pm, then pull the diffs from the correct branch from my repository. -- Yang Zhao -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Yang Zhao wrote:
From an existing local git clone of xf86-video-radeonhd, do the following:
git branch -b r5xx_pm master git pull http://yangman.ca/git/xf86-video-radeonhd.git/ r5xx_pm:r5xx_pm
The above two commands will create a local branch called r5xx_pm, then pull the diffs from the correct branch from my repository.
OK, now I'm getting: /usr/include/xorg/xf86Crtc.h:694: error: expected declaration specifiers or '...' before 'I2CBusPtr' Any ideas? Thanks! -- ======================================================================== Ian Pilcher arequipeno@gmail.com ======================================================================== -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
2008/11/1 Ian Pilcher
Yang Zhao wrote:
git branch -b r5xx_pm master git pull http://yangman.ca/git/xf86-video-radeonhd.git/ r5xx_pm:r5xx_pm
OK, now I'm getting:
/usr/include/xorg/xf86Crtc.h:694: error: expected declaration specifiers or '...' before 'I2CBusPtr'
What version of xorg-server and related headers do you have installed? Does master compile for you? -- Yang Zhao -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Yang Zhao wrote:
What version of xorg-server and related headers do you have installed?
xorg-x11-server-Xorg-1.3.0.0-47.fc8 xorg-x11-server-sdk-1.3.0.0-47.fc8
Does master compile for you?
Yes. In fact, looking for uses of xf86Crtc.h in master gives me: src/rhd_randr.c:# include "xf86i2c.h" /* Missing in old versions of xf86Crtc.h */ src/rhd_randr.c:# include "xf86Crtc.h" Sure enough, including xf86i2c.h in rhd_powermgmt.c makes it build. Thanks for the responses! (Now to see if the power management code helps with my flickering/ shaking/black-out problem.) -- ======================================================================== Ian Pilcher arequipeno@gmail.com ======================================================================== -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Ian Pilcher wrote:
(Now to see if the power management code helps with my flickering/ shaking/black-out problem.)
OK, I can see the power management stuff in the log now, but the property isn't showing up in the output of xrandr --prop. Do I need to do anything other than use the r5xx_pm version of radeonhd_drv.so to make it visible? Thanks! -- ======================================================================== Ian Pilcher arequipeno@gmail.com ======================================================================== -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
2008/11/1 Ian Pilcher
OK, I can see the power management stuff in the log now, but the property isn't showing up in the output of xrandr --prop. Do I need to do anything other than use the r5xx_pm version of radeonhd_drv.so to make it visible?
Are you running xrandr-1.2 or higher? -- Yang Zhao -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
Yang Zhao wrote:
Are you running xrandr-1.2 or higher?
[pilcher@home ~]$ xrandr -v Server reports RandR version 1.2 I can see the other properties: [pilcher@home ~]$ xrandr --prop Screen 0: minimum 320 x 200, current 2960 x 1050, maximum 2960 x 1050 DVI-I_2/digital connected 1680x1050+1280+0 473mm x 296mm RANDR_OUTPUT_NUMBER: 4 (0x00000004) COHERENT: 0 (0x00000000) range: (0,1) RANDR_PANNING_AREA: RANDR_CONNECTOR_NUMBER: 3 (0x00000003) RANDR_CONNECTOR_TYPE: TMDS RANDR_SIGNAL_FORMAT: TMDS 1680x1050 59.9*+ 59.9 1400x1050 74.9 1280x1024 75.0 1440x900 74.9 60.0 1152x864 75.0 74.9 1024x768 75.1 70.1 60.0 832x624 74.6 800x600 72.2 75.0 60.3 56.2 640x480 75.0 72.8 66.7 60.0 720x400 70.1 DVI-I_1/analog disconnected RANDR_OUTPUT_NUMBER: 1 (0x00000001) RANDR_PANNING_AREA: RANDR_CONNECTOR_NUMBER: 1 (0x00000001) RANDR_CONNECTOR_TYPE: DVI RANDR_SIGNAL_FORMAT: VGA DVI-I_1/digital connected 1280x1024+0+0 338mm x 270mm RANDR_OUTPUT_NUMBER: 2 (0x00000002) COHERENT: 0 (0x00000000) range: (0,1) RANDR_PANNING_AREA: RANDR_CONNECTOR_NUMBER: 1 (0x00000001) RANDR_CONNECTOR_TYPE: TMDS RANDR_SIGNAL_FORMAT: TMDS 1280x1024 60.0*+ 75.0 1360x768 59.8 60.0 1280x800 60.0 1152x864 60.0 1280x768 60.0 1280x720 60.0 1024x768 75.1 70.1 60.0 800x600 72.2 75.0 60.3 56.2 640x480 75.0 72.8 60.0 59.9 720x400 70.1 TV_SVIDEO disconnected RANDR_OUTPUT_NUMBER: 3 (0x00000003) RANDR_PANNING_AREA: RANDR_CONNECTOR_NUMBER: 2 (0x00000002) RANDR_CONNECTOR_TYPE: TV RANDR_SIGNAL_FORMAT: unknown DVI-I_2/analog disconnected RANDR_OUTPUT_NUMBER: 3 (0x00000003) RANDR_PANNING_AREA: RANDR_CONNECTOR_NUMBER: 3 (0x00000003) RANDR_CONNECTOR_TYPE: DVI RANDR_SIGNAL_FORMAT: VGA -- ======================================================================== Ian Pilcher arequipeno@gmail.com ======================================================================== -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
2008/11/1 Ian Pilcher
Yang Zhao wrote:
Are you running xrandr-1.2 or higher?
[pilcher@home ~]$ xrandr -v Server reports RandR version 1.2
I can see the other properties: ...
Can you attach your Xorg.0.log please? I really don't know what's causing the issues you're experiencing. Assuming the code was pulled correctly, everything should just work. Just to be sure, please run `grep POWERMODE rhd_atomout.c` and double check that you indeed have the correct randr hooks checked out. -- Yang Zhao -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org
participants (5)
-
Ian Pilcher
-
Mark Struberg
-
Michael Olbrich
-
Yang Zhao
-
Yang Zhao